From ea3bd14d8b377818a16578bd5032a853188baeec Mon Sep 17 00:00:00 2001
From: Evilham <cvs@evilham.com>
Date: Tue, 28 Apr 2020 14:54:51 +0200
Subject: [PATCH] [logging] Mute warning on return_output=True when running
 scripts.

This fixes #806 which contains more information about the issue.

The TL;DR: this warning is not being useful and hinders debugging types because
it creates an innecessary line for each explorer.

An alternative proposal was #807 but was abandoned in favour of just dropping
the warning.
---
 cdist/exec/remote.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/cdist/exec/remote.py b/cdist/exec/remote.py
index e0ef66ec..f72bf3bf 100644
--- a/cdist/exec/remote.py
+++ b/cdist/exec/remote.py
@@ -280,9 +280,6 @@ class Remote(object):
         assert isinstance(command, (list, tuple)), (
                 "list or tuple argument expected, got: %s" % command)
 
-        if return_output and stdout is not subprocess.PIPE:
-            self.log.debug("return_output is True, ignoring stdout")
-
         close_stdout = False
         close_stderr = False
         if self.save_output_streams: