kjg/cdist
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[logging] Mute warning on return_output=True when running scripts.

Browse source 
This fixes #806 which contains more information about the issue.

The TL;DR: this warning is not being useful and hinders debugging types because
it creates an innecessary line for each explorer.

An alternative proposal was #807 but was abandoned in favour of just dropping
the warning.
This commit is contained in:
evilham 2020-04-28 14:54:51 +02:00
parent 515992249d
commit ea3bd14d8b
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cdist/exec/remote.py
View file

@ -280,9 +280,6 @@ class Remote(object):
assert isinstance(command, (list, tuple)), ( assert isinstance(command, (list, tuple)), (
"list or tuple argument expected, got: %s" % command) "list or tuple argument expected, got: %s" % command)
if return_output and stdout is not subprocess.PIPE:
self.log.debug("return_output is True, ignoring stdout")
close_stdout = False close_stdout = False
close_stderr = False close_stderr = False
if self.save_output_streams: if self.save_output_streams: