From 4628dad04576103945553609c9e46c71cee35de8 Mon Sep 17 00:00:00 2001
From: Steven Armstrong <steven@icarus.ethz.ch>
Date: Fri, 3 Feb 2012 20:55:24 +0100
Subject: [PATCH] cleaner way to set default values

Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
---
 conf/type/__key_value/explorer/value | 8 +++-----
 conf/type/__key_value/manifest       | 9 +++------
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/conf/type/__key_value/explorer/value b/conf/type/__key_value/explorer/value
index 3afc7cc5..b4e1fafd 100755
--- a/conf/type/__key_value/explorer/value
+++ b/conf/type/__key_value/explorer/value
@@ -21,11 +21,9 @@
 # Get the current value of key or __NOTSET__ if the key doesn't exist.
 #
 
-if [ -f "$__object/parameter/key" ]; then
-   key="$(cat "$__object/parameter/key")"
-else
-   key="$__object_id"
-fi
+key="$(cat "$__object/parameter/key" 2>/dev/null \
+   || echo "$__object_id")"
+
 file="$(cat "$__object/parameter/file")"
 delimiter="$(cat "$__object/parameter/delimiter")"
 
diff --git a/conf/type/__key_value/manifest b/conf/type/__key_value/manifest
index 706b0b0d..84c06352 100755
--- a/conf/type/__key_value/manifest
+++ b/conf/type/__key_value/manifest
@@ -18,9 +18,6 @@
 # along with cdist. If not, see <http://www.gnu.org/licenses/>.
 #
 
-if [ -f "$__object/parameter/key" ]; then
-   key="$(cat "$__object/parameter/key")"
-else
-   echo "$__object_id" > "$__object/parameter/key"
-fi
-
+# set defaults
+[ -f "$__object/parameter/key" ] \
+   || echo "$__object_id" > "$__object/parameter/key"