GitLab

__package_pip: add optional (extra) dependencies

See merge request ungleich-public/cdist!975

[__letsencrypt_cert] Fix various issues with hooks.

Closes #853

See merge request ungleich-public/cdist!977

__postgres_role: implement modification of roles

See merge request ungleich-public/cdist!973

.. by fully replacing it with a smaller sentence.

Pip matches them insensitive, so we need to do the same to avoid
problems by saying extras are not installed but already is there in
place.

Adjusted comments for `explorer/extras` and updated the man page for the
new behaviour of updating the extras.

This will fix if a package will be upgraded from some extras to all
extras. Previously, it will not work because some dependencies of 'all'
are already installed, so the feature 'all' is already installed.

Now, it will use a list of all extras to iterate over them separatly. This
will result it will never install all extras via `[all]`, but rather
`[foo,bar]`.

Useless `cat $file`, use `< $file` instead.

As the previous detection took the wrong values, this explorer now
checks if packages for an extra are installed or not. If not, the extra
is not installed.

Based on the information of the explorer, it will install the package
again with the absent extras.

Compares the explorer against the parameters and install those extras
that are not already installed.

The two new explorers detect all installed extras for this package.

While there address some minor issues in the comments in the hook contents.

This could break in odd ways if they passed sth like:
cat <<eof
bla bla
eof

Happy fingers are happy and like adding slashes places.

Closes #853, see issue for full description / discussion.

Short summary:
- There was about 6.53% chances of `--renewal-hook` not being applied
- Using --automatic-renewal in one cert and not in another was an error.
- It was not possible to use different hooks for different certificates.
- FreeBSD support was utterly broken.

explorer/memory: fix to return result in kiB for all systems and add support for Solaris

See merge request ungleich-public/cdist!967

BSDs were MiB before.

This is a poor implementation of optional dependencies for pip packages.
It ensures to install them if the package will be installed, but does
not take into account if they must be added/removed after the package is
already installed. Also, it will not be autoremoved, as all dependencies
will not be removed.

sshd config: Produce error if invalid config is generated, fix processing of AuthenticationMethods and AuthorizedKeysFile, document explorer bug

See merge request ungleich-public/cdist!968

Fix debug parameter

Closes #849

See merge request ungleich-public/cdist!970

-d was removed from cdist in favor of mulitple -v and -l parameters, but
-d was not removed from preos.

Resolve #849.

They were incorrectly treated as non-singleton options before.

cf. https://github.com/openssh/openssh-portable/blob/V_8_4/servconf.c#L2273
and https://github.com/openssh/openssh-portable/blob/V_8_4/servconf.c#L1899 resp.

Previously, cdist would silently swallow the error (no invalid config file was
generated).

Reason: `set -e` does not exit if a command in a sub-command group fails,
it merely returns with a non-zero exit status.

e.g. the following snippet does not abort the script if sshd -t returns with a
non-zero exit status:

    set -e
    cmp -s old new || {
        # check config file and update it
        sshd -t -f new \
        && cat new >old
    }

or compressed:

    set -e
    false || { false && true; }
    echo $?
    # prints 1

Added optional dirmode parameter to set the mode of (optional) the directory.

See merge request ungleich-public/cdist!966

We need to make sure that the password does not end up in ~/.psql_history.