Minimal VAT validation on billing address registration

This commit is contained in:
fnux 2020-04-15 16:01:31 +02:00
parent c6ca94800e
commit 3fa1d5753e
3 changed files with 29 additions and 6 deletions

View file

@ -18,3 +18,7 @@ django-hardcopy
# schema support # schema support
pyyaml pyyaml
uritemplate uritemplate
# Comprehensive interface to validate VAT numbers, making use of the VIES
# service for European countries.
vat-validator

View file

@ -56,15 +56,10 @@ class BillRecordSerializer(serializers.Serializer):
order = serializers.HyperlinkedRelatedField( order = serializers.HyperlinkedRelatedField(
view_name='order-detail', view_name='order-detail',
read_only=True) read_only=True)
description = serializers.CharField()
recurring_period = serializers.CharField()
recurring_price = serializers.DecimalField(max_digits=10, decimal_places=2)
recurring_count = serializers.DecimalField(max_digits=10, decimal_places=2)
one_time_price = serializers.DecimalField(max_digits=10, decimal_places=2)
amount = serializers.DecimalField(max_digits=10, decimal_places=2)
class BillSerializer(serializers.ModelSerializer): class BillSerializer(serializers.ModelSerializer):
records = BillRecordSerializer(many=True, read_only=True) records = BillRecordSerializer(many=True, read_only=True)
class Meta: class Meta:
model = Bill model = Bill
fields = ['reference', 'owner', 'total', 'due_date', 'creation_date', fields = ['reference', 'owner', 'total', 'due_date', 'creation_date',

View file

@ -7,12 +7,15 @@ from rest_framework.response import Response
from rest_framework.decorators import action from rest_framework.decorators import action
from rest_framework.reverse import reverse from rest_framework.reverse import reverse
from rest_framework.decorators import renderer_classes from rest_framework.decorators import renderer_classes
from vat_validator import validate_vat, vies
from vat_validator.countries import EU_COUNTRY_CODES
import json import json
from .models import * from .models import *
from .serializers import * from .serializers import *
from datetime import datetime from datetime import datetime
from vat_validator import sanitize_vat
import uncloud_pay.stripe as uncloud_stripe import uncloud_pay.stripe as uncloud_stripe
### ###
@ -206,7 +209,28 @@ class BillingAddressViewSet(mixins.CreateModelMixin,
def create(self, request): def create(self, request):
serializer = self.get_serializer(data=request.data) serializer = self.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True) serializer.is_valid(raise_exception=True)
# Validate VAT numbers.
country = serializer.validated_data["country"]
vat_number = serializer.validated_data["vat_number"]
# We ignore empty VAT numbers.
if vat_number != "":
if not validate_vat(country, vat_number):
return Response(
{'error': 'Malformed VAT number.'},
status=status.HTTP_400_BAD_REQUEST)
elif country in EU_COUNTRY_CODES:
# FIXME: make a synchroneous call to a third patry API here is
# not a good idea...
vies_state = vies.check_vat(country, vat_number)
if not vies_state.valid:
return Response(
{'error': 'European VAT number does not exist in VIES.'},
status=status.HTTP_400_BAD_REQUEST)
serializer.save(owner=request.user) serializer.save(owner=request.user)
return Response(serializer.data)
### ###
# Old admin stuff. # Old admin stuff.