From 9d2f418f78134c9fdc7b55cc5d08509efa21e7c9 Mon Sep 17 00:00:00 2001
From: Nico Schottelius <nico@nico-notebook.schottelius.org>
Date: Wed, 3 Apr 2019 12:38:55 +0200
Subject: [PATCH] Remove cloning on table miss

---
 doc/plan.org            | 7 +++----
 p4src/static-mapping.p4 | 3 ++-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/plan.org b/doc/plan.org
index 0952f50..2b40b7a 100644
--- a/doc/plan.org
+++ b/doc/plan.org
@@ -713,8 +713,7 @@ According to pcap/static_nat64-2019-04-03-0932-h3.pcap ethernet frame
 looks good. Still no reply / reaction from host h3.
 ****** DONE Fix IPv4 header checksum // wrong according to wireshark
 When & how to update?
-****** TODO check packets static_nat64-2019-04-03-0957-h1.pcap: answer not outputted/natted!
-
+****** DONE check packets static_nat64-2019-04-03-0957-h1.pcap: answer not outputted/natted!
 INFO:main:unhandled reassambled=<Ether  dst=33:33:ff:00:00:42 src=00:00:0a:00:00:01 type=0x86dd |<IPv6  version=6 tc=0 fl=0 plen=32 nh=ICMPv6 hlim=255 src=fe80::200:aff:fe00:1 dst=ff02::1:ff00:42 |<ICMPv6ND_NS  type=Neighbor Solicitation code=0 cksum=0x37df res=0 tgt=2001:db8::42 |<ICMPv6NDOptSrcLLAddr  type=1 len=1 lladdr=00:00:0a:00:00:01 |>>>> from table TABLE_V6_NETWORKS
 INFO:main:unhandled reassambled=<Ether  dst=33:33:ff:00:00:42 src=00:00:0a:00:00:01 type=0x86dd |<IPv6  version=6 tc=0 fl=0 plen=32 nh=ICMPv6 hlim=255 src=fe80::200:aff:fe00:1 dst=ff02::1:ff00:42 |<ICMPv6ND_NS  type=Neighbor Solicitation code=0 cksum=0x37df res=0 tgt=2001:db8::42 |<ICMPv6NDOptSrcLLAddr  type=1 len=1 lladdr=00:00:0a:00:00:01 |>>>> from table TABLE_V6_NETWORKS
 INFO:main:unhandled reassambled=<Ether  dst=33:33:ff:00:00:42 src=00:00:0a:00:00:01 type=0x86dd |<IPv6  version=6 tc=0 fl=0 plen=32 nh=ICMPv6 hlim=255 src=2001:db8::1 dst=ff02::1:ff00:42 |<ICMPv6ND_NS  type=Neighbor Solicitation code=0 cksum=0x13a7 res=0 tgt=2001:db8::42 |<ICMPv6NDOptSrcLLAddr  type=1 len=1 lladdr=00:00:0a:00:00:01 |>>>> from table TABLE_V6_NETWORKS
@@ -727,18 +726,18 @@ runtime data:        20:01:0d:b8:00:00:00:00:00:00:00:00:00:00:00:00    0a:01:01
 Entry has been added with handle 0
 ******* DONE if nat46_static is called, why is the ethernet type still ipv4? -> log!
 ******** DONE nat46 table is applied
-******* TODO Check why there is a miss in the table
+******* DONE Check why there is a miss in the table -> c&p bug?
 [09:57:31.415] [bmv2] [T] [thread 9332] [105.0] [cxt 0] Applying table 'MyIngress.v6_networks'
 [09:57:31.415] [bmv2] [D] [thread 9332] [105.0] [cxt 0] Looking up key:
  * hdr.ipv6.dst_addr   : 20010db8000000000000000000000001
 
 [09:57:31.415] [bmv2] [D] [thread 9332] [105.0] [cxt 0] Table 'MyIngress.v6_networks': miss
 
-
 ***** TODO transform protocol specific: icmp -> icmp6
 ****** DONE Make switch answer IPv4 icmp echo request for
 ******* DONE Make switch respond to ARP
 ******* DONE Make switch respond to icmp echo request w/ correct checksum (2019-04-03)
+******* TODO Correct icmp6 checksum
 **** TODO Add / check default route for v4 hosts
 **** TODO Update p4c to avoid compiler bug
 ***** TODO Updating p4c
diff --git a/p4src/static-mapping.p4 b/p4src/static-mapping.p4
index 14fdc2f..2a476c4 100644
--- a/p4src/static-mapping.p4
+++ b/p4src/static-mapping.p4
@@ -336,7 +336,8 @@ Echo or Echo Reply Message
             NoAction;
         }
         size = ICMP_TABLE_SIZE;
-        default_action = controller_debug_table_id(TABLE_ICMP);
+//        default_action = controller_debug_table_id(TABLE_ICMP);
+        default_action = NoAction; /* do not clone on miss */
     }
 
     /********************** ARP ***********************************/