From b3f4d3849a687a1795302cb25d3c50c251a4417c Mon Sep 17 00:00:00 2001
From: Jonas Weber <github@jonasw.de>
Date: Thu, 4 Oct 2018 13:34:11 +0200
Subject: [PATCH] Fix __install_umount target parameter

---
 cdist/conf/type/__install_umount/manifest     | 25 -------------------
 .../__install_umount/parameter/default/target |  1 +
 .../type/__install_umount/parameter/optional  |  1 +
 3 files changed, 2 insertions(+), 25 deletions(-)
 delete mode 100755 cdist/conf/type/__install_umount/manifest
 create mode 100644 cdist/conf/type/__install_umount/parameter/default/target
 create mode 100644 cdist/conf/type/__install_umount/parameter/optional

diff --git a/cdist/conf/type/__install_umount/manifest b/cdist/conf/type/__install_umount/manifest
deleted file mode 100755
index d900df1b..00000000
--- a/cdist/conf/type/__install_umount/manifest
+++ /dev/null
@@ -1,25 +0,0 @@
-#!/bin/sh -e
-#
-# 2011 Steven Armstrong (steven-cdist at armstrong.cc)
-#
-# This file is part of cdist.
-#
-# cdist is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-#
-# cdist is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with cdist. If not, see <http://www.gnu.org/licenses/>.
-#
-
-# set defaults
-# TODO is this neccesary or should this be handled using the usual parameter/default workflow?
-if [ ! -f "$__object/parameter/target" ]; then
-	echo "/target" > "$__object/parameter/target"
-fi
diff --git a/cdist/conf/type/__install_umount/parameter/default/target b/cdist/conf/type/__install_umount/parameter/default/target
new file mode 100644
index 00000000..ea8c4bf7
--- /dev/null
+++ b/cdist/conf/type/__install_umount/parameter/default/target
@@ -0,0 +1 @@
+/target
diff --git a/cdist/conf/type/__install_umount/parameter/optional b/cdist/conf/type/__install_umount/parameter/optional
new file mode 100644
index 00000000..eb5a316c
--- /dev/null
+++ b/cdist/conf/type/__install_umount/parameter/optional
@@ -0,0 +1 @@
+target