Commit graph

49 commits

Author SHA1 Message Date
15af9f8d9c Stop writing passwords and reset links to logs
SeedRetrieveCreate printed every submitted password to stdout, so it
ended up in container and server logs. The reset view logged complete
reset URLs at debug level, and those work as credentials until used.
2026-11-06 15:04:23 +03:00
f675ce9e31 Reject usernames that exist anywhere in the directory
Registration only collided inside ou=customers, so a staff username
from ou=users could be registered again as a customer, creating two
accounts with the same uid. Check the whole tree (ENTIRE_SEARCH_BASE)
on the register form, in the create API, and again at activation in
case the name was taken in between.
2026-11-06 15:03:14 +03:00
dad66040ed Keep passwords out of activation links
The activation link carried base64-encoded username, password, names
and email, so plaintext passwords ended up in mail archives, browser
history and proxy logs.

Registration now hashes the password to {SSHA} immediately and stores
it in a new PendingRegistration table (migration 0002). The emailed
link is /activate/<token>/ with a random token only, and activation
writes the stored hash into LDAP. Pending entries expire after 24h,
like reset tokens. This also drops the PseudoUser/token-generator
workaround.

Links in emails sent before deployment stop working; those users must
register again.
2026-11-06 15:02:41 +03:00
23ddf33d41 Require a verified reset link to set a new password
ResetRequest.post took the username from a hidden form field and
changed that user's password without checking any token, so anyone
could take over any account with a single POST to /reset/.

Opening a valid reset link now stores the verified username in the
session (valid for one hour, cleared after use). The POST only acts on
that user and ignores the form field. Reset tokens now come from
secrets.token_urlsafe, and malformed links return 404 instead of 500.
2026-11-06 15:01:47 +03:00
b44e2ffcf4 Escape user input in LDAP filters and DNs
The uid was formatted straight into search filters, so a password
reset for user '*' matched and changed the first entry in the tree
(staff accounts included). Escape filter values with
escape_filter_chars and DN values with escape_rdn.

Also fix the username pattern: [a-z|0-9|\-|_] allowed '|'.
2026-11-06 15:01:06 +03:00
Timothee Floure
a7b9d70b9d Merge upstream repository and code running on production... 2020-05-24 08:04:25 +02:00
26916f7def Validate username format in what seem to be WIP API? 2020-05-01 11:11:24 +02:00
4cf0161d7c Ask for username instead of email for login, validate username on
registration
2020-05-01 11:08:13 +02:00
8a8cc5d20e better response messsage 2019-05-30 05:17:20 -04:00
e1b4aac222 fix typho response -> Response 2019-05-30 05:07:06 -04:00
f6b723b76a fix typho in creation link 2019-05-30 05:04:11 -04:00
ce5f88b134 fix hardwritten test 2019-05-26 16:59:52 -04:00
d37144c541 seed listing view and template 2019-05-26 16:15:07 -04:00
9576ae9064 Same messages in creation/deletion preventing scape chars errors in password 2019-05-06 11:42:58 -04:00
9711dc1ecc fix show message error when not valid credentials 2019-05-05 18:12:43 -04:00
200699486a rest interface for retrieve-create users seed 2019-05-05 16:44:02 -04:00
86a082c29f Fix typho email verification 2019-05-02 17:36:31 -04:00
d07ff15f69 Add validation email before creation 2019-05-02 17:29:01 -04:00
c4079a1c1d request the username in login instead of the email 2019-05-02 04:10:06 -04:00
926b91ef97 fix password reset view 2019-05-01 17:48:24 -04:00
PCoder
3a88a98b95 Add logger + improve the way we build password reset url 2019-05-01 20:39:25 +02:00
f29ac4eb2f Added sending welcome email on user registration 2019-04-25 16:14:58 -04:00
019ac98249 added rest user creation 2019-04-23 01:19:45 -04:00
PCoder
7191eb0997 Initialize checks_out variable to False (missing before) 2019-02-24 23:51:41 +01:00
PCoder
bcb3d6165d Logout user after password reset 2019-02-24 23:32:50 +01:00
PCoder
bdb57221e5 Also check user before password reset 2019-02-24 23:25:12 +01:00
PCoder
a5e91ffda2 Simplify search_base logic 2019-02-24 22:23:43 +01:00
PCoder
c0264e5dda Remove LoginRequiredMixin for ResetPassword view
As this can be done even when the user is logged out
2019-02-24 20:35:29 +01:00
PCoder
a20e9479c8 Add login_url for all LoginRequiredMixin views 2019-02-24 20:34:53 +01:00
PCoder
d4a02dc571 Remove unused imports 2019-02-24 20:16:10 +01:00
PCoder
5903e10d87 Redirect user to login page after logout 2019-02-24 20:15:52 +01:00
PCoder
f61023d01a Take user to logged in page when already authenticated 2019-02-24 20:14:49 +01:00
PCoder
c3b8f7b553 Add LoginRequiredMixin mixin for various views 2019-02-24 20:13:09 +01:00
PCoder
acff3fc592 Use LdapManager in password reset too 2019-02-24 18:42:27 +01:00
PCoder
16b02cfe3f Create base_url from request rather than hard code 2019-02-24 18:42:02 +01:00
PCoder
9ce45e6f56 Set EMAIL_FROM_ADDRESS from env 2019-02-24 18:41:07 +01:00
PCoder
6e0788097f Update message 2019-02-24 17:46:44 +01:00
PCoder
db4ffe7979 Use LdapManager delete_user to delete the user's account 2019-02-24 17:45:39 +01:00
PCoder
a909a9b5c5 Add change_user_details 2019-02-24 17:25:58 +01:00
PCoder
3bc2e0a7e5 Take uid as parameter for change_password instead of user_dn 2019-02-24 17:24:44 +01:00
PCoder
3f7ab047a5 Use LdapManager call in change user details page 2019-02-24 15:29:40 +01:00
PCoder
57fe6a0143 Call create_user code 2019-02-23 21:29:33 +01:00
PCoder
122ee37e48 Use LdapManager to change password 2019-02-23 19:50:42 +01:00
PCoder
f6f688dcb5 WIP: Add ungleich_ldap and use it to reset password 2019-02-23 18:47:01 +01:00
PCoder
6a28b51354 Fix bug: check the posted username also with logged in user's
username
2019-02-23 18:45:58 +01:00
PCoder
113fa2c454 Pickup env variables and use them 2019-02-23 18:45:21 +01:00
PCoder
5c96f5c186 Add form_valid to the index form 2019-02-23 09:20:58 +01:00
PCoder
a6a6f8213b Add LoginForm 2019-02-19 23:16:05 +01:00
PCoder
ace2fa6eb9 Move project files to root directory 2019-02-17 17:43:06 +01:00
Renamed from dal/dal/views.py (Browse further)