GitLab

__netbox type

See merge request ungleich-public/cdist-contrib!12

__netbox type improvements

See merge request ungleich-public/cdist-contrib!17

Mostly invalid links ..

This is not required any more because it was completly replaced by
`python3-venv`. The venv handling is already given to `__pyvenv`.

Mostly added notes of what does not work that well.

Now, the venv and pip things are done before the program files are
replaced, which should minimize the outage where the application is not
available.

The first one was deprecated by the second one.

Now, the python venv is now created via `pyvenv` or `python3 -m venv`
instead of the legacy `virtualenv`. For this, not all python processes
from the venv need to be stopped.

Migration from previous versions of this type may be difficult, but
solvable if the venv will be recreated.

To avoid an error from pip, it will be checked if there are packages to
uninstall. This is better than just doing `|| true`.

The Gunicorn type now supports systemd sockets only. With uWSGI, you can
choose between it and the native sockets based on the parameters chosen.
This is done because it could not be implemented to have multiple
protocols with the systemd sockets (so you may choose).

The systemd socket unit file is generally available, so both types use
the same script to generate the socket unit file.

Changed flag (force to ignore a non-existant directory), typo and
swapped arguments are done. Also, the process to stop all processes from
the virtal environment has changed: Now, it stops all potential services
and ignore errors (because a service doesn't exist).

After that, it sends a kill signal to all processes and then gracefully
wait since there is no option to do that with systemd.

Mostly added -q to the pip calls. Also forced the temp directory removal.

This adds the force flag to `ln` to avoid aborts cause the link already
exists and so forth. It also adds robustness to the execution.

This code tries to remove packages not needed anymore. As it presumably
not removing dependencies, it's not that perfect pice of script.

The default value is set to preserve all data saved by netbox. As
explained in the manpage, it sets the directory for all data directories
to `~netbox/data/` (would resolve to `/opt/netbox/data/`), so upgrades
will not remove this data.

Calls where added because there are used upstream in the
`upgrade.sh`-Script, too.

Upgrade-Script:
  https://github.com/netbox-community/netbox/blob/develop/upgrade.sh

Adding a place to keep all configuration stuff for cdist seperated from
the installation directory. For safety reasons.

This commit brings consistency into the --restart parameter for systemd
units. All units except the netbox wrapper service will be restarted on
unit change.

Cause of corrupt databases if the services are restarted incorrectly,
the order and dependencies are adjusted. Now, the `netbox-rq` service
will be included in restarts of `netbox` and required for the WSGI
servers that it must running.

For these changes, the restart command of `__netbox` was adjusted. The
other ones where edited too, to use the same command.

All services now require redis and postgresql to be started before them
to prevent any start order issues.

If someone asked for what the RQ worker is required, see here:
 https://netbox.readthedocs.io/en/stable/additional-features/webhooks/#webhook-processing

The used character set should now only contain characters used by the
`netbox/generate_secret_key.py` program. Finially got correct escaping.

Template script for the `configuration.py` interpreted the boolean flag
incorrectly and did the thing the user do not wanted.

Because `/dev/random` was used, the `cdist config` could hang a long
time to get real random values. The pseudo-generated values through
`/dev/urandom` are fully enought for the secret key.

Mixed up a parameter. Should be correct now.

Required to get "admin access".

If the here-document is empty because no file could be found, an empty
line will be read. The new line of code will skip in those cases.

Adds the --state parameter to both types. With it, the transition
between both types can be done smothly.

Because `set -e` got printed all the time, the type __netbox always had
some generated code for the remote side. This line was removed because
this is already done by cdist when executing the code-remote script.

Rather, the exit-on-error option was set to some scirpts (two ..).

Revert working directory changes as the configuration file still needs
to be accessable. An absolute path would work, too, but it is not the
preferred way.

To still work with the python wsgi application, `--chdir` is used.

New option to directly serve static content via uWSGI.

Fixed shellcheck cause of the find command. This required a bigger
change due to variables and subshell. Now, input is used through a
here-document.

The `uwsgi-netbox` service now works, also the `netbox` wrapper service.
The PID file was removed from the Gunicorn service as it is not required
and a bit more efford to move it to `/run/` due to permissions.

Generally, all depend on `network.target` instead of
`network-online.target` now, and signals for reload, stop and kill were
added (especially required the uwsgi service).

To avoid aborts because of the python venv could not be updated by
killing all processes that uses the venv.

It will be done all times to prevent any error, because it could not be
reliably detected if the type installs or updates NetBox.

This should have been done much earlier .. :/

Enables multiple protocols like fastcgi or HTTP to bind to. This makes
it more flexible to use.

Also, a little fix for __netbox was done: correctly output a error msg.

Shellcheck warned about creating content for a python array. As the
string will be printed literally into the config, the warning does not
match to the current case.