From 87d4c33e26b2b8fa67da0dcbc01a9f70f5e9c705 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timoth=C3=A9e=20Floure?= <timothee.floure@posteo.net>
Date: Wed, 13 Jan 2021 08:54:28 +0100
Subject: [PATCH] Make shellcheck happy with the __jitsi_* types

---
 type/__jitsi_meet/manifest        | 6 +++---
 type/__jitsi_meet_domain/manifest | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/type/__jitsi_meet/manifest b/type/__jitsi_meet/manifest
index f5fbe8c..d4d16dc 100755
--- a/type/__jitsi_meet/manifest
+++ b/type/__jitsi_meet/manifest
@@ -43,6 +43,7 @@ require="__apt_source/jitsi_meet" __apt_update_index
 export require="${require} __apt_source/jitsi_meet __apt_update_index"
 
 # Pre-feed debconf settings, so Jitsi's installation has a good config
+# shellcheck source=type/__jitsi_meet/files/debconf_settings.sh
 . "${__type}/files/debconf_settings.sh"  # This defines DEBCONF_SETTINGS
 __debconf_set_selections jitsi_meet --file - <<EOF
 ${DEBCONF_SETTINGS}
@@ -50,9 +51,7 @@ EOF
 export require="${require} __debconf_set_selections/jitsi_meet"
 
 # Install and upgrade packages as needed
-for pkg in jitsi-meet; do
-	__package "${pkg}"
-done
+__package jitsi-meet
 
 # Proceed only after installation/upgrade has finished
 export require="__package/jitsi-meet"
@@ -182,6 +181,7 @@ EOF
 	esac
 	if [ "${PROMETHEUS_JITSI_EXPORTER_SHOULD_VERSION}" != \
 		"${PROMETHEUS_JITSI_EXPORTER_IS_VERSION}" ]; then
+		# shellcheck disable=SC2059
 		__download \
 			/tmp/prometheus-jitsi-meet-exporter \
 			--url "${PROMETHEUS_JITSI_EXPORTER_URL}" \
diff --git a/type/__jitsi_meet_domain/manifest b/type/__jitsi_meet_domain/manifest
index 8d28256..40b07b0 100755
--- a/type/__jitsi_meet_domain/manifest
+++ b/type/__jitsi_meet_domain/manifest
@@ -47,6 +47,7 @@ __letsencrypt_cert "${DOMAIN}" \
 	--webroot /usr/share/jitsi-meet
 
 # Create virtualhost for nginx
+# shellcheck source=type/__jitsi_meet_domain/files/nginx.sh
 . "${__type}/files/nginx.sh"  # This defines JITSI_NGINX_CONFIG
 require="__letsencrypt_cert/${DOMAIN}" __file \
 	"/etc/nginx/sites-enabled/${DOMAIN}.conf" \
@@ -55,6 +56,7 @@ ${JITSI_NGINX_CONFIG}
 EOF
 
 # Setup jitsi config
+# shellcheck source=type/__jitsi_meet_domain/files/config.js.sh
 . "${__type}/files/config.js.sh"  # This defines JITSI_CONFIG_JS
 __file "/etc/jitsi/meet/${DOMAIN}-config.js" \
 	--mode 0644 --source "-" <<EOF