tom/cdist
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

don't duplicate Remote::mkdir in explorer transfer

Browse source 
Remote::transfer contains a call to mkdir(destination) if the source is
a directory. since the destination must also be a directory we can omit
extra mkdir calls in Explorer.

this saves about 10% on my manifests in sequential mode, and about 6% in
parallel mode.
This commit is contained in:
dhivael 2018-09-21 22:54:37 +02:00
parent d6952543a7
commit f918acd725
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cdist/core/explorer.py
View file

@ -147,7 +147,6 @@ class Explorer(object):
def transfer_global_explorers(self): def transfer_global_explorers(self):
"""Transfer the global explorers to the remote side.""" """Transfer the global explorers to the remote side."""
self.remote.mkdir(self.remote.global_explorer_path)
self.remote.transfer(self.local.global_explorer_path, self.remote.transfer(self.local.global_explorer_path,
self.remote.global_explorer_path, self.remote.global_explorer_path,
self.jobs) self.jobs)
@ -223,7 +222,6 @@ class Explorer(object):
cdist_type.explorer_path) cdist_type.explorer_path)
destination = os.path.join(self.remote.type_path, destination = os.path.join(self.remote.type_path,
cdist_type.explorer_path) cdist_type.explorer_path)
self.remote.mkdir(destination)
self.remote.transfer(source, destination) self.remote.transfer(source, destination)
self.remote.run(["chmod", "0700", "%s/*" % (destination)]) self.remote.run(["chmod", "0700", "%s/*" % (destination)])
self._type_explorers_transferred.append(cdist_type.name) self._type_explorers_transferred.append(cdist_type.name)
@ -235,5 +233,4 @@ class Explorer(object):
cdist_object.parameter_path) cdist_object.parameter_path)
destination = os.path.join(self.remote.object_path, destination = os.path.join(self.remote.object_path,
cdist_object.parameter_path) cdist_object.parameter_path)
self.remote.mkdir(destination)
self.remote.transfer(source, destination) self.remote.transfer(source, destination)