ungleich-gitea

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:54 +00:00

make everything pass shellcheck

Created by: darko-poljak

@4nd3r I am starting to work on this. I will create a PR with first changes where we can further discuss this.

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:53 +00:00

make everything pass shellcheck

Created by: darko-poljak

Can you take a look at https://github.com/ungleich/cdist/compare/master...darko-poljak:shellcheck if you can spot some mistake prior to creating PR?

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:52 +00:00

make everything pass shellcheck

Created by: 4nd3r

woah, that's a big change! it'll take some time to scroll through it. will do.

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:51 +00:00

make everything pass shellcheck

Created by: darko-poljak

Hm... shellcheck can not check code that would be generated by gencode unless code is checked after it is generated. Guess this should be fixed when someone reports it.…

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:49 +00:00

make everything pass shellcheck

Created by: darko-poljak

@asteven Can you also take a look if you have time? Here https://github.com/ungleich/cdist/issues/518 will also be handled.

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:48 +00:00

make everything pass shellcheck

Created by: darko-poljak

We need to check code generation and fix as many as we notice. e.g.: __staged_file/gencode-remote generates code that uses mktemp --tmpdir, should be mktemp -p instead.

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:47 +00:00

make everything pass shellcheck

Created by: darko-poljak

@asteven For mktemp, POSIX does not specify mktemp utility. Also, -p is not defined for FreeBSD mktemp. TMPDIR env var is used for this, '/tmp' as default if not…

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:45 +00:00

make everything pass shellcheck

Created by: darko-poljak

For specific things, like apt types, which uses GNU version of find I think we do not need to port it to portable POSIX shell code, because apt is specific for debian-like…

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:44 +00:00

make everything pass shellcheck

Created by: 4nd3r

because apt is specific for debian-like GNU/Linux distros which have GNU tools by default

then we should add # shellcheck disable=<code> before that line.

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:43 +00:00

make everything pass shellcheck

Created by: darko-poljak

We can add Makefile target for shellcheck manifest and gencode-*. Although we won't be able to check code-* scripts.

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:41 +00:00

make everything pass shellcheck

Created by: darko-poljak

To coordinate, after resolving https://github.com/ungleich/cdist/pull/708 I will create PR for another fixes I am preparing,…

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:40 +00:00

make everything pass shellcheck

Created by: darko-poljak

@asteven @thriqon @tom-ee @telmich Good news! If I am right, #712 and #713 should be the last PRs regarding this issue :)

ungleich-gitea commented on issue ungleich-public/cdist#150

2021-11-20 15:43:39 +00:00

make everything pass shellcheck

Created by: asteven

Nice work everyone. To be honest I expect some breakage. But we can just fix that along the way. I do think we should eat this dog food ourself for quite some time before…

ungleich-gitea commented on issue ungleich-public/cdist#148

2021-11-20 15:43:37 +00:00

explorer reuse between types

Created by: telmich

That is an interesting question! We so far have not had that much and thus not the need for a solution, however we implemented __files lately (maybe a year ago) and maybe we…

ungleich-gitea commented on issue ungleich-public/cdist#148

2021-11-20 15:43:35 +00:00

explorer reuse between types

Created by: antifob

Wonderful!

I implemented a small proof of concept in: d5c1a7cd77

ungleich-gitea commented on issue ungleich-public/cdist#148

2021-11-20 15:43:34 +00:00

explorer reuse between types

Created by: darko-poljak

@uqam-fob Please join ungleich's cdist chat channel: https://brandnewchat.ungleich.ch/ungleich/channels/cdist, a place for main cdist discussion.

ungleich-gitea commented on issue ungleich-public/cdist#148

2021-11-20 15:43:33 +00:00

explorer reuse between types

Created by: darko-poljak

@asteven @uqam-fob @telmich Perhaps this can be connected with this idea: https://github.com/ungleich/cdist/issues/512

ungleich-gitea commented on issue ungleich-public/cdist#148

2021-11-20 15:43:32 +00:00

explorer reuse between types

Created by: antifob

@darko-poljak No offense, but no thanks, I am getting a heavy (many, many seconds) response time trying to hit the page, plus I won't receive a confirmation.

Anyways, #512…

ungleich-gitea commented on issue ungleich-public/cdist#148

2021-11-20 15:43:30 +00:00

explorer reuse between types

closed

ungleich-gitea commented on issue ungleich-public/cdist#147

2021-11-20 15:43:29 +00:00

__ssh_authorized_keys overwrites existing keys

Created by: darko-poljak

@pcoder I will take a look soon.