• Joined on 2021-11-20
ungleich-gitea commented on issue ungleich-public/cdist#44 2021-11-20 15:30:37 +00:00
[Comparison][Discussion] __staged_file vs __download

changed the description

ungleich-gitea commented on issue ungleich-public/cdist#44 2021-11-20 15:30:36 +00:00
[Comparison][Discussion] __staged_file vs __download

@ander Can you compare those two types, since you have wroten download over the staged file type?

ungleich-gitea commented on issue ungleich-public/cdist#44 2021-11-20 15:30:35 +00:00
[Comparison][Discussion] __staged_file vs __download

at first I started to write __unpack and then __download just happened, because I didn't like the interface and solution of __staged_file.

and in long run I wanted __download to be bit…

ungleich-gitea commented on issue ungleich-public/cdist#44 2021-11-20 15:30:33 +00:00
[Comparison][Discussion] __staged_file vs __download

I've had a look at both types. The differences I could see:

ungleich-gitea commented on issue ungleich-public/cdist#44 2021-11-20 15:30:32 +00:00
[Comparison][Discussion] __staged_file vs __download

nice table 🙏

redownloads file from the source every time.

if you want to deploy same file to multiple hosts, then you should fly with $__files and __file. download caching and parallel…

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:31 +00:00
__acl: remove deprecated parameters

mentioned in merge request !899

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:29 +00:00
__acl: remove deprecated parameters

I'm continuing the discussion of !899 here, because it doesn't really fit there.

I don't know POSIX ACLs well, but I'm wondering if all previous use cases of the deprecated parameters could be…

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:28 +00:00
__acl: remove deprecated parameters

currently backwards compatibility does exactly that - maps deprecated parameters to --entry and also emits warning.

I think we have waited long enough.

I'll deal with this after dance around…

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:27 +00:00
__acl: remove deprecated parameters

This question came up when I suggested "cdist-museum" for old and deleted types in cdist core. @poljakowski raised the question if this should also apply to the deprecated parameters in…

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:25 +00:00
__acl: remove deprecated parameters

@ander Is it feasible that you do this in a week or two?

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:24 +00:00
__acl: remove deprecated parameters

sigh, time flies. sorry for taking this long, I have no excuse but laziness 👹

but take a look at !933

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:23 +00:00
__acl: remove deprecated parameters

mentioned in merge request !933

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:21 +00:00
__acl: remove deprecated parameters

closed via merge request !933

ungleich-gitea commented on issue ungleich-public/cdist#43 2021-11-20 15:30:20 +00:00
__acl: remove deprecated parameters

mentioned in commit f96f23e970abd586fe222b296f1f010e52c364e5

ungleich-gitea commented on issue ungleich-public/cdist#42 2021-11-20 15:30:18 +00:00
__timezone should be singleton

yes

ungleich-gitea commented on issue ungleich-public/cdist#42 2021-11-20 15:30:17 +00:00
__timezone should be singleton

I think it was done probably because it's nicer to write __timezone Europe/Tallinn vs __timezone --timezone Europe/Tallinn.

maybe allow object_id if singleton? @poljakowski

ungleich-gitea commented on issue ungleich-public/cdist#42 2021-11-20 15:30:15 +00:00
__timezone should be singleton

Hm...didn't think about the object id. Singleton change which requires parameter would break existing configurations. We should probably go with deprecation and eventually change it to something like…

ungleich-gitea commented on issue ungleich-public/cdist#42 2021-11-20 15:30:14 +00:00
__timezone should be singleton

You are right, it should have been a singleton. I'm not sure what's the best path here for change, as we would need a second type if we want to give users the opportunity to modify their code without…

ungleich-gitea commented on issue ungleich-public/cdist#42 2021-11-20 15:30:13 +00:00
__timezone should be singleton

Maybe we should queue the change for an upcoming 7.0.0 release? IMO breaking API changes are okay for major releases.