From 44c80899fe2312a869cfef76a53faebc6e476e3c Mon Sep 17 00:00:00 2001
From: Nico Schottelius <nico@hydrogenium.schottelius.org>
Date: Wed, 17 Jan 2007 18:45:13 +0100
Subject: [PATCH] Cosmetic changase

---
 TODO        |  3 +++
 ccollect.sh | 12 ++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/TODO b/TODO
index cd404ab..a11dba9 100644
--- a/TODO
+++ b/TODO
@@ -8,7 +8,10 @@ Anhaengen von der -F / --filter Doku von Killerfox
 1.2. replace sed?
 compare timing:
    _echo () { echo "$name $msg" }
+and create
    _techo () { echo "$timestamp $name $msg" }
+perhaps create
+   _eecho () { _techo "ERROR $msg" }
 --------------------------------------------------------------------------------
 2. clonen von anderen existierenden backups?
 --------------------------------------------------------------------------------
diff --git a/ccollect.sh b/ccollect.sh
index f580d60..92d096f 100755
--- a/ccollect.sh
+++ b/ccollect.sh
@@ -330,7 +330,7 @@ while [ "$i" -lt "$no_sources" ]; do
    # destination _must_ be a directory
    #
    if [ ! -d "$c_dest" ]; then
-      echo "Destination $c_dest does not link to a directory. Skipping"
+      echo "Destination $c_dest neither links to nor is a directory. Skipping."
       exit 1
    fi
 
@@ -338,6 +338,8 @@ while [ "$i" -lt "$no_sources" ]; do
    # exclude list
    #
    if [ -f "$c_exclude" ]; then
+      # FIXME: check how quoting at the end looks like
+      # perhaps our source contains spaces!
       EXCLUDE="--exclude-from=$c_exclude"
    fi
 
@@ -449,6 +451,11 @@ while [ "$i" -lt "$no_sources" ]; do
    echo "$($DDATE) Transferring files..."
 
    ouropts="-a --delete --numeric-ids --relative --delete-excluded"
+
+   #
+   # FIXME: check, whether this is broken with spaces...
+   # most likely it should be broken...
+   #
    useropts="$VERBOSE $EXCLUDE $SUMMARY $RSYNC_EXTRA"
 
    # Clone from previous backup, if existing
@@ -458,9 +465,10 @@ while [ "$i" -lt "$no_sources" ]; do
       # This directory MUST be absolute, because rsync does chdir()
       # before beginning backup!
       #
+
       abs_last_dir="$(cd "$last_dir" && pwd -P)"
       if [ -z "$abs_last_dir" ]; then
-         echo "Changing to the last backup directory failed. I skip this backup."
+         echo "Changing to the last backup directory failed. Skipping."
          exit 1
       fi