From 919707d6f9baaa71df2caef817c77e2a7c90ec0f Mon Sep 17 00:00:00 2001 From: Jason Staten Date: Mon, 28 Jan 2013 10:06:04 -0700 Subject: [PATCH] Initialize variables to empty string Set mode, group, etc. to an empty string to ensure that no external environment variables can leak in. --- cdist/conf/type/__directory/gencode-remote | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cdist/conf/type/__directory/gencode-remote b/cdist/conf/type/__directory/gencode-remote index 154a46b5..f46a5967 100755 --- a/cdist/conf/type/__directory/gencode-remote +++ b/cdist/conf/type/__directory/gencode-remote @@ -27,10 +27,15 @@ mode_is="$(cat "$__object/explorer/mode")" state_should="present" [ -f "$__object/parameter/state" ] && state_should="$(cat "$__object/parameter/state")" +mode="" [ -f "$__object/parameter/mode" ] && mode="$(cat "$__object/parameter/mode")" +owner="" [ -f "$__object/parameter/owner" ] && owner="$(cat "$__object/parameter/owner")" +group="" [ -f "$__object/parameter/group" ] && group="$(cat "$__object/parameter/group")" +mkdiropt="" [ -f "$__object/parameter/parents" ] && mkdiropt="-p" +recursive="" [ -f "$__object/parameter/recursive" ] && recursive="-R" case "$state_should" in