From f03a0e586e3d867d65244b586fee6516c8854a6c Mon Sep 17 00:00:00 2001
From: Kamila Souckova <kamila@ksp.sk>
Date: Sun, 11 Mar 2018 11:40:47 +0100
Subject: [PATCH] __prometheus_{server,alertmanager}: restart when cli
 parameters change

---
 cdist/conf/type/__prometheus_alertmanager/manifest | 8 ++++++--
 cdist/conf/type/__prometheus_server/manifest       | 4 +++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/cdist/conf/type/__prometheus_alertmanager/manifest b/cdist/conf/type/__prometheus_alertmanager/manifest
index 87546f47..be50b71e 100755
--- a/cdist/conf/type/__prometheus_alertmanager/manifest
+++ b/cdist/conf/type/__prometheus_alertmanager/manifest
@@ -42,14 +42,18 @@ require="$require $require_pkg" __directory "$storage_path" --owner prometheus -
 
 # TODO this is a bug in the init script, patching it like this is awful and it should be reported
 require="$require $require_pkg" \
-__key_value alertmanager_fix_init_script --file /etc/init.d/prometheus-alertmanager --key="NAME" --value="prometheus-alertmanager" --delimiter "="
+__key_value alertmanager_fix_init_script --file /etc/init.d/prometheus-alertmanager \
+	--key "NAME" --value "prometheus-alertmanager" --delimiter "=" \
+	--onchange "service prometheus-alertmanager restart"
 
 ##### CONFIGURE #############################################################
 
 FLAGS="--storage.path $storage_path --data.retention $(($retention_days*24))h --web.listen-address [::]:9093"
 
 require="$require $require_pkg" \
-__key_value alertmanager_args --file /etc/default/prometheus-alertmanager --key="ARGS" --value="\"$FLAGS\"" --delimiter "="
+__key_value alertmanager_args --file /etc/default/prometheus-alertmanager \
+	--key "ARGS" --value "\"$FLAGS\"" --delimiter "=" \
+	--onchange "service prometheus-alertmanager restart"
 
 require="$require __directory/$storage_path $require_pkg" \
 __config_file $CONF \
diff --git a/cdist/conf/type/__prometheus_server/manifest b/cdist/conf/type/__prometheus_server/manifest
index a7ba7884..84ba53cf 100755
--- a/cdist/conf/type/__prometheus_server/manifest
+++ b/cdist/conf/type/__prometheus_server/manifest
@@ -49,7 +49,9 @@ FLAGS="--storage.tsdb.path $storage_path --storage.tsdb.retention $(($retention_
 
 # TODO it would be neat to restart prometheus on change -- __key_value really should have an --onchange parameter
 require="$require $require_pkg" \
-__key_value prometheus_args --file /etc/default/prometheus --key "ARGS" --value "\"$FLAGS\"" --delimiter "="
+__key_value prometheus_args --file /etc/default/prometheus \
+	--key "ARGS" --value "\"$FLAGS\"" --delimiter "=" \
+	--onchange "service prometheus restart"
 
 require="$require __directory/$storage_path $require_pkg" \
 __config_file $CONF \