From f143a70463e0740937370faa9492daf5cba9a2fd Mon Sep 17 00:00:00 2001
From: Stu Zhao <z12y12l12@gmail.com>
Date: Wed, 29 Aug 2018 00:30:27 -0700
Subject: [PATCH] Support pacman with --maxage parameter

---
 .../__package_update_index/explorer/currage   |  7 ++++
 .../__package_update_index/gencode-remote     | 35 ++++++++++---------
 .../conf/type/__package_update_index/man.rst  |  6 ++--
 docs/changelog                                |  1 +
 4 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/cdist/conf/type/__package_update_index/explorer/currage b/cdist/conf/type/__package_update_index/explorer/currage
index 45653f91..50474fb3 100644
--- a/cdist/conf/type/__package_update_index/explorer/currage
+++ b/cdist/conf/type/__package_update_index/explorer/currage
@@ -27,6 +27,13 @@ case "$type" in
             echo 0
         fi
         ;;
+    pacman)
+        if [ -d "/var/lib/pacman/sync" ]; then
+            echo $(($(date +"%s")-$(stat --format '%Y' /var/lib/pacman/sync)))
+        else
+            echo 0
+        fi
+        ;;
     *)  echo "Your specified type ($type) is currently not supported." >&2
         echo "Please contribute an implementation for it if you can." >&2
         ;;
diff --git a/cdist/conf/type/__package_update_index/gencode-remote b/cdist/conf/type/__package_update_index/gencode-remote
index 132a3daa..2cc76b81 100755
--- a/cdist/conf/type/__package_update_index/gencode-remote
+++ b/cdist/conf/type/__package_update_index/gencode-remote
@@ -22,32 +22,33 @@
 #
 
 type=$(cat "$__object/explorer/type")
+currage="$(cat "$__object/explorer/currage")"
 if [ -f "$__object/parameter/maxage" ]; then
     maxage="$(cat "$__object/parameter/maxage")"
-    currage="$(cat "$__object/explorer/currage")"
 fi
 
-if [ -n "$maxage" ] && [ "$type" != "apt" ]; then
-    echo "ERROR: \"--maxage\" only supported for \"apt\" pkg-manager." >&2
-    exit 1
+if [ -n "$maxage" ]; then
+    if [ "$type" != "apt" -a "$type" != "pacman" ]; then
+        echo "ERROR: \"--maxage\" only supported for \"apt\" or \"pacman\" pkg-manager." >&2
+        exit 1
+    elif [ $currage -lt $maxage ]; then
+        exit 0 # no need to update
+    fi
 fi
 
+
 case "$type" in
     yum) ;;
-    apt) if [ -n "$maxage" ]; then
-             ## check if we need to update:
-             if [ $currage -ge $maxage ]; then
-                echo "apt-get --quiet update"
-                echo "apt-cache updated (age was: $currage)" >> "$__messages_out"
-             fi
-         else
-                echo "apt-get --quiet update"
-                echo "apt-cache updated (age was: $currage)" >> "$__messages_out"
-         fi
-         ;;
-    pacman) echo "pacman --noprogressbar --sync --refresh" ;;
+    apt)
+        echo "apt-get --quiet update"
+        echo "apt-cache updated (age was: $currage)" >> "$__messages_out"
+        ;;
+    pacman)
+        echo "pacman --noprogressbar --sync --refresh"
+        echo "pacman package database synced (age was: $currage)" >> "$__messages_out"
+        ;;
     *)
-        echo "Don't know how to manage packages on: $os" >&2
+        echo "Don't know how to manage packages for type: $type" >&2
         exit 1
         ;;
 esac
diff --git a/cdist/conf/type/__package_update_index/man.rst b/cdist/conf/type/__package_update_index/man.rst
index b63af654..3cd787b9 100644
--- a/cdist/conf/type/__package_update_index/man.rst
+++ b/cdist/conf/type/__package_update_index/man.rst
@@ -28,8 +28,8 @@ type
     * pacman for Arch Linux
 
 maxage
-    Available for package manager apt, max time in seconds since last update.
-    Repo update is skipped if maxage is not reached yet.
+    Available for package manager apt and pacman, max time in seconds since
+    last update. Repo update is skipped if maxage is not reached yet.
 
 MESSAGES
 --------
@@ -51,6 +51,7 @@ EXAMPLES
 
     # Only update every hour:
     __package_update_index --maxage 3600 --type apt
+
     # same as above (on apt-type systems):
     __package_update_index --maxage 3600
 
@@ -58,6 +59,7 @@ AUTHORS
 -------
 | Ricardo Catalinas Jiménez <jimenezrick--@--gmail.com>
 | Thomas Eckert <tom--@--it-eckert.de>
+| Stu Zhao <z12y12l12--@--gmail.com>
 
 
 COPYING
diff --git a/docs/changelog b/docs/changelog
index 12bdb1e0..e989fb61 100644
--- a/docs/changelog
+++ b/docs/changelog
@@ -6,6 +6,7 @@ next:
 	* Type __systemd_unit: Fix minor issues and add masking unit files support (Adam Dej)
 	* Type __grafana_dashboard: Fix devuan ascii support (Dominique Roux)
 	* Type __package_update_index: Fix error when using OS not using apt (Stu Zhao)
+	* Type __package_update_index: Support --maxage for type pacman (Stu Zhao)
 
 4.10.1: 2018-06-21
 	* Type __letsencrypt_cert: Fix temp file location and removal (Darko Poljak)