From f9443532a19ce9fb179970498014d14e0fd92ed8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kamila=20Sou=C4=8Dkov=C3=A1?= <kamila@ksp.sk>
Date: Sun, 11 Mar 2018 18:01:38 +0100
Subject: [PATCH] __key_value: --onchange parameter added (#648)

---
 cdist/conf/type/__key_value/gencode-remote        | 15 ++++++++++++---
 cdist/conf/type/__key_value/man.rst               |  2 ++
 .../type/__key_value/parameter/default/onchange   |  0
 cdist/conf/type/__key_value/parameter/optional    |  1 +
 4 files changed, 15 insertions(+), 3 deletions(-)
 create mode 100644 cdist/conf/type/__key_value/parameter/default/onchange

diff --git a/cdist/conf/type/__key_value/gencode-remote b/cdist/conf/type/__key_value/gencode-remote
index 7a60f94b..13cc27c7 100755
--- a/cdist/conf/type/__key_value/gencode-remote
+++ b/cdist/conf/type/__key_value/gencode-remote
@@ -23,13 +23,14 @@
 
 state_should="$(cat "$__object/parameter/state")"
 state_is="$(cat "$__object/explorer/state")"
+fire_onchange=''
 
 if [  "$state_is" = "$state_should" ]; then
     exit 0
 fi
 
 # here we check only if the states are valid,
-# emmit messages and 
+# emit messages and
 # let awk do the work ...
 case "$state_should" in
     absent)
@@ -39,6 +40,7 @@ case "$state_should" in
             ;;
             wrongformat|wrongvalue|present)
                 echo "remove" >> "$__messages_out"
+                fire_onchange=1
             ;;
             *)
                 echo "Unknown explorer state: $state_is" >&2
@@ -50,12 +52,15 @@ case "$state_should" in
         case "$state_is" in
             nosuchfile)
                 echo "create" >> "$__messages_out"
+                fire_onchange=1
             ;;
             absent)
                 echo "insert" >> "$__messages_out"
+                fire_onchange=1
             ;;
             wrongformated|wrongvalue)
                 echo "change" >> "$__messages_out"
+                fire_onchange=1
             ;;
             present)
                 # nothing to do
@@ -67,9 +72,13 @@ case "$state_should" in
         esac
     ;;
     *)
-       echo "Unknown state: $state_should" >&2
-       exit 1
+        echo "Unknown state: $state_should" >&2
+        exit 1
     ;;
 esac
 
 cat "$__type/files/remote_script.sh"
+
+if [ -n "$fire_onchange" ]; then
+    cat "$__object/parameter/onchange"
+fi
diff --git a/cdist/conf/type/__key_value/man.rst b/cdist/conf/type/__key_value/man.rst
index f069d989..34e4aab2 100644
--- a/cdist/conf/type/__key_value/man.rst
+++ b/cdist/conf/type/__key_value/man.rst
@@ -34,6 +34,8 @@ comment
     but only if the key or value must be changed.
     You need to ensure yourself that the line is prefixed with the correct
     comment sign. (for example # or ; or wathever ..)
+onchange
+   The code to run if the key or value changes (i.e. is inserted, removed or replaced).
 
 
 BOOLEAN PARAMETERS
diff --git a/cdist/conf/type/__key_value/parameter/default/onchange b/cdist/conf/type/__key_value/parameter/default/onchange
new file mode 100644
index 00000000..e69de29b
diff --git a/cdist/conf/type/__key_value/parameter/optional b/cdist/conf/type/__key_value/parameter/optional
index 666be2ae..d4b8cac0 100644
--- a/cdist/conf/type/__key_value/parameter/optional
+++ b/cdist/conf/type/__key_value/parameter/optional
@@ -2,3 +2,4 @@ key
 value
 state
 comment
+onchange