Commit Graph

120 Commits

Author SHA1 Message Date
Darko Poljak 4c2d273f07 Unify string formatting
Use one way of string formatting: replace old `%` style with new `str.format`.

Resolve #855.
2021-03-31 08:19:34 +02:00
Darko Poljak f984a918b9 Fix log message string formatting
Use logging message format with args, instead of direct `%` or `str.format`.

Resolve #855.
2021-03-31 08:19:28 +02:00
Dennis Camera ce07021580 Do not subclass object 2020-06-21 16:53:47 +02:00
evilham ea3bd14d8b [logging] Mute warning on return_output=True when running scripts.
This fixes #806 which contains more information about the issue.

The TL;DR: this warning is not being useful and hinders debugging types because
it creates an innecessary line for each explorer.

An alternative proposal was #807 but was abandoned in favour of just dropping
the warning.
2020-04-28 14:54:51 +02:00
Darko Poljak 704e78322e Use OrderedDict to guarantee order
Note:
> Changed in version 3.7: Dictionary order is guaranteed to be
> insertion order. This behavior was an implementation detail of
> CPython from 3.6.
2020-04-11 20:26:20 +02:00
Steven Armstrong e19c1bb1e0 remove duplicates from conf dirs while preserving order
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2020-04-10 21:50:39 +02:00
Darko Poljak 3f133dbc17 Info command: support tilde expansion 2020-01-11 15:26:46 +01:00
Darko Poljak e4596593c0 Add cdist info command 2020-01-04 12:50:12 +01:00
Darko Poljak 279aada5db Fix broken quiet mode
Resolves #754
2019-04-12 09:13:25 +02:00
Darko Poljak 8c03518962 Fix spelling. 2018-10-17 07:09:59 +02:00
dhivael c021cd15cd transfer all files of a directory at once
instead of calling the copy command once per file in a directory (eg a
type explorer dir), call the copy command only once with all files of
the directory.

batch copy saves 20% of dry-run time on my test manifest in sequential
mode, and 15% in parallel mode.
2018-09-22 17:35:32 +02:00
Darko Poljak f09765a03a Improve error reporting. 2018-04-17 20:06:20 +02:00
Darko Poljak a993e0f5a9
Support disabling saving output streams 2018-02-07 18:12:15 +01:00
Darko Poljak 9703e0f08e Save output streams.
Implementation is 99% based on Steven's initial implementation.
2018-01-09 09:31:40 +01:00
Ander Punnar 8b78001c9e fix running scripts with execute bit (#583) 2017-09-29 14:44:44 +02:00
Darko Poljak 966bf30bee Fix \n thing. 2017-09-20 21:53:05 +02:00
Darko Poljak ea58cbd171 Better format command error output. 2017-09-20 21:19:19 +02:00
Darko Poljak 764ea49904 Log more data. 2017-09-17 20:30:07 +02:00
Darko Poljak 1ae5b1732e Fix missing dirs cleanup. 2017-09-10 23:08:21 +02:00
Darko Poljak cb38354df3 Run cleanup commands in quiet mode for DEBUG, TRACE. 2017-09-07 12:10:17 +02:00
Darko Poljak 136f2ecd87 Add helpers for cdist config/install integration. (#551)
Implement simple integration API.
2017-09-01 14:08:50 +02:00
Darko Poljak 4af3c0c6d5 Fix empty conf_dir configuration value. 2017-08-30 23:57:47 +02:00
Darko Poljak 2f10353156 Fix configuration bugs. 2017-08-30 23:11:10 +02:00
Darko Poljak bdee7273af Configfile (#559)
Add cdist configuration/config file support.
2017-08-30 23:02:17 +02:00
Darko Poljak f368539447 Some pylint cleaning. 2017-08-22 10:58:30 +02:00
Darko Poljak 68cb13881f Add archiving support. 2017-08-09 16:56:02 +02:00
Darko Poljak 1b0f560608 Add missing args to method call. 2017-07-27 09:51:23 +02:00
Darko Poljak 0a85d913cc Optimize dir transfer. 2017-07-27 09:49:06 +02:00
Darko Poljak 4a54d1420e Remove unwanted fixme 2017-07-24 19:12:43 +02:00
Darko Poljak e2a1519332 Merge inventory from beta branch. 2017-07-20 22:04:44 +02:00
Darko Poljak 126a1812a5 Fix parallel object prepare and run steps. Add nonparallel type marker. 2017-07-15 22:18:20 +02:00
Darko Poljak 015861e63b pep8 2017-07-04 23:49:43 +02:00
Darko Poljak a37d286d67 Suppress subprocess script output in quiet mode. 2017-07-04 23:49:43 +02:00
Darko Poljak a722f3c634 3rd iteration of logging cleanup. 2017-07-04 23:49:43 +02:00
Darko Poljak 248656b81f First iteration of logging cleanup. 2017-07-04 23:49:43 +02:00
Darko Poljak 2a9bd77550 Merge custom cache path pattern from beta branch. 2017-07-01 23:59:51 +02:00
Darko Poljak 9aa4465718 If script is executable then execute it, if not then assume it is a shell script. 2017-06-28 13:57:48 +02:00
Darko Poljak e375bd464d Merge remote-tracking branch 'ungleich/master' into the-good-the-bad-and-the-ugly 2017-06-12 13:15:00 +02:00
Steven Armstrong 448126f498 no need to log stdout at log level info
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2017-02-17 12:31:22 +01:00
Steven Armstrong 444790aed2 explicitly create cache dir
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2017-02-01 23:10:26 +01:00
Darko Poljak 2087f7a28a Un-suppress manifest stdout. 2017-01-20 15:22:25 +01:00
Darko Poljak e5a6599ccb Create mp_pool_run helper function for running in parallel. 2016-12-08 21:48:59 +01:00
Darko Poljak 609977b7ff ugly->bad 2016-12-04 20:27:42 +01:00
Darko Poljak e6fc74c081 ugly -> bad 2016-12-03 18:12:38 +01:00
Darko Poljak ca9dd7338a Support IPv6 in python code. 2016-11-02 13:35:48 +01:00
Darko Poljak b83e6993c1 Make comment better. 2016-08-21 17:10:24 +02:00
Darko Poljak dd1b95f596 Add target_host file with original host to cache since cache dir is hash. 2016-08-19 12:27:35 +02:00
Darko Poljak f858191976 Merge remote-tracking branch 'ungleich/master' into parallel-global-explorers-execution 2016-08-14 22:27:39 +02:00
Darko Poljak 51ffc0f037 log.info -> log.debug for debug messages 2016-08-14 21:30:09 +02:00
Darko Poljak 5f436f21b8 Transfer and run global explorers in parallel. 2016-08-12 21:14:56 +02:00