ungleich-public/cdist
ungleich-public
/
cdist
7
3
Fork 10
Code Issues 57 Pull Requests 12 Projects Releases Wiki Activity

Wrong version number reported #101

New Issue
Closed
opened 2021-11-20 13:23:55 +00:00 by ungleich-gitea · 16 comments
ungleich-gitea commented 2021-11-20 13:23:55 +00:00
Owner
Copy Link

Created by: oxr463

The command cdist -V, or cdist --version report the following version number on the latest release,

cdist v3.9.0-93-g1e2838bc2e

I also checked the version released on PyPI, and it says the same thing. In fact, re-running pip install cdist returns the following,

Requirement already satisfied: cdist in /usr/lib/python3.6/site-packages (v3.9.0-93-g1e2838bc2e)
*Created by: oxr463* The command `cdist -V`, or `cdist --version` report the following version number on the latest release, ```terminal cdist v3.9.0-93-g1e2838bc2e ``` I also checked the version released on PyPI, and it says the same thing. In fact, re-running `pip install cdist` returns the following, ```terminal Requirement already satisfied: cdist in /usr/lib/python3.6/site-packages (v3.9.0-93-g1e2838bc2e) ```
ungleich-gitea commented 2021-11-20 15:38:54 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 Release 4.10.11 raw source code that was uploaded by our build process should now have version.py included in the archive. If something is wrong, please report a new issue.

*Created by: darko-poljak* @oxr463 Release 4.10.11 raw source code that was uploaded by our build process should now have version.py included in the archive. If something is wrong, please report a new issue.
ungleich-gitea commented 2021-11-20 15:38:55 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

Thank you for reporting this and to make us make cdist better.

*Created by: darko-poljak* Thank you for reporting this and to make us make cdist better.
ungleich-gitea commented 2021-11-20 15:38:56 +00:00
Author
Owner
Copy Link

Created by: oxr463

Thank you for your help.

*Created by: oxr463* Thank you for your help.
ungleich-gitea commented 2021-11-20 15:38:57 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 It should be actual with the next release.

*Created by: darko-poljak* @oxr463 It should be actual with the next release.
ungleich-gitea commented 2021-11-20 15:38:59 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 We will add version.py into tar.gz we generate, sign and upload to github.
We cannot affect github generated Source code (zip) nor Source code (tar.gz).

*Created by: darko-poljak* @oxr463 We will add version.py into tar.gz we generate, sign and upload to github. We cannot affect github generated `Source code (zip)` nor `Source code (tar.gz)`.
ungleich-gitea commented 2021-11-20 15:39:00 +00:00
Author
Owner
Copy Link

Created by: oxr463

I can clone from git. Thanks for letting me know!

*Created by: oxr463* I can clone from git. Thanks for letting me know!
ungleich-gitea commented 2021-11-20 15:39:01 +00:00
Author
Owner
Copy Link

Created by: telmich

Alright.. the answer is VERY easy:

  • .tar.*, deb, pypi, apk, $package should contain version.py
  • git should not contain that

@oxr463 I have not worked w/ alpine packages yet, but can you git (shallow) clone in the build process? This would be the correct way from our side. The tars generated by github are not an official release from my point of view.

*Created by: telmich* Alright.. the answer is VERY easy: * .tar.*, deb, pypi, apk, $package should contain version.py * git should not contain that @oxr463 I have not worked w/ alpine packages yet, but can you git (shallow) clone in the build process? This would be the correct way from our side. The tars generated by github are *not* an official release from my point of view.
ungleich-gitea commented 2021-11-20 15:39:03 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 Well, if source is not git cloned then there is no git to generate version from.
pypi tar.gz has generated version.py included.
Raw source has no version.py.

@telmich What is the recommended way in this case?
Should we support version.py generation for raw source?

*Created by: darko-poljak* @oxr463 Well, if source is not git cloned then there is no git to generate version from. pypi tar.gz has generated version.py included. Raw source has no version.py. @telmich What is the recommended way in this case? Should we support version.py generation for raw source?
ungleich-gitea commented 2021-11-20 15:39:04 +00:00
Author
Owner
Copy Link

Created by: oxr463

Here is the latest results,

tar xf cdist-4.10.9.tar.gz
cd cdist-4.10.9
ls
bin  cdist  completions  configuration  docs  hacking  Makefile  MANIFEST.in  other  PKGBUILD.in  README  scripts  setup.py
make version
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
make: *** No rule to make target '.git/refs/heads/master', needed by 'version'.  Stop.
*Created by: oxr463* Here is the latest results, ```terminal tar xf cdist-4.10.9.tar.gz cd cdist-4.10.9 ls bin cdist completions configuration docs hacking Makefile MANIFEST.in other PKGBUILD.in README scripts setup.py make version fatal: not a git repository (or any of the parent directories): .git fatal: not a git repository (or any of the parent directories): .git fatal: not a git repository (or any of the parent directories): .git fatal: not a git repository (or any of the parent directories): .git make: *** No rule to make target '.git/refs/heads/master', needed by 'version'. Stop. ```
ungleich-gitea commented 2021-11-20 15:39:05 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 What is the final conclusion?

*Created by: darko-poljak* @oxr463 What is the final conclusion?
ungleich-gitea commented 2021-11-20 15:39:07 +00:00
Author
Owner
Copy Link

Created by: oxr463

Oops! I thought that only applied to the git version. Let me try again.

*Created by: oxr463* Oops! I thought that only applied to the git version. Let me try again.
ungleich-gitea commented 2021-11-20 15:39:08 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 I think you missed one step when doing it from source:

https://www.nico.schottelius.org/software/cdist/man/latest/cdist-install.html#from-git

To install cdist with distutils from cloned repository, first you have to create version.py:

make version

Then, as usual, you execute the following command:

python setup.py install

cdist does not come with pre-generated version.py.

*Created by: darko-poljak* @oxr463 I think you missed one step when doing it from source: https://www.nico.schottelius.org/software/cdist/man/latest/cdist-install.html#from-git ``` To install cdist with distutils from cloned repository, first you have to create version.py: make version Then, as usual, you execute the following command: python setup.py install ``` cdist does not come with pre-generated version.py.
ungleich-gitea commented 2021-11-20 15:39:09 +00:00
Author
Owner
Copy Link

Created by: oxr463

Testing again from Gentoo this time,

cdist -V
cdist

No version number at all?

*Created by: oxr463* Testing again from Gentoo this time, ```terminal cdist -V cdist ``` No version number at all?
ungleich-gitea commented 2021-11-20 15:39:11 +00:00
Author
Owner
Copy Link

Created by: oxr463

I downloaded the tar.gz, unpacked it, then ran python3 setup.py build install.

Here is the APKBUILD for Alpine Linux, https://git.alpinelinux.org/aports/plain/testing/cdist/APKBUILD

*Created by: oxr463* I downloaded the tar.gz, unpacked it, then ran `python3 setup.py build install`. Here is the APKBUILD for Alpine Linux, https://git.alpinelinux.org/aports/plain/testing/cdist/APKBUILD
ungleich-gitea commented 2021-11-20 15:39:12 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

The command cdist -V, or cdist --version report the following version number on the latest release

@oxr463 How do you install the latest release?

*Created by: darko-poljak* ``` The command cdist -V, or cdist --version report the following version number on the latest release ``` @oxr463 How do you `install` the latest release?
ungleich-gitea commented 2021-11-20 15:39:13 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@oxr463 I don't get it.

# pip3 install cdist
Collecting cdist
  Downloading https://files.pythonhosted.org/packages/e9/4f/75f6f39b90b58c00540ab7d1099111a4fst-4.10.9.tar.gz (709kB)
    100% |████████████████████████████████| 716kB 2.6MB/s 
Building wheels for collected packages: cdist
  Running setup.py bdist_wheel for cdist ... done
  Stored in directory: /root/.cache/pip/wheels/74/0a/35/5c559751e4b254f842180fbc523b25fd6e1d8
Successfully built cdist
Installing collected packages: cdist
Successfully installed cdist-4.10.9
You are using pip version 18.1, however version 19.0.3 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
# cdist -V
cdist 4.10.9
*Created by: darko-poljak* @oxr463 I don't get it. ``` # pip3 install cdist Collecting cdist Downloading https://files.pythonhosted.org/packages/e9/4f/75f6f39b90b58c00540ab7d1099111a4fst-4.10.9.tar.gz (709kB) 100% |████████████████████████████████| 716kB 2.6MB/s Building wheels for collected packages: cdist Running setup.py bdist_wheel for cdist ... done Stored in directory: /root/.cache/pip/wheels/74/0a/35/5c559751e4b254f842180fbc523b25fd6e1d8 Successfully built cdist Installing collected packages: cdist Successfully installed cdist-4.10.9 You are using pip version 18.1, however version 19.0.3 is available. You should consider upgrading via the 'pip install --upgrade pip' command. # cdist -V cdist 4.10.9 ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
7.0
6.9
py3.10
ander/__package_apt_update_index
haproxy-dualstack
ander/__sed
beta
ander/os_version_debian_sid
evilham-compatibility-fixes
ander/__rsync
__snakeoil_cert
ander/update_readme
__download_improvements
feature/onchange
cleanup/string-formatting
feature/type-relationship-graph
cleanup/ssh-auth-keys-types
__letsencrypt_cert-fix-hooks
bugfix/preos-debug
bugfix/in-script-import
6.8
bugfix/sphinx-docs-build
6.7
cherry-pick-2f433a14
bugfix/make-code-consistent
6.6
regain-py3.2-support
6.5
bugfix/multiple-log-lines
matterbridge
coturn
alpinefix
matrix
new-type/network-interface
feature/process
6.4
feature/info-command
feature/libexec
6.3
preos-plugins-dir-opt
gitlab-ci
6.2
order-dep-fix
6.1
6.0
build/support-pip-from-git
feature/shell-lib
5.1
feature/support-type-deprecation
5.0
feature/python-types
4.11
4.10
shellcheck
4.9
4.8
freebsd-improvements
new-prometheus
key_value-onchange
feature/output_streams
AnotherKamila-patch-1
__letsencrypt_cert-fixes
letsencrypt-cron-fix
4.7
newtype-__letsencrypt_cert
os_explorer_devuan_fix
prometheus-exporter-fixes
daemontools-for-fbsd
type-prometheus-exporter-from-master
prometheus-more-fixes
4.6
4.5
fix-j
steven-backport
4.4
prometheus-fixes
grafana_dashboard
prometheus
daemontools
consul_improvements
feature/trigger
4.3
4.0-pre-not-stable
4.2
4.1
4.0
feature_install_and_preos
3.1
no-dot-cdist
random_dot_cdist
feature_yum_url
feature_files_export
3.0
2.3
2.2
2.1
ssh_callback
2.0
archive_shell_function_approach
1.7
1.6
1.5
1.4
1.3
1.2
1.1
1.0
7.0.0
6.9.8
6.9.7
6.9.6
6.9.5
6.9.4
6.9.3
6.9.2
6.9.1
6.9.0
6.8.0
6.7.0
6.6.0
6.5.6
6.5.5
6.5.4
6.5.3
6.5.2
6.5.1
6.5.0
6.4.0
6.3.0
6.2.0
6.1.1
6.1.0
6.0.4
6.0.3
6.0.2
6.0.1
6.0.0
5.1.3
5.1.2
5.1.1
5.1.0
5.0.2
5.0.1
5.0.0
4.11.1
4.11.0
4.10.11
4.10.10
4.10.9
4.10.8
4.10.7
4.10.6
4.10.5
4.10.4
4.10.3
4.10.2
4.10.1
4.10.0
4.9.1
4.9.0
4.8.4
4.8.3
4.8.2
4.8.1
4.8.0
4.7.3
4.7.2
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.4
4.4.3
4.4.2
4.4.1
4.4.0
4.3.2
4.3.1
4.3.0
4.2.2
4.2.1
4.2.0
4.1.0
4.0.0
3.1.13
tn1
3.1.12
3.1.11
3.1.10
3.1.9
3.1.8
3.1.7
3.1.6
4.0.0pre3
3.1.5
3.1.4
3.1.3
3.1.2
3.1.1
3.1.0
4.0.0pre2
3.0.9
3.0.8
3.0.7
3.0.6
3.0.5
3.0.4
3.0.3
4.0.0pre1
3.0.2
3.0.1
3.0.0
2.3.7
2.3.6
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.2.0
2.1.2
2.1.1
2.1.0
2.1.0pre8
2.1.0pre7
2.1.0pre6
2.0.15
2.1.0pre5
2.1.0pre4
2.1.0pre3
2.1.0pre2
2.1.0pre1
2.0.14
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.9
0.9.8
0.9.7
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
0.8
0.7
0.6
0.5
0.4
0.3
0.2
0.1
Labels
Clear labels   
bugfix

   
cleanup

   
discussion

   
documentation

   
doing

   
done

   
feature

   
improvement

   
packaging

   
Stale

   
testing

   
TODO
No Label
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#101
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?