non-portable shell code in type manifests/gencodes #155

New Issue

ungleich-gitea · 2021-11-20T15:20:22Z

ungleich-gitea commented

2021-11-20 15:20:22 +00:00

Created by: asteven

Running in a busybox environment it looks like I will be hitting few of these.
Using this ticket to group them and then submit a pull request later on.

e.g. __staged_file/gencode-remote uses mktemp --tmpdir, should be mktemp -p instead

*Created by: asteven* Running in a busybox environment it looks like I will be hitting few of these. Using this ticket to group them and then submit a pull request later on. e.g. __staged_file/gencode-remote uses mktemp --tmpdir, should be mktemp -p instead

ungleich-gitea closed this issue

2021-11-20 15:20:23 +00:00

ungleich-gitea commented

2021-11-20 15:44:40 +00:00

Created by: darko-poljak

This will be handled in https://github.com/ungleich/cdist/issues/540, so I am closing this one.

*Created by: darko-poljak* This will be handled in https://github.com/ungleich/cdist/issues/540, so I am closing this one.

ungleich-gitea commented

2021-11-20 15:44:42 +00:00

Created by: darko-poljak

Here is some POSIX related output form shellcheck

In ./__package_pkgng_freebsd/gencode-remote line 55:
   local _cmd=""
   ^-- SC2039: In POSIX sh, 'local' is undefined.

In ./__group/gencode-remote line 33:
      gid) echo "-g";;
                ^-- SC2039: In POSIX sh, echo flags are undefined.


In ./__group/gencode-remote line 34:
      password) echo "-p";;
                     ^-- SC2039: In POSIX sh, echo flags are undefined.


In ./__group/gencode-remote line 35:
      system) echo "-r";;
                   ^-- SC2039: In POSIX sh, echo flags are undefined.

In ./__install_partition_msdos_apply/gencode-remote line 32:
   local size=$1
   ^-- SC2039: In POSIX sh, 'local' is undefined.


In ./__install_partition_msdos_apply/gencode-remote line 33:
   local available_size="$2"
   ^-- SC2039: In POSIX sh, 'local' is undefined.


In ./__install_partition_msdos_apply/gencode-remote line 35:
   local number_suffix="$(echo ${size} | sed -e 's:\.[0-9]\+::' -e 's:\([0-9]\+\)\([KkMmGg%]\)[Bb]\?:\1|\2:')"
   ^-- SC2039: In POSIX sh, 'local' is undefined.

*Created by: darko-poljak* Here is some POSIX related output form `shellcheck` ``` In ./__package_pkgng_freebsd/gencode-remote line 55: local _cmd="" ^-- SC2039: In POSIX sh, 'local' is undefined. In ./__group/gencode-remote line 33: gid) echo "-g";; ^-- SC2039: In POSIX sh, echo flags are undefined. In ./__group/gencode-remote line 34: password) echo "-p";; ^-- SC2039: In POSIX sh, echo flags are undefined. In ./__group/gencode-remote line 35: system) echo "-r";; ^-- SC2039: In POSIX sh, echo flags are undefined. In ./__install_partition_msdos_apply/gencode-remote line 32: local size=$1 ^-- SC2039: In POSIX sh, 'local' is undefined. In ./__install_partition_msdos_apply/gencode-remote line 33: local available_size="$2" ^-- SC2039: In POSIX sh, 'local' is undefined. In ./__install_partition_msdos_apply/gencode-remote line 35: local number_suffix="$(echo ${size} | sed -e 's:\.[0-9]\+::' -e 's:$[0-9]\+$$[KkMmGg%]$[Bb]\?:\1|\2:')" ^-- SC2039: In POSIX sh, 'local' is undefined. ```

Sign in to join this conversation.