ungleich-public/cdist
ungleich-public
/
cdist
7
3
Fork 11
Code Issues 57 Pull Requests 15 Projects Releases Wiki Activity

'__target_fqdn': self.target_host[2], IndexError: string index out of range #160

New Issue
Closed
opened 2021-11-20 15:20:28 +00:00 by ungleich-gitea · 3 comments
ungleich-gitea commented 2021-11-20 15:20:28 +00:00
Owner
Copy Link

Created by: 4nd3r

sorry about issue subject, couldn't figure out better title :>

i was testing @darko-poljak's inventory system.

this happened:

# cdist config -v -p -b -A
--8<-- snip --8<--
INFO: cdist: Total processing time for XX host(s): 13.602720975875854
ERROR: cdist: Failed to configure the following hosts: host1 host2 host3

nothing special about failed hosts - one debian wheezy, 2 jessies.
base config is identical to others. at least it should be :>

debug run:

# cdist config -d host1
DEBUG: cdist: Namespace(all_tagged_hosts=False, beta=False, command='config', conf_dir=None, debug=True, dry_run=False, func=<bound method type.commandline of <class 'cdist.config.Config'>>, has_all_tags=False, host=['host1'], hostfile=None, inventory_dir=None, jobs=None, manifest=None, out_path=None, parallel=False, remote_copy=None, remote_exec=None, tag=False, verbose=False)
INFO: cdist: version 4.3.2-177-gcce175e
DEBUG: cdist: Base root path for target host "host1" is "/tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc"
DEBUG: host1: remote_exec for host "host1": ssh -o User=root -o ControlPath=/tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc/ssh-control-path  -o ControlPersist=125  -o ControlMaster=auto
DEBUG: host1: remote_copy for host "host1": scp -o User=root -o ControlPath=/tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc/ssh-control-path  -o ControlPersist=125  -o ControlMaster=auto
DEBUG: host1: derived host_name for host "host1": host1.domain.tld
DEBUG: host1: derived host_fqdn for host "host1": host1.domain.tld
DEBUG: host1: Local mkdir: /tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc/data
Traceback (most recent call last):
  File "/opt/cdist/bin/../scripts/cdist", line 387, in <module>
    commandline()
  File "/opt/cdist/bin/../scripts/cdist", line 357, in commandline
    args.func(args)
  File "/opt/cdist/cdist/config.py", line 208, in commandline
    args, parallel=False)
  File "/opt/cdist/cdist/config.py", line 300, in onehost
    c = cls(local, remote, dry_run=args.dry_run, jobs=args.jobs)
  File "/opt/cdist/cdist/config.py", line 88, in __init__
    self.code = core.Code(self.local.target_host, self.local, self.remote)
  File "/opt/cdist/cdist/core/code.py", line 111, in __init__
    '__target_fqdn': self.target_host[2],
IndexError: string index out of range

using fqdn works:

# cdist config -v host1.domain.tld
--8<-- snip --8<--
INFO: cdist: Total processing time for 1 host(s): 9.917510986328125

problem were introduced somewhere in between 4.2.2 (last good) and 4.3.0.

did bisecting and got this:

dbcc94ab659c861cc9af416073f235da22f21c8c is the first bad commit
commit dbcc94ab659c861cc9af416073f235da22f21c8c
Author: Darko Poljak <darko.poljak@gmail.com>
Date:   Wed Aug 10 23:56:56 2016 +0200

Add derived env vars for target hostname and fqdn.

:040000 040000 5118a900ce74e9df055c40e3b4d4dd06c01fe5e9 aa00282eccddb18ec4208a37027395a1ba7bb284 M      cdist
:040000 040000 c71e04009f10ab8e2e553abc62d1ea5d60be9f14 8b6770892a8fdc97f535c916cf8d9ec1c94d5cff M      docs
*Created by: 4nd3r* sorry about issue subject, couldn't figure out better title :> i was testing @darko-poljak's inventory system. this happened: ``` # cdist config -v -p -b -A --8<-- snip --8<-- INFO: cdist: Total processing time for XX host(s): 13.602720975875854 ERROR: cdist: Failed to configure the following hosts: host1 host2 host3 ``` nothing special about failed hosts - one debian wheezy, 2 jessies. base config is identical to others. at least it should be :> debug run: ``` # cdist config -d host1 DEBUG: cdist: Namespace(all_tagged_hosts=False, beta=False, command='config', conf_dir=None, debug=True, dry_run=False, func=<bound method type.commandline of <class 'cdist.config.Config'>>, has_all_tags=False, host=['host1'], hostfile=None, inventory_dir=None, jobs=None, manifest=None, out_path=None, parallel=False, remote_copy=None, remote_exec=None, tag=False, verbose=False) INFO: cdist: version 4.3.2-177-gcce175e DEBUG: cdist: Base root path for target host "host1" is "/tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc" DEBUG: host1: remote_exec for host "host1": ssh -o User=root -o ControlPath=/tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc/ssh-control-path -o ControlPersist=125 -o ControlMaster=auto DEBUG: host1: remote_copy for host "host1": scp -o User=root -o ControlPath=/tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc/ssh-control-path -o ControlPersist=125 -o ControlMaster=auto DEBUG: host1: derived host_name for host "host1": host1.domain.tld DEBUG: host1: derived host_fqdn for host "host1": host1.domain.tld DEBUG: host1: Local mkdir: /tmp/tmpue8we34z/d67f249b90615ca158b1258712c3a9fc/data Traceback (most recent call last): File "/opt/cdist/bin/../scripts/cdist", line 387, in <module> commandline() File "/opt/cdist/bin/../scripts/cdist", line 357, in commandline args.func(args) File "/opt/cdist/cdist/config.py", line 208, in commandline args, parallel=False) File "/opt/cdist/cdist/config.py", line 300, in onehost c = cls(local, remote, dry_run=args.dry_run, jobs=args.jobs) File "/opt/cdist/cdist/config.py", line 88, in __init__ self.code = core.Code(self.local.target_host, self.local, self.remote) File "/opt/cdist/cdist/core/code.py", line 111, in __init__ '__target_fqdn': self.target_host[2], IndexError: string index out of range ``` using fqdn works: ``` # cdist config -v host1.domain.tld --8<-- snip --8<-- INFO: cdist: Total processing time for 1 host(s): 9.917510986328125 ``` problem were introduced somewhere in between 4.2.2 (last good) and 4.3.0. did bisecting and got this: ``` dbcc94ab659c861cc9af416073f235da22f21c8c is the first bad commit commit dbcc94ab659c861cc9af416073f235da22f21c8c Author: Darko Poljak <darko.poljak@gmail.com> Date: Wed Aug 10 23:56:56 2016 +0200 Add derived env vars for target hostname and fqdn. :040000 040000 5118a900ce74e9df055c40e3b4d4dd06c01fe5e9 aa00282eccddb18ec4208a37027395a1ba7bb284 M cdist :040000 040000 c71e04009f10ab8e2e553abc62d1ea5d60be9f14 8b6770892a8fdc97f535c916cf8d9ec1c94d5cff M docs ```
ungleich-gitea added the
bugfix
 label 2021-11-20 15:20:28 +00:00
ungleich-gitea commented 2021-11-20 15:44:58 +00:00
Author
Owner
Copy Link

Created by: 4nd3r

@darko-poljak thanks, no more failed hosts! fixed and closing.

*Created by: 4nd3r* @darko-poljak thanks, no more failed hosts! fixed and closing.
ungleich-gitea commented 2021-11-20 15:44:59 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

@4nd3r I found the problem. It should be now fixed. I pushed the fix to 'inventory' branch. Please test it with the same params and hosts.

*Created by: darko-poljak* @4nd3r I found the problem. It should be now fixed. I pushed the fix to 'inventory' branch. Please test it with the same params and hosts.
ungleich-gitea commented 2021-11-20 15:45:01 +00:00
Author
Owner
Copy Link

Created by: darko-poljak

Can you also post debug output for the case it works? Thanks

*Created by: darko-poljak* Can you also post debug output for the case it works? Thanks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
7.0
6.9
py3.10
ander/__package_apt_update_index
haproxy-dualstack
ander/__sed
beta
ander/os_version_debian_sid
evilham-compatibility-fixes
ander/__rsync
__snakeoil_cert
ander/update_readme
__download_improvements
feature/onchange
cleanup/string-formatting
feature/type-relationship-graph
cleanup/ssh-auth-keys-types
__letsencrypt_cert-fix-hooks
bugfix/preos-debug
bugfix/in-script-import
6.8
bugfix/sphinx-docs-build
6.7
cherry-pick-2f433a14
bugfix/make-code-consistent
6.6
regain-py3.2-support
6.5
bugfix/multiple-log-lines
matterbridge
coturn
alpinefix
matrix
new-type/network-interface
feature/process
6.4
feature/info-command
feature/libexec
6.3
preos-plugins-dir-opt
gitlab-ci
6.2
order-dep-fix
6.1
6.0
build/support-pip-from-git
feature/shell-lib
5.1
feature/support-type-deprecation
5.0
feature/python-types
4.11
4.10
shellcheck
4.9
4.8
freebsd-improvements
new-prometheus
key_value-onchange
feature/output_streams
AnotherKamila-patch-1
__letsencrypt_cert-fixes
letsencrypt-cron-fix
4.7
newtype-__letsencrypt_cert
os_explorer_devuan_fix
prometheus-exporter-fixes
daemontools-for-fbsd
type-prometheus-exporter-from-master
prometheus-more-fixes
4.6
4.5
fix-j
steven-backport
4.4
prometheus-fixes
grafana_dashboard
prometheus
daemontools
consul_improvements
feature/trigger
4.3
4.0-pre-not-stable
4.2
4.1
4.0
feature_install_and_preos
3.1
no-dot-cdist
random_dot_cdist
feature_yum_url
feature_files_export
3.0
2.3
2.2
2.1
ssh_callback
2.0
archive_shell_function_approach
1.7
1.6
1.5
1.4
1.3
1.2
1.1
1.0
7.0.0
6.9.8
6.9.7
6.9.6
6.9.5
6.9.4
6.9.3
6.9.2
6.9.1
6.9.0
6.8.0
6.7.0
6.6.0
6.5.6
6.5.5
6.5.4
6.5.3
6.5.2
6.5.1
6.5.0
6.4.0
6.3.0
6.2.0
6.1.1
6.1.0
6.0.4
6.0.3
6.0.2
6.0.1
6.0.0
5.1.3
5.1.2
5.1.1
5.1.0
5.0.2
5.0.1
5.0.0
4.11.1
4.11.0
4.10.11
4.10.10
4.10.9
4.10.8
4.10.7
4.10.6
4.10.5
4.10.4
4.10.3
4.10.2
4.10.1
4.10.0
4.9.1
4.9.0
4.8.4
4.8.3
4.8.2
4.8.1
4.8.0
4.7.3
4.7.2
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.4
4.4.3
4.4.2
4.4.1
4.4.0
4.3.2
4.3.1
4.3.0
4.2.2
4.2.1
4.2.0
4.1.0
4.0.0
3.1.13
tn1
3.1.12
3.1.11
3.1.10
3.1.9
3.1.8
3.1.7
3.1.6
4.0.0pre3
3.1.5
3.1.4
3.1.3
3.1.2
3.1.1
3.1.0
4.0.0pre2
3.0.9
3.0.8
3.0.7
3.0.6
3.0.5
3.0.4
3.0.3
4.0.0pre1
3.0.2
3.0.1
3.0.0
2.3.7
2.3.6
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.2.0
2.1.2
2.1.1
2.1.0
2.1.0pre8
2.1.0pre7
2.1.0pre6
2.0.15
2.1.0pre5
2.1.0pre4
2.1.0pre3
2.1.0pre2
2.1.0pre1
2.0.14
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.9
0.9.8
0.9.7
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
0.8
0.7
0.6
0.5
0.4
0.3
0.2
0.1
Labels
Clear labels   
bugfix

   
cleanup

   
discussion

   
documentation

   
doing

   
done

   
feature

   
improvement

   
packaging

   
Stale

   
testing

   
TODO
No Label
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#160
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?