ungleich-public/cdist
ungleich-public
/
cdist
7
3
Fork 10
Code Issues 57 Pull Requests 12 Projects Releases Wiki Activity

cdist preos fails if parameter -l 3 is given #17

New Issue
Closed
opened 2021-11-20 11:24:49 +00:00 by ungleich-gitea · 5 comments
ungleich-gitea commented 2021-11-20 11:24:49 +00:00
Owner
Copy Link

Hi there,
it seems to me there is an issue with cdist preos.
If I run cdist preos debian ... -l 3 it fails with cdist: error: unrecognized arguments: -d.

The reason is in file code line 25, where -d is appended to cdist_params in conjunction with line 180 where cdist config is called with this parameter, but -d is not a valid parameter according to the manual (cdist config --help).

If I remove the -d the cdist config statements works without an error.

I've encountered this issue with cdist verison 6.7.0 and 6.9.0.

Proposed solution: Remove -d from line 25 in code

Hi there, \ it seems to me there is an issue with `cdist preos`.\ If I run `cdist preos debian ... -l 3` it fails with `cdist: error: unrecognized arguments: -d`. The reason is in file [code](cdist/preos/debootstrap/files/code) line 25, where `-d` is appended to `cdist_params` in conjunction with line 180 where `cdist config` is called with this parameter, but `-d` is not a valid parameter according to the manual (`cdist config --help`). If I remove the `-d` the `cdist config` statements works without an error. I've encountered this issue with cdist verison 6.7.0 and 6.9.0. Proposed solution: Remove `-d` from line 25 in [code](cdist/preos/debootstrap/files/code)
ungleich-gitea commented 2021-11-20 15:25:52 +00:00
Author
Owner
Copy Link

mentioned in commit cce470b556

mentioned in commit cce470b556ae9178e90eaa0d2761f6d4b21d6a0f
ungleich-gitea commented 2021-11-20 15:25:53 +00:00
Author
Owner
Copy Link

If tested commit c8195483 on branch bugfix/preos-debug. It seems to solve the problem.

If tested commit c8195483 on branch bugfix/preos-debug. It seems to solve the problem.
ungleich-gitea commented 2021-11-20 15:25:55 +00:00
Author
Owner
Copy Link

@toto Can you test https://code.ungleich.ch/ungleich-public/cdist/-/merge_requests/970?

@toto Can you test https://code.ungleich.ch/ungleich-public/cdist/-/merge_requests/970?
ungleich-gitea commented 2021-11-20 15:25:56 +00:00
Author
Owner
Copy Link

mentioned in merge request !970

mentioned in merge request !970
ungleich-gitea commented 2021-11-20 15:25:57 +00:00
Author
Owner
Copy Link

mentioned in commit c819548343

mentioned in commit c819548343ad7bb24d023f94a32575e1b2520328
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
7.0
6.9
py3.10
ander/__package_apt_update_index
haproxy-dualstack
ander/__sed
beta
ander/os_version_debian_sid
evilham-compatibility-fixes
ander/__rsync
__snakeoil_cert
ander/update_readme
__download_improvements
feature/onchange
cleanup/string-formatting
feature/type-relationship-graph
cleanup/ssh-auth-keys-types
__letsencrypt_cert-fix-hooks
bugfix/preos-debug
bugfix/in-script-import
6.8
bugfix/sphinx-docs-build
6.7
cherry-pick-2f433a14
bugfix/make-code-consistent
6.6
regain-py3.2-support
6.5
bugfix/multiple-log-lines
matterbridge
coturn
alpinefix
matrix
new-type/network-interface
feature/process
6.4
feature/info-command
feature/libexec
6.3
preos-plugins-dir-opt
gitlab-ci
6.2
order-dep-fix
6.1
6.0
build/support-pip-from-git
feature/shell-lib
5.1
feature/support-type-deprecation
5.0
feature/python-types
4.11
4.10
shellcheck
4.9
4.8
freebsd-improvements
new-prometheus
key_value-onchange
feature/output_streams
AnotherKamila-patch-1
__letsencrypt_cert-fixes
letsencrypt-cron-fix
4.7
newtype-__letsencrypt_cert
os_explorer_devuan_fix
prometheus-exporter-fixes
daemontools-for-fbsd
type-prometheus-exporter-from-master
prometheus-more-fixes
4.6
4.5
fix-j
steven-backport
4.4
prometheus-fixes
grafana_dashboard
prometheus
daemontools
consul_improvements
feature/trigger
4.3
4.0-pre-not-stable
4.2
4.1
4.0
feature_install_and_preos
3.1
no-dot-cdist
random_dot_cdist
feature_yum_url
feature_files_export
3.0
2.3
2.2
2.1
ssh_callback
2.0
archive_shell_function_approach
1.7
1.6
1.5
1.4
1.3
1.2
1.1
1.0
7.0.0
6.9.8
6.9.7
6.9.6
6.9.5
6.9.4
6.9.3
6.9.2
6.9.1
6.9.0
6.8.0
6.7.0
6.6.0
6.5.6
6.5.5
6.5.4
6.5.3
6.5.2
6.5.1
6.5.0
6.4.0
6.3.0
6.2.0
6.1.1
6.1.0
6.0.4
6.0.3
6.0.2
6.0.1
6.0.0
5.1.3
5.1.2
5.1.1
5.1.0
5.0.2
5.0.1
5.0.0
4.11.1
4.11.0
4.10.11
4.10.10
4.10.9
4.10.8
4.10.7
4.10.6
4.10.5
4.10.4
4.10.3
4.10.2
4.10.1
4.10.0
4.9.1
4.9.0
4.8.4
4.8.3
4.8.2
4.8.1
4.8.0
4.7.3
4.7.2
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.4
4.4.3
4.4.2
4.4.1
4.4.0
4.3.2
4.3.1
4.3.0
4.2.2
4.2.1
4.2.0
4.1.0
4.0.0
3.1.13
tn1
3.1.12
3.1.11
3.1.10
3.1.9
3.1.8
3.1.7
3.1.6
4.0.0pre3
3.1.5
3.1.4
3.1.3
3.1.2
3.1.1
3.1.0
4.0.0pre2
3.0.9
3.0.8
3.0.7
3.0.6
3.0.5
3.0.4
3.0.3
4.0.0pre1
3.0.2
3.0.1
3.0.0
2.3.7
2.3.6
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.2.0
2.1.2
2.1.1
2.1.0
2.1.0pre8
2.1.0pre7
2.1.0pre6
2.0.15
2.1.0pre5
2.1.0pre4
2.1.0pre3
2.1.0pre2
2.1.0pre1
2.0.14
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.9
0.9.8
0.9.7
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
0.8
0.7
0.6
0.5
0.4
0.3
0.2
0.1
Labels
Clear labels   
bugfix

   
cleanup

   
discussion

   
documentation

   
doing

   
done

   
feature

   
improvement

   
packaging

   
Stale

   
testing

   
TODO
No Label
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#17
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?