ungleich-public/cdist
ungleich-public
/
cdist
7
3
Fork 10
Code Issues 57 Pull Requests 12 Projects Releases Wiki Activity

__package_apt seems to interpret "Recommends:" as "Depends:" #197

New Issue
Closed
opened 2021-11-20 15:21:15 +00:00 by ungleich-gitea · 2 comments
ungleich-gitea commented 2021-11-20 15:21:15 +00:00
Owner
Copy Link

Created by: tpo

I have this here in a manifest:

__package inkscape --state present

# remove unnecessary cruft
for cruft in aspell aspell-en; do
    __package "$cruft" --state absent
done

Inkscape has the following dependencies:

$ dpkg -s inkscape | grep Recommends
Recommends: aspell, libwmf-bin, pstoedit, imagemagick, perlmagick

The result of the above manifest is, that (depending on execution order) cdist will first deinstall aspell and inkscape and then reinstall inkscape and aspell. Or the inverse: install both and the remove them both:

$ cdist config -v -c . vrtest
INFO: cdist: version 3.1.5-33-g9f5a228
INFO: vrtest: Running global explorers
INFO: vrtest: Running initial manifest /tmp/tmpixmti1/conf/manifest/init
INFO: vrtest: Running manifest and explorers for __foobar/
INFO: vrtest: Running manifest and explorers for __package/aspell
INFO: vrtest: Running manifest and explorers for __package/inkscape
INFO: vrtest: Running manifest and explorers for __package/aspell-en
INFO: vrtest: Running manifest and explorers for __package_apt/aspell
INFO: vrtest: Generating code for __package_apt/aspell
INFO: vrtest: Executing code for __package_apt/aspell
Reading package lists...
Building dependency tree...
Reading state information...
The following packages were automatically installed and are no longer required:
  fontconfig libatk1.0-0 libatk1.0-data libatkmm-1.6-1 libcairo2
  libcairomm-1.0-1 libcups2 libdatrie1 libgc1c2 libgdk-pixbuf2.0-0
  libgdk-pixbuf2.0-common libglibmm-2.4-1c2a libgnomevfs2-0 libgsl0ldbl
  libgtk2.0-0 libgtk2.0-common libgtkmm-2.4-1c2a libhunspell-1.3-0 liblcms1
  libmagick++5 libpango1.0-0 libpangomm-1.4-1 libpixman-1-0 libpoppler-glib8
  libpoppler19 libthai-data libthai0 libwpd-0.9-9 libwpg-0.2-2 libxcb-render0
  libxcb-shm0 libxcomposite1 libxcursor1 libxdamage1 libxft2 libxinerama1
  libxrandr2 libxrender1
Use 'apt-get autoremove' to remove them.
The following packages will be REMOVED:
  aspell aspell-en inkscape libenchant1c2a libgtkspell0
0 upgraded, 0 newly installed, 5 to remove and 2 not upgraded.
After this operation, 84.7 MB disk space will be freed.
(Reading database ... 36420 files and directories currently installed.)
Removing inkscape ...
Removing libgtkspell0 ...
Removing libenchant1c2a ...
Removing aspell-en ...
Removing aspell ...
Processing triggers for man-db ...
Processing triggers for hicolor-icon-theme ...
Processing triggers for mime-support ...
Processing triggers for dictionaries-common ...
INFO: vrtest: Running manifest and explorers for __package_apt/inkscape
INFO: vrtest: Generating code for __package_apt/inkscape
INFO: vrtest: Executing code for __package_apt/inkscape
Reading package lists...
Building dependency tree...
Reading state information...
The following extra packages will be installed:
  aspell aspell-en libenchant1c2a libgtkspell0
Suggested packages:
  aspell-doc spellutils dia dia-gnome ruby libgnomevfs2-extra libsvg-perl
  libxml-xql-perl python-numpy python-lxml python-uniconvertor skencil
  libenchant-voikko
Recommended packages:
  libwmf-bin pstoedit perlmagick enchant
The following NEW packages will be installed:
  aspell aspell-en inkscape libenchant1c2a libgtkspell0
0 upgraded, 5 newly installed, 0 to remove and 2 not upgraded.
Need to get 0 B/25.5 MB of archives.
After this operation, 84.7 MB of additional disk space will be used.
Selecting previously unselected package aspell.
(Reading database ... 35281 files and directories currently installed.)
Unpacking aspell (from .../aspell_0.60.7~20110707-1_amd64.deb) ...
Selecting previously unselected package aspell-en.
Unpacking aspell-en (from .../aspell-en_7.1-0-1_all.deb) ...
Selecting previously unselected package libenchant1c2a.
Unpacking libenchant1c2a (from .../libenchant1c2a_1.6.0-7_amd64.deb) ...
Selecting previously unselected package libgtkspell0.
Unpacking libgtkspell0 (from .../libgtkspell0_2.0.16-1_amd64.deb) ...
Selecting previously unselected package inkscape.
Unpacking inkscape (from .../inkscape_0.48.3.1-1.3_amd64.deb) ...
Processing triggers for man-db ...
Processing triggers for mime-support ...
Processing triggers for hicolor-icon-theme ...
Setting up aspell (0.60.7~20110707-1) ...
Processing triggers for dictionaries-common ...
aspell-autobuildhash: processing: en [en-common]
aspell-autobuildhash: processing: en [en-variant_0]
aspell-autobuildhash: processing: en [en-variant_1]
aspell-autobuildhash: processing: en [en-variant_2]
aspell-autobuildhash: processing: en [en-w_accents-only]
Setting up aspell-en (7.1-0-1) ...
Processing triggers for dictionaries-common ...
Setting up libenchant1c2a (1.6.0-7) ...
Setting up libgtkspell0 (2.0.16-1) ...
Setting up inkscape (0.48.3.1-1.3) ...
INFO: vrtest: Running manifest and explorers for __package_apt/aspell-en
INFO: vrtest: Generating code for __package_apt/aspell-en
INFO: vrtest: Executing code for __package_apt/aspell-en
Reading package lists...
Building dependency tree...
Reading state information...
The following packages were automatically installed and are no longer required:
  fontconfig libatk1.0-0 libatk1.0-data libatkmm-1.6-1 libcairo2
  libcairomm-1.0-1 libcups2 libdatrie1 libgc1c2 libgdk-pixbuf2.0-0
  libgdk-pixbuf2.0-common libglibmm-2.4-1c2a libgnomevfs2-0 libgsl0ldbl
  libgtk2.0-0 libgtk2.0-common libgtkmm-2.4-1c2a libhunspell-1.3-0 liblcms1
  libmagick++5 libpango1.0-0 libpangomm-1.4-1 libpixman-1-0 libpoppler-glib8
  libpoppler19 libthai-data libthai0 libwpd-0.9-9 libwpg-0.2-2 libxcb-render0
  libxcb-shm0 libxcomposite1 libxcursor1 libxdamage1 libxft2 libxinerama1
  libxrandr2 libxrender1
Use 'apt-get autoremove' to remove them.
The following packages will be REMOVED:
  aspell-en inkscape libenchant1c2a libgtkspell0
0 upgraded, 0 newly installed, 4 to remove and 2 not upgraded.
After this operation, 83.6 MB disk space will be freed.
(Reading database ... 36420 files and directories currently installed.)
Removing inkscape ...
Removing libgtkspell0 ...
Removing libenchant1c2a ...
Removing aspell-en ...
Processing triggers for man-db ...
Processing triggers for hicolor-icon-theme ...
Processing triggers for mime-support ...
Processing triggers for dictionaries-common ...
INFO: vrtest: Generating code for __package/aspell
INFO: vrtest: Generating code for __package/inkscape
INFO: vrtest: Generating code for __package/aspell-en
INFO: vrtest: Generating code for __foobar/
INFO: vrtest: Finished successful run in 82.12426018714905 seconds
INFO: cdist: Total processing time for 1 host(s): 82.12498021125793

My intuitive expectation of the above two declarations would however be, that aspell only would be removed and inscape would not be touched at all.

Of course the interpretation of "Recommends" is it is stronly advised to... unless you know what you're doing. But since cdist's target audience is devops I'd expect exactly this to be the case?

I suggest not to automatically deinstall a package if its "Recommends" dependecy gets deinstalled.

You can find the whole recipe attached.

*Created by: tpo* I have this here in a manifest: ``` __package inkscape --state present # remove unnecessary cruft for cruft in aspell aspell-en; do __package "$cruft" --state absent done ``` Inkscape has the following dependencies: ``` $ dpkg -s inkscape | grep Recommends Recommends: aspell, libwmf-bin, pstoedit, imagemagick, perlmagick ``` The result of the above manifest is, that (depending on execution order) cdist will first deinstall aspell **and** inkscape and then reinstall inkscape **and** aspell. Or the inverse: install both and the remove them both: ``` $ cdist config -v -c . vrtest INFO: cdist: version 3.1.5-33-g9f5a228 INFO: vrtest: Running global explorers INFO: vrtest: Running initial manifest /tmp/tmpixmti1/conf/manifest/init INFO: vrtest: Running manifest and explorers for __foobar/ INFO: vrtest: Running manifest and explorers for __package/aspell INFO: vrtest: Running manifest and explorers for __package/inkscape INFO: vrtest: Running manifest and explorers for __package/aspell-en INFO: vrtest: Running manifest and explorers for __package_apt/aspell INFO: vrtest: Generating code for __package_apt/aspell INFO: vrtest: Executing code for __package_apt/aspell Reading package lists... Building dependency tree... Reading state information... The following packages were automatically installed and are no longer required: fontconfig libatk1.0-0 libatk1.0-data libatkmm-1.6-1 libcairo2 libcairomm-1.0-1 libcups2 libdatrie1 libgc1c2 libgdk-pixbuf2.0-0 libgdk-pixbuf2.0-common libglibmm-2.4-1c2a libgnomevfs2-0 libgsl0ldbl libgtk2.0-0 libgtk2.0-common libgtkmm-2.4-1c2a libhunspell-1.3-0 liblcms1 libmagick++5 libpango1.0-0 libpangomm-1.4-1 libpixman-1-0 libpoppler-glib8 libpoppler19 libthai-data libthai0 libwpd-0.9-9 libwpg-0.2-2 libxcb-render0 libxcb-shm0 libxcomposite1 libxcursor1 libxdamage1 libxft2 libxinerama1 libxrandr2 libxrender1 Use 'apt-get autoremove' to remove them. The following packages will be REMOVED: aspell aspell-en inkscape libenchant1c2a libgtkspell0 0 upgraded, 0 newly installed, 5 to remove and 2 not upgraded. After this operation, 84.7 MB disk space will be freed. (Reading database ... 36420 files and directories currently installed.) Removing inkscape ... Removing libgtkspell0 ... Removing libenchant1c2a ... Removing aspell-en ... Removing aspell ... Processing triggers for man-db ... Processing triggers for hicolor-icon-theme ... Processing triggers for mime-support ... Processing triggers for dictionaries-common ... INFO: vrtest: Running manifest and explorers for __package_apt/inkscape INFO: vrtest: Generating code for __package_apt/inkscape INFO: vrtest: Executing code for __package_apt/inkscape Reading package lists... Building dependency tree... Reading state information... The following extra packages will be installed: aspell aspell-en libenchant1c2a libgtkspell0 Suggested packages: aspell-doc spellutils dia dia-gnome ruby libgnomevfs2-extra libsvg-perl libxml-xql-perl python-numpy python-lxml python-uniconvertor skencil libenchant-voikko Recommended packages: libwmf-bin pstoedit perlmagick enchant The following NEW packages will be installed: aspell aspell-en inkscape libenchant1c2a libgtkspell0 0 upgraded, 5 newly installed, 0 to remove and 2 not upgraded. Need to get 0 B/25.5 MB of archives. After this operation, 84.7 MB of additional disk space will be used. Selecting previously unselected package aspell. (Reading database ... 35281 files and directories currently installed.) Unpacking aspell (from .../aspell_0.60.7~20110707-1_amd64.deb) ... Selecting previously unselected package aspell-en. Unpacking aspell-en (from .../aspell-en_7.1-0-1_all.deb) ... Selecting previously unselected package libenchant1c2a. Unpacking libenchant1c2a (from .../libenchant1c2a_1.6.0-7_amd64.deb) ... Selecting previously unselected package libgtkspell0. Unpacking libgtkspell0 (from .../libgtkspell0_2.0.16-1_amd64.deb) ... Selecting previously unselected package inkscape. Unpacking inkscape (from .../inkscape_0.48.3.1-1.3_amd64.deb) ... Processing triggers for man-db ... Processing triggers for mime-support ... Processing triggers for hicolor-icon-theme ... Setting up aspell (0.60.7~20110707-1) ... Processing triggers for dictionaries-common ... aspell-autobuildhash: processing: en [en-common] aspell-autobuildhash: processing: en [en-variant_0] aspell-autobuildhash: processing: en [en-variant_1] aspell-autobuildhash: processing: en [en-variant_2] aspell-autobuildhash: processing: en [en-w_accents-only] Setting up aspell-en (7.1-0-1) ... Processing triggers for dictionaries-common ... Setting up libenchant1c2a (1.6.0-7) ... Setting up libgtkspell0 (2.0.16-1) ... Setting up inkscape (0.48.3.1-1.3) ... INFO: vrtest: Running manifest and explorers for __package_apt/aspell-en INFO: vrtest: Generating code for __package_apt/aspell-en INFO: vrtest: Executing code for __package_apt/aspell-en Reading package lists... Building dependency tree... Reading state information... The following packages were automatically installed and are no longer required: fontconfig libatk1.0-0 libatk1.0-data libatkmm-1.6-1 libcairo2 libcairomm-1.0-1 libcups2 libdatrie1 libgc1c2 libgdk-pixbuf2.0-0 libgdk-pixbuf2.0-common libglibmm-2.4-1c2a libgnomevfs2-0 libgsl0ldbl libgtk2.0-0 libgtk2.0-common libgtkmm-2.4-1c2a libhunspell-1.3-0 liblcms1 libmagick++5 libpango1.0-0 libpangomm-1.4-1 libpixman-1-0 libpoppler-glib8 libpoppler19 libthai-data libthai0 libwpd-0.9-9 libwpg-0.2-2 libxcb-render0 libxcb-shm0 libxcomposite1 libxcursor1 libxdamage1 libxft2 libxinerama1 libxrandr2 libxrender1 Use 'apt-get autoremove' to remove them. The following packages will be REMOVED: aspell-en inkscape libenchant1c2a libgtkspell0 0 upgraded, 0 newly installed, 4 to remove and 2 not upgraded. After this operation, 83.6 MB disk space will be freed. (Reading database ... 36420 files and directories currently installed.) Removing inkscape ... Removing libgtkspell0 ... Removing libenchant1c2a ... Removing aspell-en ... Processing triggers for man-db ... Processing triggers for hicolor-icon-theme ... Processing triggers for mime-support ... Processing triggers for dictionaries-common ... INFO: vrtest: Generating code for __package/aspell INFO: vrtest: Generating code for __package/inkscape INFO: vrtest: Generating code for __package/aspell-en INFO: vrtest: Generating code for __foobar/ INFO: vrtest: Finished successful run in 82.12426018714905 seconds INFO: cdist: Total processing time for 1 host(s): 82.12498021125793 ``` My intuitive expectation of the above two declarations would however be, that aspell **only** would be removed and inscape would not be touched _at all_. Of course the interpretation of "Recommends" is _it is stronly advised to... unless you know what you're doing_. But since cdist's target audience is devops I'd expect exactly this to be the case? I suggest not to automatically deinstall a package if its "Recommends" dependecy gets deinstalled. You can find the whole recipe attached.
ungleich-gitea added the
Stale
 label 2021-11-20 15:21:15 +00:00
ungleich-gitea commented 2021-11-20 15:47:24 +00:00
Author
Owner
Copy Link

closed

closed
ungleich-gitea commented 2021-11-20 15:47:25 +00:00
Author
Owner
Copy Link

Created by: tpo

Oops, it seems I can't attach random files to issues. So here we go in cleartext:

$ find
.
./manifest
./manifest/init
./type
./type/__foobar
./type/__foobar/manifest
./type/__foobar/singleton
$ cat manifest/init 
__foobar
$ cat type/__foobar/manifest 
__package inkscape --state present

# remove unnecessary cruft
for cruft in aspell aspell-en; do
    __package "$cruft" --state absent
done
$ cat type/__foobar/singleton 
$
*Created by: tpo* Oops, it seems I can't attach random files to issues. So here we go in cleartext: ``` $ find . ./manifest ./manifest/init ./type ./type/__foobar ./type/__foobar/manifest ./type/__foobar/singleton $ cat manifest/init __foobar $ cat type/__foobar/manifest __package inkscape --state present # remove unnecessary cruft for cruft in aspell aspell-en; do __package "$cruft" --state absent done $ cat type/__foobar/singleton $ ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
7.0
6.9
py3.10
ander/__package_apt_update_index
haproxy-dualstack
ander/__sed
beta
ander/os_version_debian_sid
evilham-compatibility-fixes
ander/__rsync
__snakeoil_cert
ander/update_readme
__download_improvements
feature/onchange
cleanup/string-formatting
feature/type-relationship-graph
cleanup/ssh-auth-keys-types
__letsencrypt_cert-fix-hooks
bugfix/preos-debug
bugfix/in-script-import
6.8
bugfix/sphinx-docs-build
6.7
cherry-pick-2f433a14
bugfix/make-code-consistent
6.6
regain-py3.2-support
6.5
bugfix/multiple-log-lines
matterbridge
coturn
alpinefix
matrix
new-type/network-interface
feature/process
6.4
feature/info-command
feature/libexec
6.3
preos-plugins-dir-opt
gitlab-ci
6.2
order-dep-fix
6.1
6.0
build/support-pip-from-git
feature/shell-lib
5.1
feature/support-type-deprecation
5.0
feature/python-types
4.11
4.10
shellcheck
4.9
4.8
freebsd-improvements
new-prometheus
key_value-onchange
feature/output_streams
AnotherKamila-patch-1
__letsencrypt_cert-fixes
letsencrypt-cron-fix
4.7
newtype-__letsencrypt_cert
os_explorer_devuan_fix
prometheus-exporter-fixes
daemontools-for-fbsd
type-prometheus-exporter-from-master
prometheus-more-fixes
4.6
4.5
fix-j
steven-backport
4.4
prometheus-fixes
grafana_dashboard
prometheus
daemontools
consul_improvements
feature/trigger
4.3
4.0-pre-not-stable
4.2
4.1
4.0
feature_install_and_preos
3.1
no-dot-cdist
random_dot_cdist
feature_yum_url
feature_files_export
3.0
2.3
2.2
2.1
ssh_callback
2.0
archive_shell_function_approach
1.7
1.6
1.5
1.4
1.3
1.2
1.1
1.0
7.0.0
6.9.8
6.9.7
6.9.6
6.9.5
6.9.4
6.9.3
6.9.2
6.9.1
6.9.0
6.8.0
6.7.0
6.6.0
6.5.6
6.5.5
6.5.4
6.5.3
6.5.2
6.5.1
6.5.0
6.4.0
6.3.0
6.2.0
6.1.1
6.1.0
6.0.4
6.0.3
6.0.2
6.0.1
6.0.0
5.1.3
5.1.2
5.1.1
5.1.0
5.0.2
5.0.1
5.0.0
4.11.1
4.11.0
4.10.11
4.10.10
4.10.9
4.10.8
4.10.7
4.10.6
4.10.5
4.10.4
4.10.3
4.10.2
4.10.1
4.10.0
4.9.1
4.9.0
4.8.4
4.8.3
4.8.2
4.8.1
4.8.0
4.7.3
4.7.2
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.4
4.4.3
4.4.2
4.4.1
4.4.0
4.3.2
4.3.1
4.3.0
4.2.2
4.2.1
4.2.0
4.1.0
4.0.0
3.1.13
tn1
3.1.12
3.1.11
3.1.10
3.1.9
3.1.8
3.1.7
3.1.6
4.0.0pre3
3.1.5
3.1.4
3.1.3
3.1.2
3.1.1
3.1.0
4.0.0pre2
3.0.9
3.0.8
3.0.7
3.0.6
3.0.5
3.0.4
3.0.3
4.0.0pre1
3.0.2
3.0.1
3.0.0
2.3.7
2.3.6
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.2.0
2.1.2
2.1.1
2.1.0
2.1.0pre8
2.1.0pre7
2.1.0pre6
2.0.15
2.1.0pre5
2.1.0pre4
2.1.0pre3
2.1.0pre2
2.1.0pre1
2.0.14
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.9
0.9.8
0.9.7
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
0.8
0.7
0.6
0.5
0.4
0.3
0.2
0.1
Labels
Clear labels   
bugfix

   
cleanup

   
discussion

   
documentation

   
doing

   
done

   
feature

   
improvement

   
packaging

   
Stale

   
testing

   
TODO
No Label
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#197
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?