ungleich-public/cdist
ungleich-public
/
cdist
7
3
Fork 10
Code Issues 57 Pull Requests 12 Projects Releases Wiki Activity

__locale_system writes to wrong file in Debian Sid #33

New Issue
Closed
opened 2021-11-20 11:24:59 +00:00 by ungleich-gitea · 12 comments
ungleich-gitea commented 2021-11-20 11:24:59 +00:00
Owner
Copy Link
$ echo '__locale_system LANG --value C.UTF-8' | cdist config -i - localhost -n
INFO: [297839]: localhost: Starting dry run
INFO: [297839]: localhost: Processing __key_value/etc/environment:LANG
INFO: [297839]: localhost: Finished dry run in 0.93 seconds

$ cdist-dump -E localhost
target host: localhost, host directory: ./421aa90e079fa326b6494f812ad13e79
==============================================================================
./explorer/runlevel:5
./explorer/lsb_id:Debian
./explorer/hostname:limukas
./explorer/lsb_description:Debian GNU/Linux bullseye/sid
./explorer/kernel_name:Linux
./explorer/os:debian
./explorer/init:systemd
./explorer/os_release:PRETTY_NAME="Debian GNU/Linux bullseye/sid"
./explorer/os_release:NAME="Debian GNU/Linux"
./explorer/os_release:ID=debian
./explorer/os_release:HOME_URL="https://www.debian.org/"
./explorer/os_release:SUPPORT_URL="https://www.debian.org/support"
./explorer/os_release:BUG_REPORT_URL="https://bugs.debian.org/"
./explorer/machine_type:physical
./explorer/os_version:bullseye/sid
./explorer/disks:sda sdb sdc
./explorer/lsb_codename:sid
./explorer/interfaces:br0
./explorer/interfaces:eth0
./explorer/interfaces:lo
./explorer/cpu_cores:2
./explorer/lsb_release:unstable
./explorer/memory:31860556
./explorer/cpu_sockets:1
./explorer/machine:x86_64

$ cat /etc/debian_version 
bullseye/sid

Type should write to /etc/default/locale as it did before 47e28fc441.

``` $ echo '__locale_system LANG --value C.UTF-8' | cdist config -i - localhost -n INFO: [297839]: localhost: Starting dry run INFO: [297839]: localhost: Processing __key_value/etc/environment:LANG INFO: [297839]: localhost: Finished dry run in 0.93 seconds $ cdist-dump -E localhost target host: localhost, host directory: ./421aa90e079fa326b6494f812ad13e79 ============================================================================== ./explorer/runlevel:5 ./explorer/lsb_id:Debian ./explorer/hostname:limukas ./explorer/lsb_description:Debian GNU/Linux bullseye/sid ./explorer/kernel_name:Linux ./explorer/os:debian ./explorer/init:systemd ./explorer/os_release:PRETTY_NAME="Debian GNU/Linux bullseye/sid" ./explorer/os_release:NAME="Debian GNU/Linux" ./explorer/os_release:ID=debian ./explorer/os_release:HOME_URL="https://www.debian.org/" ./explorer/os_release:SUPPORT_URL="https://www.debian.org/support" ./explorer/os_release:BUG_REPORT_URL="https://bugs.debian.org/" ./explorer/machine_type:physical ./explorer/os_version:bullseye/sid ./explorer/disks:sda sdb sdc ./explorer/lsb_codename:sid ./explorer/interfaces:br0 ./explorer/interfaces:eth0 ./explorer/interfaces:lo ./explorer/cpu_cores:2 ./explorer/lsb_release:unstable ./explorer/memory:31860556 ./explorer/cpu_sockets:1 ./explorer/machine:x86_64 $ cat /etc/debian_version bullseye/sid ``` Type should write to `/etc/default/locale` as it did before 47e28fc441187b5deb869f53396eac1ee0f8cbe7.
ungleich-gitea commented 2021-11-20 15:28:09 +00:00
Author
Owner
Copy Link

mentioned in commit a8ea56253c

mentioned in commit a8ea56253cdb5ebb832cb013b2a76dbcedad16fb
ungleich-gitea commented 2021-11-20 15:28:10 +00:00
Author
Owner
Copy Link

closed via merge request !927

closed via merge request !927
ungleich-gitea commented 2021-11-20 15:28:12 +00:00
Author
Owner
Copy Link

Debian Sid is always just Sid or unstable, it has no version number, because it never gets released.

"sid" does not necessarily mean "new"
I don't run any Debian sid systems

it means that users mostly know what they are doing and always assume latest version of everything. checking for */sid is enough.

Debian Sid is always just Sid or unstable, it has no version number, because it never gets released. > "sid" does not necessarily mean "new" > I don't run any Debian sid systems it means that users mostly know what they are doing and always assume latest version of everything. checking for `*/sid` is enough.
ungleich-gitea commented 2021-11-20 15:28:13 +00:00
Author
Owner
Copy Link

I set up a Debian unstable system and could not find any hints to a version number.
I created a MR !927 that tries to decode the */sid strings to a number.

Please test!

I set up a Debian unstable system and could not find any hints to a version number. I created a MR !927 that tries to decode the `*/sid` strings to a number. Please test!
ungleich-gitea commented 2021-11-20 15:28:14 +00:00
Author
Owner
Copy Link

mentioned in merge request !927

mentioned in merge request !927
ungleich-gitea commented 2021-11-20 15:28:16 +00:00
Author
Owner
Copy Link

@ander I am always trying to be inclusive, but I don't run any Debian sid systems, and as already explained above the issue here is that sid does not report any useable version information and "sid" does not necessarily mean "new".

Having version switches is a common problem in cdist. We could solve it properly here and then reuse it in other places or solve it later…

If you want this issue fixed, then please be a bit more helpful.
I do not back any "delete code that I don't need" hacks.

@ander I am always trying to be inclusive, but I don't run any Debian sid systems, and as already explained above the issue here is that sid does not report any useable version information and "sid" does not necessarily mean "new". Having version switches is a common problem in cdist. We could solve it properly here and then reuse it in other places or solve it later… If you want this issue fixed, then please be a bit more helpful. I do not back any "delete code that I don't need" hacks.
ungleich-gitea commented 2021-11-20 15:28:17 +00:00
Author
Owner
Copy Link

since debian etch, default is /etc/default/locale. same for ubuntu since 2010. and for lots of other distros.

I think we can save everybody's time and just drop support for distros released over 10 years ago and restore previous correct behavior.

if @ssrq wants to be ultra inclusive then please include sid users to the mix and fix this breakage.

since debian etch, default is `/etc/default/locale`. same for ubuntu since 2010. and for lots of other distros. I think we can save everybody's time and just drop support for distros released over 10 years ago and restore previous correct behavior. if @ssrq wants to be ultra inclusive then **please** include sid users to the mix and fix this breakage.
ungleich-gitea commented 2021-11-20 15:28:19 +00:00
Author
Owner
Copy Link

@ssrq I don't know these details. @ander ?

@ssrq I don't know these details. @ander ?
ungleich-gitea commented 2021-11-20 15:28:20 +00:00
Author
Owner
Copy Link

The issue here is that Debian doesn't provide any useable version information (os_version explorer) for sid (pre-releases) and sid could be every Debian release…
(Two years ago I've seen Debian sarge/sid ;-))

Does /etc/os-release provide anything useable?
If not, I fear that manually maintaining a codename to version mapping is necessary if sid should be supported.

The issue here is that Debian doesn't provide any useable version information (`os_version` explorer) for sid (pre-releases) and sid could be every Debian release… (Two years ago I've seen Debian sarge/sid ;-)) Does `/etc/os-release` provide anything useable? If not, I fear that manually maintaining a codename to version mapping is necessary if sid should be supported.
ungleich-gitea commented 2021-11-20 15:28:21 +00:00
Author
Owner
Copy Link

@ssrq Can you take a look (due to 47e28fc441)?

@ssrq Can you take a look (due to https://code.ungleich.ch/ungleich-public/cdist/-/commit/47e28fc441187b5deb869f53396eac1ee0f8cbe7)?
ungleich-gitea commented 2021-11-20 15:28:23 +00:00
Author
Owner
Copy Link

unassigned @poljakowski

unassigned @poljakowski
ungleich-gitea commented 2021-11-20 15:28:24 +00:00
Author
Owner
Copy Link

assigned to @poljakowski

assigned to @poljakowski
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
7.0
6.9
py3.10
ander/__package_apt_update_index
haproxy-dualstack
ander/__sed
beta
ander/os_version_debian_sid
evilham-compatibility-fixes
ander/__rsync
__snakeoil_cert
ander/update_readme
__download_improvements
feature/onchange
cleanup/string-formatting
feature/type-relationship-graph
cleanup/ssh-auth-keys-types
__letsencrypt_cert-fix-hooks
bugfix/preos-debug
bugfix/in-script-import
6.8
bugfix/sphinx-docs-build
6.7
cherry-pick-2f433a14
bugfix/make-code-consistent
6.6
regain-py3.2-support
6.5
bugfix/multiple-log-lines
matterbridge
coturn
alpinefix
matrix
new-type/network-interface
feature/process
6.4
feature/info-command
feature/libexec
6.3
preos-plugins-dir-opt
gitlab-ci
6.2
order-dep-fix
6.1
6.0
build/support-pip-from-git
feature/shell-lib
5.1
feature/support-type-deprecation
5.0
feature/python-types
4.11
4.10
shellcheck
4.9
4.8
freebsd-improvements
new-prometheus
key_value-onchange
feature/output_streams
AnotherKamila-patch-1
__letsencrypt_cert-fixes
letsencrypt-cron-fix
4.7
newtype-__letsencrypt_cert
os_explorer_devuan_fix
prometheus-exporter-fixes
daemontools-for-fbsd
type-prometheus-exporter-from-master
prometheus-more-fixes
4.6
4.5
fix-j
steven-backport
4.4
prometheus-fixes
grafana_dashboard
prometheus
daemontools
consul_improvements
feature/trigger
4.3
4.0-pre-not-stable
4.2
4.1
4.0
feature_install_and_preos
3.1
no-dot-cdist
random_dot_cdist
feature_yum_url
feature_files_export
3.0
2.3
2.2
2.1
ssh_callback
2.0
archive_shell_function_approach
1.7
1.6
1.5
1.4
1.3
1.2
1.1
1.0
7.0.0
6.9.8
6.9.7
6.9.6
6.9.5
6.9.4
6.9.3
6.9.2
6.9.1
6.9.0
6.8.0
6.7.0
6.6.0
6.5.6
6.5.5
6.5.4
6.5.3
6.5.2
6.5.1
6.5.0
6.4.0
6.3.0
6.2.0
6.1.1
6.1.0
6.0.4
6.0.3
6.0.2
6.0.1
6.0.0
5.1.3
5.1.2
5.1.1
5.1.0
5.0.2
5.0.1
5.0.0
4.11.1
4.11.0
4.10.11
4.10.10
4.10.9
4.10.8
4.10.7
4.10.6
4.10.5
4.10.4
4.10.3
4.10.2
4.10.1
4.10.0
4.9.1
4.9.0
4.8.4
4.8.3
4.8.2
4.8.1
4.8.0
4.7.3
4.7.2
4.7.1
4.7.0
4.6.1
4.6.0
4.5.0
4.4.4
4.4.3
4.4.2
4.4.1
4.4.0
4.3.2
4.3.1
4.3.0
4.2.2
4.2.1
4.2.0
4.1.0
4.0.0
3.1.13
tn1
3.1.12
3.1.11
3.1.10
3.1.9
3.1.8
3.1.7
3.1.6
4.0.0pre3
3.1.5
3.1.4
3.1.3
3.1.2
3.1.1
3.1.0
4.0.0pre2
3.0.9
3.0.8
3.0.7
3.0.6
3.0.5
3.0.4
3.0.3
4.0.0pre1
3.0.2
3.0.1
3.0.0
2.3.7
2.3.6
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
2.2.0
2.1.2
2.1.1
2.1.0
2.1.0pre8
2.1.0pre7
2.1.0pre6
2.0.15
2.1.0pre5
2.1.0pre4
2.1.0pre3
2.1.0pre2
2.1.0pre1
2.0.14
2.0.13
2.0.12
2.0.11
2.0.10
2.0.9
2.0.8
2.0.7
2.0.6
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0.0
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.9
0.9.8
0.9.7
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
0.8
0.7
0.6
0.5
0.4
0.3
0.2
0.1
Labels
Clear labels   
bugfix

   
cleanup

   
discussion

   
documentation

   
doing

   
done

   
feature

   
improvement

   
packaging

   
Stale

   
testing

   
TODO
No Label
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/cdist#33
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?