Change min supported Python version #50

New Issue

ungleich-gitea · 2021-11-20T11:25:11Z

ungleich-gitea commented

2021-11-20 11:25:11 +00:00

Regarding https://code.ungleich.ch/ungleich-public/cdist/-/merge_requests/888
I have just tried running $ cdist -h with Python 3.2.6 and I see that preos implementation broke Python 3.2 support:

Traceback (most recent call last):
  File "scripts/cdist", line 27, in <module>
    import cdist.argparse
  File "/usr/home/darko/ungleich/upstream/cdist/cdist/argparse.py", line 9, in <module>
    import cdist.preos
  File "/usr/home/darko/ungleich/upstream/cdist/cdist/preos.py", line 46
    yield from preos_plugin(module)
             ^
SyntaxError: invalid syntax

And nobody is complaining :)

yield from is added in 3.3.

@nico @steven I would go with min 3.5, and simplify current state of https://code.ungleich.ch/ungleich-public/cdist/-/merge_requests/888 so that we don't have version check for log server.

Regarding https://code.ungleich.ch/ungleich-public/cdist/-/merge_requests/888 I have just tried running `$ cdist -h` with Python 3.2.6 and I see that `preos` implementation broke `Python 3.2` support: ``` Traceback (most recent call last): File "scripts/cdist", line 27, in <module> import cdist.argparse File "/usr/home/darko/ungleich/upstream/cdist/cdist/argparse.py", line 9, in <module> import cdist.preos File "/usr/home/darko/ungleich/upstream/cdist/cdist/preos.py", line 46 yield from preos_plugin(module) ^ SyntaxError: invalid syntax ``` And nobody is complaining :) `yield from` is added in `3.3`. @nico @steven I would go with min 3.5, and simplify current state of https://code.ungleich.ch/ungleich-public/cdist/-/merge_requests/888 so that we don't have version check for log server.

ungleich-gitea closed this issue

2021-11-20 11:25:12 +00:00

ungleich-gitea commented

2021-11-20 15:31:01 +00:00

closed

ungleich-gitea commented

2021-11-20 15:31:03 +00:00

eec7ab8e45

https://code.ungleich.ch/ungleich-public/cdist/-/commit/eec7ab8e4577008c6a48a473e295a9d1e31f2358

ungleich-gitea commented

2021-11-20 15:31:04 +00:00

Note that this affects only a system you are running cdist on, not the hosts you are configuring, cdist target hosts do not require python at all.
https://www.cdi.st/cdist-install.html#requirements

Note that this affects only a system you are running cdist on, not the hosts you are configuring, cdist target hosts do not require python at all. https://www.cdi.st/cdist-install.html#requirements

ungleich-gitea commented

2021-11-20 15:31:05 +00:00

It is decided.

Min python version is going to be bumped to 3.5.

@ssrq Jessie's end of life is here.
https://wiki.debian.org/LTS/Jessie.

It is decided. Min python version is going to be bumped to **3.5**. @ssrq Jessie's end of life is here. https://wiki.debian.org/LTS/Jessie.

ungleich-gitea commented

2021-11-20 15:31:07 +00:00

mentioned in merge request !890

ungleich-gitea commented

2021-11-20 15:31:08 +00:00

@ssrq For now, we will not bump min required version. At least not until both cdist BDFLs give a green light :)

ungleich-gitea commented

2021-11-20 15:31:10 +00:00

I can push these upstream if someone is interested:

[21:54:25] eos:.cdist-hpc% la type/ | grep pyenv
drwxr-xr-x   3 sar sar   5 May 22  2018 __pyenv
drwxr-xr-x   4 sar sar   7 Feb 17 21:45 __pyenv_python
drwxr-xr-x   4 sar sar   7 May 22  2018 __pyenv_virtualenv
[21:54:25] eos:.cdist-hpc%

I can push these upstream if someone is interested: ``` [21:54:25] eos:.cdist-hpc% la type/ | grep pyenv drwxr-xr-x 3 sar sar 5 May 22 2018 __pyenv drwxr-xr-x 4 sar sar 7 Feb 17 21:45 __pyenv_python drwxr-xr-x 4 sar sar 7 May 22 2018 __pyenv_virtualenv [21:54:25] eos:.cdist-hpc% ```

ungleich-gitea commented

2021-11-20 15:31:11 +00:00

@poljakowski OK, I see. So it seems that Python 3.2 is not used anymore.

Could we bump the minimum requirement to 3.4 instead of 3.5?
I still have Debian jessie systems around (one of them being the machine that contains my collection of VMs that I use to test my cdist types.)

@poljakowski OK, I see. So it seems that Python 3.2 is not used anymore. Could we bump the minimum requirement to 3.4 instead of 3.5? I still have Debian jessie systems around (one of them being the machine that contains my collection of VMs that I use to test my cdist types.)

ungleich-gitea commented

2021-11-20 15:31:13 +00:00

It seems it was a woman :) Grace Hopper.

https://en.wikiquote.org/wiki/Grace_Hopper

@steven So if I get you right, we should just do it. :)

It seems it was a woman :) Grace Hopper. https://en.wikiquote.org/wiki/Grace_Hopper @steven So if I get you right, we should just do it. :)

ungleich-gitea commented

2021-11-20 15:31:14 +00:00

A wise man once said: Better ask forgiveness then permission.

ungleich-gitea commented

2021-11-20 15:31:16 +00:00

Is it worth to go deeper and deeper?

Nobody is complaining since 2017. when DEVNULL is introduced :)

Is it worth to go deeper and deeper? Nobody is complaining since 2017. when DEVNULL is introduced :)

ungleich-gitea commented

2021-11-20 15:31:17 +00:00

We are also using subprocess.DEVNULL which is introduced in 3.3.

I wonder what else.

We are also using `subprocess.DEVNULL` which is introduced in `3.3`. I wonder what else.

ungleich-gitea commented

2021-11-20 15:31:18 +00:00

Hm... yield from is actually used in more places :)

$ find . -type f -name "*py" -exec grep 'yield from' {} +
./cdist/config.py:            yield from cdist.hostsource.HostSource(source)()
./cdist/hostsource.py:            yield from self._hosts_from_file()
./cdist/hostsource.py:            yield from self._hosts_from_sequence()
./cdist/hostsource.py:        yield from self.hosts()
./cdist/preos.py:            yield from preos_plugin(module)
./cdist/preos.py:                yield from preos_plugin(c)
./cdist/preos.py:        yield from scan_preos_dir_plugins(dir)

We can fix those though.

Hm... `yield from` is actually used in more places :) ``` $ find . -type f -name "*py" -exec grep 'yield from' {} + ./cdist/config.py: yield from cdist.hostsource.HostSource(source)() ./cdist/hostsource.py: yield from self._hosts_from_file() ./cdist/hostsource.py: yield from self._hosts_from_sequence() ./cdist/hostsource.py: yield from self.hosts() ./cdist/preos.py: yield from preos_plugin(module) ./cdist/preos.py: yield from preos_plugin(c) ./cdist/preos.py: yield from scan_preos_dir_plugins(dir) ``` We can fix those though.

ungleich-gitea commented

2021-11-20 15:31:20 +00:00

If it can be fixed with a one line change, why not?
If more changes are required, this can be discussed, IMO.

If it can be fixed with a one line change, why not? If more changes are required, this can be discussed, IMO.

ungleich-gitea commented

2021-11-20 15:31:21 +00:00

I know, but I am not sure if it's worth it to keep supporting old Python versions.

ungleich-gitea commented

2021-11-20 15:31:22 +00:00

This issue could easily be fixed (cf. also PEP 380):

for plugin in preos_plugin(module):
    yield plugin

This issue could easily be fixed (cf. also [PEP 380](https://www.python.org/dev/peps/pep-0380/)): ```python for plugin in preos_plugin(module): yield plugin ```

ungleich-gitea commented

2021-11-20 15:31:24 +00:00

as discussed already in chat - LGTM

Sign in to join this conversation.