Refactor code and log messages for possible errors
This commit is contained in:
		
					parent
					
						
							
								29c24574aa
							
						
					
				
			
			
				commit
				
					
						eb067f5708
					
				
			
		
					 1 changed files with 26 additions and 12 deletions
				
			
		| 
						 | 
				
			
			@ -535,6 +535,7 @@ class MembershipDeactivateView(LoginRequiredMixin, UpdateView):
 | 
			
		|||
        membership_order = MembershipOrder.objects.filter(
 | 
			
		||||
            customer__user=self.request.user
 | 
			
		||||
        ).last()
 | 
			
		||||
        if membership_order:
 | 
			
		||||
            if membership_order.subscription_id:
 | 
			
		||||
                result = stripe_utils.unsubscribe_customer(
 | 
			
		||||
                    subscription_id=membership_order.subscription_id
 | 
			
		||||
| 
						 | 
				
			
			@ -545,11 +546,24 @@ class MembershipDeactivateView(LoginRequiredMixin, UpdateView):
 | 
			
		|||
                        stripe_subscription_obj.status != 'canceled'):
 | 
			
		||||
                    error_msg = result.get('error')
 | 
			
		||||
                    logger.error(
 | 
			
		||||
                    "Could not cancel Digital Glarus subscription. Reason: "
 | 
			
		||||
                    "{reason}".format(
 | 
			
		||||
                        "Could not cancel Digital Glarus subscription. "
 | 
			
		||||
                        "Reason: {reason}".format(
 | 
			
		||||
                            reason=error_msg
 | 
			
		||||
                        )
 | 
			
		||||
                    )
 | 
			
		||||
            else:
 | 
			
		||||
                logger.error(
 | 
			
		||||
                    "User {user} may have Stripe subscriptions created "
 | 
			
		||||
                    "manually. Please check.".format(
 | 
			
		||||
                        user=self.request.user.name
 | 
			
		||||
                    )
 | 
			
		||||
                )
 | 
			
		||||
        else:
 | 
			
		||||
            logger.error(
 | 
			
		||||
                "MembershipOrder for {user} not found".format(
 | 
			
		||||
                            user=self.request.user.name
 | 
			
		||||
                )
 | 
			
		||||
            )
 | 
			
		||||
 | 
			
		||||
        return HttpResponseRedirect(self.success_url)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue