ungleich-public
/
dynamicweb
6
0
Fork 0
Code Issues 1 Pull Requests 2 Projects Releases Wiki Activity

Newsletter/beta request confirmation email #2

New Issue
Closed
opened 2021-11-20 15:59:45 +00:00 by ungleich-gitea · 4 comments
ungleich-gitea commented 2021-11-20 15:59:45 +00:00
Owner
Copy Link

Created by: verysanghee

Problem
The dcl logo in newsletter subscription email redirects to ungleich home (https://datacenterlight.ungleich.ch/) instead of dcl site

Goal
The dcl logo should redirect to dcl
screen shot 2017-06-02 at 11 44 58

*Created by: verysanghee* **Problem** The dcl logo in newsletter subscription email redirects to ungleich home (https://datacenterlight.ungleich.ch/) instead of dcl site **Goal** The dcl logo should redirect to dcl <img width="652" alt="screen shot 2017-06-02 at 11 44 58" src="https://cloud.githubusercontent.com/assets/10186611/26727165/fac92e50-47a5-11e7-8be0-881fdd8062c1.png">
ungleich-gitea added the
bug
 label 2021-11-20 15:59:45 +00:00
ungleich-gitea commented 2021-11-20 15:59:52 +00:00
Author
Owner
Copy Link

Created by: pcoder

This issue is outdated. So, closing this.

By Mondi Ravi on 2017-12-20T08:06:32 (imported from GitLab project)

*Created by: pcoder* This issue is outdated. So, closing this. *By Mondi Ravi on 2017-12-20T08:06:32 (imported from GitLab project)*
ungleich-gitea commented 2021-11-20 15:59:52 +00:00
Author
Owner
Copy Link

Created by: pcoder

I think this may not be a bug really, and I think it works as expected.
Here is my observation:

The code behind this is https://github.com/ungleich/dynamicweb/blob/master/datacenterlight/templates/datacenterlight/emails/request_access_confirmation.html#L78
which seems to correctly use the {{base_url}} for the logo.

During my tests to reproduce the bug, I never found the link of logo pointing to a url other than the host that generated the email.

By Mondi Ravi on 2017-06-05T20:05:01 (imported from GitLab project)

*Created by: pcoder* I think this may not be a bug really, and I think it works as expected. Here is my observation: - If I subscribe to the newsletter on https://datacenterlight.ch, I receive an email with the logo pointing to https://datacenterlight.ch - If I subscribe to the newsletter on https://dynamicweb-staging.ungleich.ch/datacenterlight, I receive an email with the logo pointing to https://dynamicweb-staging.ungleich.ch The code behind this is https://github.com/ungleich/dynamicweb/blob/master/datacenterlight/templates/datacenterlight/emails/request_access_confirmation.html#L78 which seems to correctly use the `{{base_url}}` for the logo. During my tests to reproduce the bug, I never found the link of logo pointing to a url other than the host that generated the email. *By Mondi Ravi on 2017-06-05T20:05:01 (imported from GitLab project)*
ungleich-gitea commented 2021-11-20 15:59:52 +00:00
Author
Owner
Copy Link

Created by: verysanghee

Thanks for the tips! I'll assign all the email issues to you, maybe this way it's easier. You can be responsible for all mail issues.

By Mondi Ravi on 2017-06-03T09:32:25 (imported from GitLab project)

*Created by: verysanghee* Thanks for the tips! I'll assign all the email issues to you, maybe this way it's easier. You can be responsible for all mail issues. *By Mondi Ravi on 2017-06-03T09:32:25 (imported from GitLab project)*
ungleich-gitea commented 2021-11-20 15:59:53 +00:00
Author
Owner
Copy Link

Created by: noeleont

@verysanghee thanks for this issue! You can use the Assignees on the right side to choose who you want to assign this issue as well as set the correct label for your issue - bug I guess in this case -.

By Mondi Ravi on 2017-06-03T08:20:42 (imported from GitLab project)

*Created by: noeleont* @verysanghee thanks for this issue! You can use the Assignees on the right side to choose who you want to assign this issue as well as set the correct label for your issue - bug I guess in this case -. *By Mondi Ravi on 2017-06-03T08:20:42 (imported from GitLab project)*
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
make-docker-build-succesful
requirements
12186-3ds
recaptcha
docker
improve-logging
7819/use-ascii-chars-only-for-username
master-2.10.1
bugfix/ldap_migration
feature/old_master
feature/nosystemd
feature/vm_pricing
3.4
3.3
3.2
3.1
3.0
2.14
2.13
2.12.1
2.12
2.11
2.10.8
2.10.7
2.10.6
2.10.5
2.10.4b
2.10.3b
2.10.2b
2.10.3
2.10.2
2.10.1
2.10
2.9.5
2.9.4
2.9.3
2.9.2
2.9.1
2.9
2.8.2
2.8.1
2.8
2.7.3
2.7.2
2.7.1
2.7
2.6.10
2.6.9
2.6.8
2.6.7
2.6.6
2.6.5
2.6.4
2.6.3
2.6.2
2.6.1
2.6
2.5.11
2.5.10
2.5.9
2.5.8
2.5.7
2.5.6
2.5.5
2.5.4
2.5.3
2.5.2
2.5.1
2.5
2.4.10
2.4.9
2.4.8
2.4.7
2.4.6
2.4.5
2.4.4
2.4.3
2.4.2
2.4.1
2.4
2.3.1
2.3
2.2.2
2.2.1
2.2
2.1.2
2.1.1
2.1
2.0.5
2.0.4
2.0.3
2.0.2
2.0.1
2.0
1.9.1
1.9
1.8
1.7.2
1.7.1
1.7
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6
1.5.5
1.5.4
1.5.3
1.5.2
1.5.1
1.5
1.4.1
1.4
1.3.3
1.3.2
1.3.1
1.3
1.2.13
1.2.12
1.2.11
1.2.10
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2
1.1.1
1.1
1.0.24
1.0.23
1.0.22
1.0.21
1.0.20
1.0.19
1.0.18
1.0.17
1.0.16
1.0.15
1.0.14
1.0.13
1.0.12
1.0.11
1.0.10
1.0.9
1.0.8
1.0.7
1.0.6
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
old-2.0
Labels
Clear labels   
bug

   
come back to it later

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
needs a review

   
needs to be tested

   
question

   
ready for testing

   
wontfix

   
work in progress
No Label
bug
come back to it later
duplicate
enhancement
help wanted
invalid
needs a review
needs to be tested
question
ready for testing
wontfix
work in progress
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ungleich-public/dynamicweb#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?