xmj/element-call
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1094 from robintown/widget-join-delay

Browse source 
Don't prematurely claim that we've joined the call in widget mode
This commit is contained in:
Robin 2023-06-08 10:24:32 -04:00 committed by GitHub
commit 1bfbb80f6d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/room/useGroupCall.ts
View file

@ -65,7 +65,7 @@ export interface UseGroupCallReturnType {
localVideoMuted: boolean; localVideoMuted: boolean;
error: TranslatedError | null; error: TranslatedError | null;
initLocalCallFeed: () => void; initLocalCallFeed: () => void;
enter: () => void; enter: () => Promise<void>;
leave: () => void; leave: () => void;
toggleLocalVideoMuted: () => void; toggleLocalVideoMuted: () => void;
toggleMicrophoneMuted: () => void; toggleMicrophoneMuted: () => void;
@ -483,7 +483,7 @@ export function useGroupCall(
[groupCall] [groupCall]
); );
const enter = useCallback(() => { const enter = useCallback(async () => {
if ( if (
groupCall.state !== GroupCallState.LocalCallFeedUninitialized && groupCall.state !== GroupCallState.LocalCallFeedUninitialized &&
groupCall.state !== GroupCallState.LocalCallFeedInitialized groupCall.state !== GroupCallState.LocalCallFeedInitialized
@ -498,7 +498,7 @@ export function useGroupCall(
// have started tracking by the time calls start getting created. // have started tracking by the time calls start getting created.
groupCallOTelMembership?.onJoinCall(); groupCallOTelMembership?.onJoinCall();
groupCall.enter().catch((error) => { await groupCall.enter().catch((error) => {
console.error(error); console.error(error);
updateState({ error }); updateState({ error });
}); });