xmj/element-call
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't pass null / undefined as attribute value

Browse source
This commit is contained in:
David Baker 2023-04-03 17:41:40 +01:00
parent 3a7983d2de
commit 30f75c6cd2
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
config/otel_dev/collector-gateway.yaml
View file

@ -8,7 +8,7 @@ receivers:
# This can't be '*' because opentelemetry-js uses sendBeacon which always operates # This can't be '*' because opentelemetry-js uses sendBeacon which always operates
# in 'withCredentials' mode, which browsers don't allow with an allow-origin of '*' # in 'withCredentials' mode, which browsers don't allow with an allow-origin of '*'
#- "https://pr976--element-call.netlify.app" #- "https://pr976--element-call.netlify.app"
- "https://*" - "http://*"
allowed_headers: allowed_headers:
- "*" - "*"
processors: processors:

3
src/otel/OTelGroupCallMembership.ts
View file

@ -171,7 +171,8 @@ export class OTelGroupCallMembership {
span.setAttribute("matrix.call.target.userId", userId); span.setAttribute("matrix.call.target.userId", userId);
span.setAttribute("matrix.call.target.deviceId", deviceId); span.setAttribute("matrix.call.target.deviceId", deviceId);
const displayName = this.groupCall.room.getMember(userId)?.name; const displayName =
this.groupCall.room.getMember(userId)?.name ?? "unknown";
span.setAttribute("matrix.call.target.displayName", displayName); span.setAttribute("matrix.call.target.displayName", displayName);
this.callsByCallId.set(call.callId, { this.callsByCallId.set(call.callId, {
userId, userId,