From 3b06258e40c7e83725520627b474874cc315ada5 Mon Sep 17 00:00:00 2001
From: Enrico Schwendig <enricos@element.io>
Date: Mon, 3 Apr 2023 14:07:29 +0200
Subject: [PATCH] stats: rename enum to avoid shadow values

---
 src/otel/OTelGroupCallMembership.ts | 12 ++++++------
 src/otel/otel.ts                    |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/otel/OTelGroupCallMembership.ts b/src/otel/OTelGroupCallMembership.ts
index 78f171f..45d5bfd 100644
--- a/src/otel/OTelGroupCallMembership.ts
+++ b/src/otel/OTelGroupCallMembership.ts
@@ -320,7 +320,7 @@ export class OTelGroupCallMembership {
   public onConnectionStatsReport(
     statsReport: GroupCallStatsReport<ConnectionStatsReport>
   ) {
-    const type = OTelStatsReportType.ConnectionStatsReport;
+    const type = OTelStatsReportType.ConnectionReport;
     const data =
       ObjectFlattener.flattenConnectionStatsReportObject(statsReport);
     this.buildStatsEventSpan({ type, data });
@@ -329,7 +329,7 @@ export class OTelGroupCallMembership {
   public onByteSentStatsReport(
     statsReport: GroupCallStatsReport<ByteSentStatsReport>
   ) {
-    const type = OTelStatsReportType.ByteSentStatsReport;
+    const type = OTelStatsReportType.ByteSentReport;
     const data = ObjectFlattener.flattenByteSentStatsReportObject(statsReport);
     this.buildStatsEventSpan({ type, data });
   }
@@ -337,7 +337,7 @@ export class OTelGroupCallMembership {
   public onSummaryStatsReport(
     statsReport: GroupCallStatsReport<SummaryStatsReport>
   ) {
-    const type = OTelStatsReportType.SummaryStatsReport;
+    const type = OTelStatsReportType.SummaryReport;
     const data = ObjectFlattener.flattenSummaryStatsReportObject(statsReport);
     this.buildStatsEventSpan({ type, data });
   }
@@ -389,7 +389,7 @@ interface OTelStatsReportEvent {
 }
 
 enum OTelStatsReportType {
-  ConnectionStatsReport = "matrix.stats.connection",
-  ByteSentStatsReport = "matrix.stats.byteSent",
-  SummaryStatsReport = "matrix.stats.summary",
+  ConnectionReport = "matrix.stats.connection",
+  ByteSentReport = "matrix.stats.byteSent",
+  SummaryReport = "matrix.stats.summary",
 }
diff --git a/src/otel/otel.ts b/src/otel/otel.ts
index eac7ce4..d079da4 100644
--- a/src/otel/otel.ts
+++ b/src/otel/otel.ts
@@ -48,7 +48,7 @@ export class ElementCallOpenTelemetry {
     return sharedInstance;
   }
 
-  constructor(collectorUrl: string) {
+  constructor(collectorUrl: string | undefined) {
     const otlpExporter = new OTLPTraceExporter({
       url: collectorUrl,
     });