Merge pull request #602 from vector-im/dbkr/fix_capture_devices_left_on

Fix bug causing mic/webcam to remain open after call

src/room/GroupCallView.tsx

@@ -132,15 +132,14 @@ export function GroupCallView({
   const history = useHistory();
 
   const onLeave = useCallback(() => {
+    setLeft(true);
     leave();
     if (widget) {
       widget.api.transport.send(ElementWidgetActions.HangupCall, {});
       widget.api.setAlwaysOnScreen(false);
     }
 
-    if (isPasswordlessUser) {
+    if (!isPasswordlessUser && !isEmbedded) {
-      setLeft(true);
-    } else if (!isEmbedded) {
       history.push("/");
     }
   }, [leave, isPasswordlessUser, isEmbedded, history]);
@@ -208,7 +207,14 @@ export function GroupCallView({
       </FullScreenView>
     );
   } else if (left) {
-    return <CallEndedView client={client} />;
+    if (isPasswordlessUser) {
+      return <CallEndedView client={client} />;
+    } else {
+      // If the user is a regular user, we'll have sent them back to the homepage,
+      // so just sit here & do nothing: otherwise we would (briefly) mount the
+      // LobbyView again which would open capture devices again.
+      return null;
+    }
   } else if (preload) {
     return null;
   } else if (isEmbedded) {