xmj/element-call
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Work around data-testid issue by tagging the icon not the Item.

Browse source
This commit is contained in:
Michael Kaye 2023-05-03 16:27:35 +01:00
parent a71a1c5c93
commit c70536996e
2 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/UserMenu.tsx
View file

@ -116,8 +116,13 @@ export function UserMenu({
{(props) => ( {(props) => (
<Menu {...props} label={t("User menu")} onAction={onAction}> <Menu {...props} label={t("User menu")} onAction={onAction}>
{items.map(({ key, icon: Icon, label, dataTestid }) => ( {items.map(({ key, icon: Icon, label, dataTestid }) => (
<Item key={key} textValue={label} data-testid={dataTestid}> <Item key={key} textValue={label}>
<Icon width={24} height={24} className={styles.menuIcon} /> <Icon
width={24}
height={24}
className={styles.menuIcon}
data-testid={dataTestid}
/>
<Body overflowEllipsis>{label}</Body> <Body overflowEllipsis>{label}</Body>
</Item> </Item>
))} ))}

7
src/profile/ProfileModal.tsx
View file

@ -119,6 +119,7 @@ export function ProfileModal({ client, ...rest }: Props) {
placeholder={t("Display name")} placeholder={t("Display name")}
value={displayName} value={displayName}
onChange={onChangeDisplayName} onChange={onChangeDisplayName}
data-testid="profile_displayname"
/> />
</FieldRow> </FieldRow>
{error && ( {error && (
@ -130,7 +131,11 @@ export function ProfileModal({ client, ...rest }: Props) {
<Button type="button" variant="secondary" onPress={onClose}> <Button type="button" variant="secondary" onPress={onClose}>
Cancel Cancel
</Button> </Button>
<Button type="submit" disabled={loading}> <Button
type="submit"
disabled={loading}
data-testid="profile_submit"
>
{loading ? t("Saving…") : t("Save")} {loading ? t("Saving…") : t("Save")}
</Button> </Button>
</FieldRow> </FieldRow>