Merge pull request #1107 from robintown/new-grid-breakpoint

Switch to the new grid once there are >12 participants
This commit is contained in:
Robin 2023-06-13 15:14:04 -04:00 committed by GitHub
commit dabecf54bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 19 deletions

View file

@ -102,7 +102,6 @@
"Turn off camera": "Turn off camera", "Turn off camera": "Turn off camera",
"Turn on camera": "Turn on camera", "Turn on camera": "Turn on camera",
"Unmute microphone": "Unmute microphone", "Unmute microphone": "Unmute microphone",
"Use the upcoming grid system": "Use the upcoming grid system",
"User menu": "User menu", "User menu": "User menu",
"Username": "Username", "Username": "Username",
"Version: {{version}}": "Version: {{version}}", "Version: {{version}}": "Version: {{version}}",

View file

@ -56,7 +56,7 @@ import {
TileDescriptor, TileDescriptor,
} from "../video-grid/VideoGrid"; } from "../video-grid/VideoGrid";
import { Avatar } from "../Avatar"; import { Avatar } from "../Avatar";
import { useNewGrid, useShowInspector } from "../settings/useSetting"; import { useShowInspector } from "../settings/useSetting";
import { useModalTriggerState } from "../Modal"; import { useModalTriggerState } from "../Modal";
import { PosthogAnalytics } from "../analytics/PosthogAnalytics"; import { PosthogAnalytics } from "../analytics/PosthogAnalytics";
import { useUrlParams } from "../UrlParams"; import { useUrlParams } from "../UrlParams";
@ -277,8 +277,8 @@ export function InCallView({
[] []
); );
const [newGrid] = useNewGrid(); const Grid =
const Grid = newGrid ? NewVideoGrid : VideoGrid; items.length > 12 && layout === "freedom" ? NewVideoGrid : VideoGrid;
const prefersReducedMotion = usePrefersReducedMotion(); const prefersReducedMotion = usePrefersReducedMotion();
const renderContent = (): JSX.Element => { const renderContent = (): JSX.Element => {

View file

@ -33,7 +33,6 @@ import { MediaDevicesState } from "./mediaDevices";
import { import {
useShowInspector, useShowInspector,
useOptInAnalytics, useOptInAnalytics,
useNewGrid,
useDeveloperSettingsTab, useDeveloperSettingsTab,
} from "./useSetting"; } from "./useSetting";
import { FieldRow, InputField } from "../input/Input"; import { FieldRow, InputField } from "../input/Input";
@ -60,7 +59,6 @@ export const SettingsModal = (props: Props) => {
const [optInAnalytics, setOptInAnalytics] = useOptInAnalytics(); const [optInAnalytics, setOptInAnalytics] = useOptInAnalytics();
const [developerSettingsTab, setDeveloperSettingsTab] = const [developerSettingsTab, setDeveloperSettingsTab] =
useDeveloperSettingsTab(); useDeveloperSettingsTab();
const [newGrid, setNewGrid] = useNewGrid();
const downloadDebugLog = useDownloadDebugLog(); const downloadDebugLog = useDownloadDebugLog();
@ -235,17 +233,6 @@ export const SettingsModal = (props: Props) => {
} }
/> />
</FieldRow> </FieldRow>
<FieldRow>
<InputField
id="newGrid"
label={t("Use the upcoming grid system")}
type="checkbox"
checked={newGrid}
onChange={(e: React.ChangeEvent<HTMLInputElement>) =>
setNewGrid(e.target.checked)
}
/>
</FieldRow>
<FieldRow> <FieldRow>
<Button onPress={downloadDebugLog}> <Button onPress={downloadDebugLog}>
{t("Download debug logs")} {t("Download debug logs")}

View file

@ -98,7 +98,5 @@ export const useOptInAnalytics = (): DisableableSetting<boolean | null> => {
return [false, null]; return [false, null];
}; };
export const useNewGrid = () => useSetting("new-grid", false);
export const useDeveloperSettingsTab = () => export const useDeveloperSettingsTab = () =>
useSetting("developer-settings-tab", false); useSetting("developer-settings-tab", false);