xmj/element-call
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Inform that the user that config keys are missing (#880)

Browse source
This commit is contained in:
Timo 2023-02-09 12:57:54 +01:00 • committed by GitHub
commit eda11cfc08
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/PosthogAnalytics.ts
View file

@ -94,7 +94,7 @@ export class PosthogAnalytics {
private static ANALYTICS_EVENT_TYPE = "im.vector.analytics"; private static ANALYTICS_EVENT_TYPE = "im.vector.analytics";
// set true during the constructor if posthog config is present, otherwise false // set true during the constructor if posthog config is present, otherwise false
private static internalInstance = null; private static internalInstance: PosthogAnalytics | null = null;
private identificationPromise: Promise<void>; private identificationPromise: Promise<void>;
private readonly enabled: boolean = false; private readonly enabled: boolean = false;
@ -137,6 +137,9 @@ export class PosthogAnalytics {
}); });
this.enabled = true; this.enabled = true;
} else { } else {
logger.info(
"Posthog is not enabled because there is no api key or no host given in the config"
);
this.enabled = false; this.enabled = false;
} }
this.startListeningToSettingsChanges(); this.startListeningToSettingsChanges();
@ -225,9 +228,7 @@ export class PosthogAnalytics {
} }
public async identifyUser(analyticsIdGenerator: () => string) { public async identifyUser(analyticsIdGenerator: () => string) {
// There might be a better way to get the client here. if (this.anonymity == Anonymity.Pseudonymous && this.enabled) {
if (this.anonymity == Anonymity.Pseudonymous) {
// Check the user's account_data for an analytics ID to use. Storing the ID in account_data allows // Check the user's account_data for an analytics ID to use. Storing the ID in account_data allows
// different devices to send the same ID. // different devices to send the same ID.
let analyticsID = await this.getAnalyticsId(); let analyticsID = await this.getAnalyticsId();

2
src/initializer.tsx
View file

@ -214,5 +214,5 @@ export class Initializer {
resolve(); resolve();
} }
} }
private initPromise: Promise<void>; private initPromise: Promise<void> | null;
} }