xmj/element-call
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
1895 commits 3 branches 0 tags 10 MiB
Commit graph

1163 commits

Author SHA1 Message Date
David Baker
4459eaeb9d Fix audio mute on window blur 
https://github.com/vector-im/element-call/pull/1015/files missed a
change of spacebarHeld to a ref.
 2023-04-21 10:18:43 +01:00
David Baker
f5e2161a9e Add the event name to the rageshake span processor export 2023-04-20 17:18:06 +01:00
Robin
8437e263af
Merge pull request #1013 from robintown/controls-overlay 
Keep inspector from covering call buttons
 2023-04-20 10:45:36 -04:00
Robin
4719a92ffc
Merge pull request #1015 from robintown/shortcut-focus 
Make keyboard shortcuts accessible by default
 2023-04-20 10:45:11 -04:00
David Baker
d1aa34b2e0 Use the native ResizeObserver where available 
My dev env suddenly, with no apparent prompt, went into a mode where
it wouldn't display nay video tiles which was because they were 0x0
in the top left corner, which in turn was because the ResizeObserver
was never returning the actual bounds of the video tile container.

As per comment, this uses the native impl in preference to the ponyfill,
although in practice it looks like all our target browsers should support
it, so perhaps we could just remove the ponyfill entirely.
 2023-04-20 13:39:25 +01:00
Robin Townsend
4114622d44 Remove the keyboard shortcut setting 2023-04-19 16:15:38 -04:00
Robin Townsend
6f13989819 Fix lint errors 2023-04-19 15:55:55 -04:00
Robin Townsend
1184b71396 Format with Prettier 2023-04-19 15:54:39 -04:00
Robin Townsend
56bd54a645 Disable keyboard shortcuts when focus is in a modal 2023-04-19 15:51:44 -04:00
Robin Townsend
18fa1371d3 Use a ref for spacebarHeld 
because we can and it means fewer renders
 2023-04-19 15:17:32 -04:00
Robin Townsend
6ad4663508 Keep inspector from covering call buttons 2023-04-19 14:43:37 -04:00
Robin Townsend
3c7f01a510 Make audio activity border match the tile border radius 2023-04-19 10:24:47 -04:00
David Baker
8eafb1ae4a
Merge pull request #1005 from robintown/parallel-calls 
Detect split-brains caused by parallel calls
 2023-04-18 17:29:23 +01:00
Enrico Schwendig
3da4b4eeef
Add jitter and packet loss info in summary report (#1006) 
* stats: add jitter and packet loss
 2023-04-18 15:20:06 +02:00
David Baker
0de1aa74ee Use microseconds in the rageshake exporter 
Fixes times being off by a factor of 1000
 2023-04-18 12:48:34 +01:00
Robin Townsend
838137c83b Detect split-brains caused by parallel calls 
This is another KPI for PostHog.
 2023-04-17 16:58:51 -04:00
David Baker
9442b314b2 Fix PostHog in embedded mode 
Embedded mode has a differtent path to join the call and we missed
changing the groupCall.enter() function for the wrapper that does
analytics.
 2023-04-17 18:47:46 +01:00
Robin
7221b7c3a2
Merge pull request #998 from robintown/rageshake-processor 
Include unended spans in rageshakes
 2023-04-14 11:55:16 -04:00
Robin Townsend
da7760d7ab Send rejoin events to PostHog in realtime 
By converting PosthogSpanExporter to a SpanProcessor just like the RageshakeSpanProcessor, it can now monitor spans in realtime as they are started.
 2023-04-12 18:14:59 -04:00
Robin Townsend
a17ffcc327 Include unended spans in rageshakes 
By turning the RageshakeSpanExporter into a SpanProcessor, it can now be notified of spans as soon as they're started.
 2023-04-12 17:12:02 -04:00
Robin Townsend
0637804d61 Fix a crash when adding call events to telemetry 
Since typeof null is 'object', the flattenVoipEventRecursive function was mistakenly casting nulls to Record<string, unknown> in its typeof v === "object" case, causing Object.entries to explode.
 2023-04-11 23:05:37 -04:00
Robin
a2b3e098b6
Merge pull request #995 from robintown/rageshake-traces 
Include OpenTelemetry traces in rageshakes
 2023-04-11 16:24:09 -04:00
Enrico Schwendig
e2293665f9
Add posthog event for summary report (#992) 
* stats: add posthog event for summary report

* stats: remove console log
 2023-04-11 09:06:13 +02:00
Robin Townsend
95eca18207 Include OpenTelemetry traces in rageshakes 2023-04-11 01:13:19 -04:00
Enrico Schwendig
bb5c382fd0
separate summary report from stats report (#986) 
* stats: separate summary report from stats report

* stats: switch to last summery stats builder

* stats: update matrix-js-sdk
 2023-04-06 13:19:39 +02:00
David Baker
dd1485a277
Merge pull request #988 from vector-im/dbkr/enable_otel_by_collector 
Allow different OpenTelemetry collectors to be enabled/disabled
 2023-04-05 20:05:41 +01:00
David Baker
caea22fa89 Remove the recheck callback since it isn't necessary for now 2023-04-05 19:00:07 +01:00
David Baker
88f3b30040 Allow different OpenTelemetry collectors to be enabled/disabled 
Always enable OpenTelemetry, but conditionally enable the OTLP
exporter, as per comment.

Fixes https://github.com/vector-im/element-call/issues/987
 2023-04-05 18:21:29 +01:00
Robin Townsend
928f1c1d6f Address review feedback 2023-04-05 12:56:50 -04:00
Robin Townsend
711cdf9a60 Merge branch 'main' into audio-observability 2023-04-05 12:50:38 -04:00
David Baker
fec299ab20 Skip whole block if no otel instance 2023-04-05 15:11:51 +01:00
David Baker
5e4aa53997 Don't call posthog before its initialised 2023-04-05 15:00:14 +01:00
David Baker
0dcaa90650 Fix exception when loading PostHog 
PostHog was expecting the matrix client object to be initialised at
the point it ran its setup, which wasn't the case. Check to see if it's
there on login and add an onLoginStatusChanged hook that to re-check.

Also make a few methods private that didn't need to be public.

Also fix a few instances where the OpenTelemetry group call tried to
report metrics using a tracer which didn't exist anymore, if the user
disabled analytics and then joined the same call again.
 2023-04-05 13:06:55 +01:00
David Baker
b061cbfb2f Remove the other listeners 2023-04-05 10:01:58 +01:00
David Baker
23ddd73f4f Merge remote-tracking branch 'origin/main' into dbkr/otel_peerconn_events 2023-04-05 09:35:43 +01:00
Enrico Schwendig
390442a4c3
Add webrtc metric to OTel (#974) 
* stats: Add summery report

---------

Co-authored-by: David Baker <dave@matrix.org>
 2023-04-05 10:25:26 +02:00
David Baker
c824ea6f9a Add OpenTelemetry events for PeerConnection state changes / errors 
Creates a new class to represent individual calls and adds the listeners
there.

Requires https://github.com/matrix-org/matrix-js-sdk/pull/3251
Based on https://github.com/vector-im/element-call/pull/974
 2023-04-04 18:00:45 +01:00
David Baker
28196a2e9d
Merge pull request #981 from vector-im/dbkr/call_events_to_call_span 
Move call events to the call span
 2023-04-04 17:52:41 +01:00
David Baker
5b70def4d2 Add null check for call span 2023-04-04 17:49:49 +01:00
David Baker
2cd549cdc8
Merge pull request #982 from vector-im/dbkr/otel_flatten_include_booleans 
Include booleans in flattened OpenTelemetry object
 2023-04-04 17:26:20 +01:00
Robin
e0089a0aee
Merge pull request #958 from robintown/forced-opt-in 
Opt into analytics by default during the beta
 2023-04-04 09:27:01 -04:00
Robin
61a0534984
Merge pull request #983 from robintown/rejoin-analytics 
Track call rejoins
 2023-04-04 09:18:40 -04:00
Robin Townsend
a52251befa Track call rejoins 
Call rejoins will be one of the KPIs we track in PostHog to measure call quality. I've also reverted the previous behavior which logged all OpenTelemetry spans to PostHog, since we should only be sending small, anonymized bits of data there.
 2023-04-03 21:05:13 -04:00
David Baker
30f75c6cd2 Don't pass null / undefined as attribute value 2023-04-03 17:41:40 +01:00
David Baker
8fa23b7da9 Include booleans in flattened OpenTelemetry object 2023-04-03 16:58:29 +01:00
David Baker
277081ee2a Move call events to the call span 2023-04-03 14:35:04 +01:00
David Baker
3a7983d2de Add displayname on call spans 2023-04-03 14:31:17 +01:00
Enrico Schwendig
3b06258e40 stats: rename enum to avoid shadow values 2023-04-03 14:07:29 +02:00
Enrico Schwendig
889a31489b stats: fix typo 2023-04-03 12:37:55 +02:00
Enrico Schwendig
dd67a45671 stats: Add summery report 2023-03-31 14:57:56 +02:00
Enrico Schwendig
707272bf19 Merge branch 'dbkr/otel' into enricoschw/real-time-media-statistics-for-full-mesh 2023-03-31 13:14:49 +02:00
David Baker
dc725f90a9 Fix confusing comment 2023-03-31 11:12:10 +01:00
David Baker
a1aca7bdf2 Fix lying comment 2023-03-31 11:10:05 +01:00
David Baker
5e6c33b3b5 Let otel know we're joining before trying to join 
Otherwise it starts getting calls being created before the group call
span exists and we get call spans not associated with the group call
span.

(What 74b218af8c should have been)
 2023-03-31 10:30:01 +01:00
David Baker
c2b78d59c6 Add more events: 
* VoIP events received
 * Call errors
 * Group call errors
 * Undecryptable to-device events
 2023-03-30 16:54:10 +01:00
David Baker
21458c8840 Call the same leave method everywhere 
So we end the group call span whenever we leasve the call, including
if we close the page.
 2023-03-30 13:03:58 +01:00
David Baker
f96ce8985d Only enable otel if we have a collector URL 2023-03-29 16:04:11 +01:00
David Baker
4bf1fbfd8e Gah, the sentry logger 2023-03-29 13:31:47 +01:00
David Baker
34a72679a1 Merge remote-tracking branch 'origin/main' into dbkr/otel 2023-03-29 12:30:41 +01:00
David Baker
77c6357b08 Use js-sdk from hangup refactor branch 
https://github.com/matrix-org/matrix-js-sdk/pull/3234
 2023-03-29 12:28:04 +01:00
Enrico Schwendig
66c3d05ae9 docu: Add webrtc metric to OTel 2023-03-28 11:51:15 +02:00
Robin Townsend
c4f029ae4f Fix lint error 2023-03-27 22:30:12 -04:00
Robin Townsend
5f41f9476b Disable the opt in analytics setting if Posthog isn't configured 2023-03-23 13:07:34 -04:00
Robin Townsend
313ebe258e Add end-to-end audio observability 
This reports via OpenTelemetry when particular participants are speaking, as an easy way to observe the delivery of audio in calls.
 2023-03-22 14:23:26 -04:00
Robin Townsend
76c0277301 Update matrix-js-sdk 2023-03-22 11:41:41 -04:00
David Baker
48493a96e1 Wait until config is loaded to load otel 2023-03-22 12:41:33 +00:00
David Baker
9c0adfd32e Unused import 2023-03-22 12:00:34 +00:00
David Baker
f6fb65be49 Remove odd source mapping comment & unused commented code 2023-03-22 11:58:41 +00:00
David Baker
3d6ae3fbc3 Enable/disable opentelemetry based on config/user preference 
Add config to set collector URL, obey the same analytics setting as
posthog. Also refactor into a class to make it easier to manage.
 2023-03-22 11:55:21 +00:00
David Baker
359e055314 Make callMembershipSpan optional 2023-03-21 12:13:51 +00:00
David Baker
9b02d17224 Merge branch 'main' into dbkr/otel 2023-03-20 19:20:13 +00:00
David Baker
6b36604c84 Update js-sdk 2023-03-20 19:17:50 +00:00
David Baker
e7a7cf3eb8 Export events to posthog too 2023-03-20 13:30:21 +00:00
David Baker
63ede0b51a Version using events for call joins / leaves and matrix events 
This is probably conceptually nicer although isn't quite as nice in
the jaeger / stalk UI.

Also this may no loger work with the posthog exporter (unsure what it
will do with events on spans).
 2023-03-17 19:26:23 +00:00
David Baker
2d91b43a7d Set attributes on the root span 
Setting them on the context doesn't actually make them show up in
jaeger, it's just a way to propagate the info around between
different things.
 2023-03-17 19:03:43 +00:00
David Baker
f8f5d2011d Add CORS to jaeger query endpoint and make spans nested 
Adds an nginx in front of the query endpoint so we can use stalk
without faffing with browser extension to bypass CORS.

Also make the spans correctly have the call membership span as parent,
which they didn't because we hadn't set the span at the point we made
the context.
 2023-03-17 17:01:59 +00:00
alariej
1bf1813a77 Fix for Android WebView, which does not support navigator.mediaSession 2023-03-17 17:20:16 +01:00
David Baker
521b0a857a Send spans for state events 2023-03-16 18:08:28 +00:00
David Baker
31450219c8 More work on opentelemetry event reporting 
Moastly a re-org to avoid new contexts over React component unmounts/
remounts.
 2023-03-16 14:41:55 +00:00
David Baker
c519e13885 Version that does at least send some traces 2023-03-15 16:00:39 +00:00
David Baker
0cca5ae174 Slightly evolved but not-yet-working OpenTelemetry 
More usefully, including docker config for starting a CORS enabled
OTLP collector so we don't have to use zipkin.
 2023-03-15 14:35:10 +00:00
Robin Townsend
971eca59ff Opt into analytics by default during the beta 2023-03-13 19:12:47 -04:00
Timo K
4c59638d00 otel for call start, end and mute 
This is send over zipkin.
And it uses a posthog exporter to export events to posthog
using a _otel prefix
 2023-03-10 10:33:54 +01:00
Robin
5eb552e36a
Merge pull request #935 from alariej/alariej 
Add e2eEnabled parameter to Widget client
 2023-03-02 16:07:04 -05:00
Enrico Schwendig
29e41c7227
Allow Element Call to be started without audio / video interface (#924) 
* config: add feature in `config.json`

* groupCall: adjust connection state in feed if allowCallWithoutVideoAndAudio

* matrix-js-sdk: update version for allowCallWithoutVideoAndAudio

- I modified the SDK so that mute unmute work without media and check device permission inside the SDK
- allowCallWithoutVideoAndAudio is only checked at one point outside the SDK

* docu: add join group call without media docu in READMe

---------

Co-authored-by: Robin Townsend <robin@robin.town>
Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
 2023-03-02 18:48:32 +01:00
alariej
58d87db55f Add e2eEnabled parameter to Widget client 2023-03-01 14:30:25 +01:00
Timo
0423a494c4
Checkbox for analytics opt in & settings redesign (#934) 2023-03-01 13:47:36 +01:00
David Baker
64703fd3cc
Typo 
Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
 2023-02-28 14:09:52 +00:00
David Baker
53bc8eb82f Behave sensibly if a full room alias is entered 
Check explicitly to see if the room name that's enetered into the box
looks like a room alias and if so, do the sensible thing.

Fixes https://github.com/vector-im/element-call/issues/852
 2023-02-28 13:50:24 +00:00
Robin Townsend
1fc181dc28 Document useReactiveState 2023-02-15 16:38:49 -05:00
Robin Townsend
fbc72283d4 Add missing copyright headers 2023-02-15 16:20:58 -05:00
Robin Townsend
efbf319fa1 Explain why we cast the tile springs 2023-02-13 22:40:26 -05:00
Robin Townsend
ef4a62ca62 Document useMergedRefs 2023-02-13 22:38:27 -05:00
Robin Townsend
58ed372afa Fix type and lint errors 2023-02-13 21:57:57 -05:00
Robin Townsend
69e6ba93c1 Add a switch to toggle between the new and old grids 2023-02-13 20:36:42 -05:00
Robin Townsend
b2b2f0bb15 Merge branch 'main' into big-grid 2023-02-13 18:54:19 -05:00
Robin Townsend
5448744871 Document grid operations 2023-02-13 18:35:23 -05:00
David Baker
605dd44df0 Rename other instance of variable 2023-02-13 15:49:58 +00:00
David Baker
07a4de638f Don't pause audio streams on media actions 
This adds handlers for the media actions to do nothing, otherwise
they cause the audio element for a random participant to get paused.

Fixes https://github.com/vector-im/element-call/issues/855
 2023-02-13 15:20:48 +00:00
Abhi Jain
33dd2758d7 change ... to … unicode for consistency 2023-02-13 09:55:32 +05:30