Create refactored method handle_metadata_and_emails

datacenterlight/tasks.py

@@ -56,11 +56,6 @@ def create_vm_task(self, vm_template_id, user, specs, template, order_id):
         "Running create_vm_task on {}".format(current_task.request.hostname))
     vm_id = None
     try:
-        final_price = (
-            specs.get('total_price') if 'total_price' in specs
-            else specs.get('price')
-        )
-
         if 'pass' in user:
             on_user = user.get('username')
             on_pass = user.get('pass')
@@ -92,6 +87,52 @@ def create_vm_task(self, vm_template_id, user, specs, template, order_id):
         if vm_id is None:
             raise Exception("Could not create VM")
 
+        handle_metadata_and_emails(order_id, vm_id, manager, user, specs,
+                                   template)
+    except Exception as e:
+        logger.error(str(e))
+        try:
+            retry_task(self)
+        except MaxRetriesExceededError:
+            msg_text = 'Finished {} retries for create_vm_task'.format(
+                self.request.retries)
+            logger.error(msg_text)
+            # Try sending email and stop
+            email_data = {
+                'subject': '{} CELERY TASK ERROR: {}'.format(settings.DCL_TEXT,
+                                                             msg_text),
+                'from_email': current_task.request.hostname,
+                'to': settings.DCL_ERROR_EMAILS_TO_LIST,
+                'body': ',\n'.join(str(i) for i in self.request.args)
+            }
+            email = EmailMessage(**email_data)
+            email.send()
+            return
+
+    return vm_id
+
+
+def handle_metadata_and_emails(order_id, vm_id, manager, user, specs,
+                               template):
+    """
+    Handle's setting up of the metadata in Stripe and database and sending of
+    emails to the user after VM creation
+
+    :param order_id: the hosting order id
+    :param vm_id: the id of the vm created
+    :param manager: the OpenNebula Manager instance
+    :param user: the user's dict passed to the celery task
+    :param specs: the specification's dict passed to the celery task
+    :param template: the template dict passed to the celery task
+
+    :return:
+    """
+
+    custom_user = CustomUser.objects.get(email=user.get('email'))
+    final_price = (
+        specs.get('total_price') if 'total_price' in specs
+        else specs.get('price')
+    )
     # Update HostingOrder with the created vm_id
     hosting_order = HostingOrder.objects.filter(id=order_id).first()
     error_msg = None
@@ -193,24 +234,3 @@ def create_vm_task(self, vm_template_id, user, specs, template, order_id):
         logger.debug("New VM ID is {vm_id}".format(vm_id=vm_id))
         if vm_id > 0:
             get_or_create_vm_detail(custom_user, manager, vm_id)
-    except Exception as e:
-        logger.error(str(e))
-        try:
-            retry_task(self)
-        except MaxRetriesExceededError:
-            msg_text = 'Finished {} retries for create_vm_task'.format(
-                self.request.retries)
-            logger.error(msg_text)
-            # Try sending email and stop
-            email_data = {
-                'subject': '{} CELERY TASK ERROR: {}'.format(settings.DCL_TEXT,
-                                                             msg_text),
-                'from_email': current_task.request.hostname,
-                'to': settings.DCL_ERROR_EMAILS_TO_LIST,
-                'body': ',\n'.join(str(i) for i in self.request.args)
-            }
-            email = EmailMessage(**email_data)
-            email.send()
-            return
-
-    return vm_id