rename Type => CdistType
Signed-off-by: Nico Schottelius <nico@brief.schottelius.org>
This commit is contained in:
		
					parent
					
						
							
								1314567012
							
						
					
				
			
			
				commit
				
					
						fb4f8784b6
					
				
			
		
					 7 changed files with 50 additions and 48 deletions
				
			
		| 
						 | 
				
			
			@ -61,7 +61,7 @@ class CdistObject(object):
 | 
			
		|||
        """Return a list of object instances"""
 | 
			
		||||
        for object_name in cls.list_object_names(object_base_path):
 | 
			
		||||
            type_name, object_id = cls.split_name(object_name)
 | 
			
		||||
            yield cls(cdist.core.Type(type_base_path, type_name), object_base_path, object_id=object_id)
 | 
			
		||||
            yield cls(cdist.core.CdistType(type_base_path, type_name), object_base_path, object_id=object_id)
 | 
			
		||||
 | 
			
		||||
    @classmethod
 | 
			
		||||
    def list_type_names(cls, object_base_path):
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -48,13 +48,13 @@ class CodeTestCase(test.CdistTestCase):
 | 
			
		|||
 | 
			
		||||
        self.remote_base_path = self.mkdtemp()
 | 
			
		||||
        self.user = getpass.getuser()
 | 
			
		||||
        remote_exec = "ssh -o User=%s -q" % self.user
 | 
			
		||||
        remote_copy = "scp -o User=%s -q" % self.user
 | 
			
		||||
        remote_exec = "ssh -o User=%s -q" % "root" # self.user
 | 
			
		||||
        remote_copy = "scp -o User=%s -q" % "root" # self.user
 | 
			
		||||
        self.remote = remote.Remote(self.target_host, self.remote_base_path, remote_exec, remote_copy)
 | 
			
		||||
 | 
			
		||||
        self.code = code.Code(self.target_host, self.local, self.remote)
 | 
			
		||||
 | 
			
		||||
        self.cdist_type = core.Type(self.local.type_path, '__dump_environment')
 | 
			
		||||
        self.cdist_type = core.CdistType(self.local.type_path, '__dump_environment')
 | 
			
		||||
        self.cdist_object = core.CdistObject(self.cdist_type, self.local.object_path, 'whatever')
 | 
			
		||||
        self.cdist_object.create()
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -119,7 +119,7 @@ class AutoRequireEmulatorTestCase(test.CdistTestCase):
 | 
			
		|||
    def test_autorequire(self):
 | 
			
		||||
        initial_manifest = os.path.join(self.local.manifest_path, "init")
 | 
			
		||||
        self.manifest.run_initial_manifest(initial_manifest)
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__saturn')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__saturn')
 | 
			
		||||
        cdist_object = core.CdistObject(cdist_type, self.local.object_path, 'singleton')
 | 
			
		||||
        self.manifest.run_type_manifest(cdist_object)
 | 
			
		||||
        expected = ['__planet/Saturn', '__moon/Prometheus']
 | 
			
		||||
| 
						 | 
				
			
			@ -156,6 +156,6 @@ class ArgumentsWithDashesTestCase(test.CdistTestCase):
 | 
			
		|||
        emu = emulator.Emulator(argv)
 | 
			
		||||
        emu.run()
 | 
			
		||||
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__arguments_with_dashes')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__arguments_with_dashes')
 | 
			
		||||
        cdist_object = core.CdistObject(cdist_type, self.local.object_path, 'some-id')
 | 
			
		||||
        self.assertTrue('with-dash' in cdist_object.parameters)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -49,8 +49,10 @@ class ExplorerClassTestCase(test.CdistTestCase):
 | 
			
		|||
 | 
			
		||||
        self.remote_base_path = self.mkdtemp()
 | 
			
		||||
        self.user = getpass.getuser()
 | 
			
		||||
        remote_exec = "ssh -o User=%s -q" % self.user
 | 
			
		||||
        remote_copy = "scp -o User=%s -q" % self.user
 | 
			
		||||
        #remote_exec = "ssh -o User=%s -q" % self.user
 | 
			
		||||
        #remote_copy = "scp -o User=%s -q" % self.user
 | 
			
		||||
        remote_exec = "ssh -o User=%s -q" % "root"
 | 
			
		||||
        remote_copy = "scp -o User=%s -q" % "root"
 | 
			
		||||
        self.remote = remote.Remote(self.target_host, self.remote_base_path, remote_exec, remote_copy)
 | 
			
		||||
 | 
			
		||||
        self.explorer = explorer.Explorer(self.target_host, self.local, self.remote)
 | 
			
		||||
| 
						 | 
				
			
			@ -83,19 +85,19 @@ class ExplorerClassTestCase(test.CdistTestCase):
 | 
			
		|||
        shutil.rmtree(out_path)
 | 
			
		||||
 | 
			
		||||
    def test_list_type_explorer_names(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__test_type')
 | 
			
		||||
        expected = cdist_type.explorers
 | 
			
		||||
        self.assertEqual(self.explorer.list_type_explorer_names(cdist_type), expected)
 | 
			
		||||
 | 
			
		||||
    def test_transfer_type_explorers(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__test_type')
 | 
			
		||||
        self.explorer.transfer_type_explorers(cdist_type)
 | 
			
		||||
        source = os.path.join(self.local.type_path, cdist_type.explorer_path)
 | 
			
		||||
        destination = os.path.join(self.remote.type_path, cdist_type.explorer_path)
 | 
			
		||||
        self.assertEqual(os.listdir(source), os.listdir(destination))
 | 
			
		||||
 | 
			
		||||
    def test_transfer_type_explorers_only_once(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__test_type')
 | 
			
		||||
        # first transfer
 | 
			
		||||
        self.explorer.transfer_type_explorers(cdist_type)
 | 
			
		||||
        source = os.path.join(self.local.type_path, cdist_type.explorer_path)
 | 
			
		||||
| 
						 | 
				
			
			@ -109,7 +111,7 @@ class ExplorerClassTestCase(test.CdistTestCase):
 | 
			
		|||
        self.assertFalse(os.listdir(destination))
 | 
			
		||||
 | 
			
		||||
    def test_transfer_object_parameters(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_object = core.CdistObject(cdist_type, self.local.object_path, 'whatever')
 | 
			
		||||
        cdist_object.create()
 | 
			
		||||
        cdist_object.parameters = {'first': 'first value', 'second': 'second value'}
 | 
			
		||||
| 
						 | 
				
			
			@ -119,14 +121,14 @@ class ExplorerClassTestCase(test.CdistTestCase):
 | 
			
		|||
        self.assertEqual(sorted(os.listdir(source)), sorted(os.listdir(destination)))
 | 
			
		||||
 | 
			
		||||
    def test_run_type_explorer(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_object = core.CdistObject(cdist_type, self.local.object_path, 'whatever')
 | 
			
		||||
        self.explorer.transfer_type_explorers(cdist_type)
 | 
			
		||||
        output = self.explorer.run_type_explorer('world', cdist_object)
 | 
			
		||||
        self.assertEqual(output, 'hello\n')
 | 
			
		||||
 | 
			
		||||
    def test_run_type_explorers(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__test_type')
 | 
			
		||||
        cdist_object = core.CdistObject(cdist_type, self.local.object_path, 'whatever')
 | 
			
		||||
        cdist_object.create()
 | 
			
		||||
        self.explorer.run_type_explorers(cdist_object)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -79,7 +79,7 @@ class ManifestTestCase(test.CdistTestCase):
 | 
			
		|||
        self.assertEqual(output_dict['__manifest'], self.local.manifest_path)
 | 
			
		||||
 | 
			
		||||
    def test_type_manifest_environment(self):
 | 
			
		||||
        cdist_type = core.Type(self.local.type_path, '__dump_environment')
 | 
			
		||||
        cdist_type = core.CdistType(self.local.type_path, '__dump_environment')
 | 
			
		||||
        cdist_object = core.CdistObject(cdist_type, self.local.object_path, 'whatever')
 | 
			
		||||
        handle, output_file = self.mkstemp(dir=self.temp_dir)
 | 
			
		||||
        os.close(handle)
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -44,28 +44,28 @@ class ObjectClassTestCase(test.CdistTestCase):
 | 
			
		|||
    def test_list_objects(self):
 | 
			
		||||
        objects = list(core.CdistObject.list_objects(object_base_path, type_base_path))
 | 
			
		||||
        objects_expected = [
 | 
			
		||||
            core.CdistObject(core.Type(type_base_path, '__first'), object_base_path, 'man'),
 | 
			
		||||
            core.CdistObject(core.Type(type_base_path, '__second'), object_base_path, 'on-the'),
 | 
			
		||||
            core.CdistObject(core.Type(type_base_path, '__third'), object_base_path, 'moon'),
 | 
			
		||||
            core.CdistObject(core.CdistType(type_base_path, '__first'), object_base_path, 'man'),
 | 
			
		||||
            core.CdistObject(core.CdistType(type_base_path, '__second'), object_base_path, 'on-the'),
 | 
			
		||||
            core.CdistObject(core.CdistType(type_base_path, '__third'), object_base_path, 'moon'),
 | 
			
		||||
        ]
 | 
			
		||||
        self.assertEqual(objects, objects_expected)
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
class ObjectIdTestCase(test.CdistTestCase):
 | 
			
		||||
    def test_object_id_starts_with_slash(self):
 | 
			
		||||
        cdist_type = core.Type(type_base_path, '__third')
 | 
			
		||||
        cdist_type = core.CdistType(type_base_path, '__third')
 | 
			
		||||
        illegal_object_id = '/object_id/may/not/start/with/slash'
 | 
			
		||||
        with self.assertRaises(core.IllegalObjectIdError):
 | 
			
		||||
            core.CdistObject(cdist_type, object_base_path, illegal_object_id)
 | 
			
		||||
 | 
			
		||||
    def test_object_id_contains_object_marker(self):
 | 
			
		||||
        cdist_type = core.Type(type_base_path, '__third')
 | 
			
		||||
        cdist_type = core.CdistType(type_base_path, '__third')
 | 
			
		||||
        illegal_object_id = 'object_id/may/not/contain/%s/anywhere' % core.OBJECT_MARKER
 | 
			
		||||
        with self.assertRaises(core.IllegalObjectIdError):
 | 
			
		||||
            core.CdistObject(cdist_type, object_base_path, illegal_object_id)
 | 
			
		||||
 | 
			
		||||
    def test_object_id_contains_object_marker_string(self):
 | 
			
		||||
        cdist_type = core.Type(type_base_path, '__third')
 | 
			
		||||
        cdist_type = core.CdistType(type_base_path, '__third')
 | 
			
		||||
        illegal_object_id = 'object_id/may/contain_%s_in_filename' % core.OBJECT_MARKER
 | 
			
		||||
        core.CdistObject(cdist_type, object_base_path, illegal_object_id)
 | 
			
		||||
        # if we get here, the test passed
 | 
			
		||||
| 
						 | 
				
			
			@ -74,7 +74,7 @@ class ObjectIdTestCase(test.CdistTestCase):
 | 
			
		|||
class ObjectTestCase(test.CdistTestCase):
 | 
			
		||||
 | 
			
		||||
    def setUp(self):
 | 
			
		||||
        self.cdist_type = core.Type(type_base_path, '__third')
 | 
			
		||||
        self.cdist_type = core.CdistType(type_base_path, '__third')
 | 
			
		||||
        self.cdist_object = core.CdistObject(self.cdist_type, object_base_path, 'moon') 
 | 
			
		||||
 | 
			
		||||
    def tearDown(self):
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -33,115 +33,115 @@ class TypeTestCase(test.CdistTestCase):
 | 
			
		|||
 | 
			
		||||
    def test_list_type_names(self):
 | 
			
		||||
        base_path = op.join(fixtures, 'list_types')
 | 
			
		||||
        type_names = core.Type.list_type_names(base_path)
 | 
			
		||||
        type_names = core.CdistType.list_type_names(base_path)
 | 
			
		||||
        self.assertEqual(type_names, ['__first', '__second', '__third'])
 | 
			
		||||
 | 
			
		||||
    def test_list_types(self):
 | 
			
		||||
        base_path = op.join(fixtures, 'list_types')
 | 
			
		||||
        types = list(core.Type.list_types(base_path))
 | 
			
		||||
        types = list(core.CdistType.list_types(base_path))
 | 
			
		||||
        types_expected = [
 | 
			
		||||
            core.Type(base_path, '__first'),
 | 
			
		||||
            core.Type(base_path, '__second'),
 | 
			
		||||
            core.Type(base_path, '__third'),
 | 
			
		||||
            core.CdistType(base_path, '__first'),
 | 
			
		||||
            core.CdistType(base_path, '__second'),
 | 
			
		||||
            core.CdistType(base_path, '__third'),
 | 
			
		||||
        ]
 | 
			
		||||
        self.assertEqual(types, types_expected)
 | 
			
		||||
 | 
			
		||||
    def test_only_one_instance(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type1 = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type2 = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type1 = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        cdist_type2 = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(id(cdist_type1), id(cdist_type2))
 | 
			
		||||
 | 
			
		||||
    def test_nonexistent_type(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        self.assertRaises(core.NoSuchTypeError, core.Type, base_path, '__i-dont-exist')
 | 
			
		||||
        self.assertRaises(core.NoSuchTypeError, core.CdistType, base_path, '__i-dont-exist')
 | 
			
		||||
 | 
			
		||||
    def test_name(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.name, '__name_path')
 | 
			
		||||
 | 
			
		||||
    def test_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.path, '__name_path')
 | 
			
		||||
 | 
			
		||||
    def test_base_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.base_path, base_path)
 | 
			
		||||
 | 
			
		||||
    def test_absolute_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.absolute_path, os.path.join(base_path, '__name_path'))
 | 
			
		||||
 | 
			
		||||
    def test_manifest_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.manifest_path, os.path.join('__name_path', 'manifest'))
 | 
			
		||||
 | 
			
		||||
    def test_explorer_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.explorer_path, os.path.join('__name_path', 'explorer'))
 | 
			
		||||
 | 
			
		||||
    def test_gencode_local_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.gencode_local_path, os.path.join('__name_path', 'gencode-local'))
 | 
			
		||||
 | 
			
		||||
    def test_gencode_remote_path(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__name_path')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__name_path')
 | 
			
		||||
        self.assertEqual(cdist_type.gencode_remote_path, os.path.join('__name_path', 'gencode-remote'))
 | 
			
		||||
 | 
			
		||||
    def test_singleton_is_singleton(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__singleton')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__singleton')
 | 
			
		||||
        self.assertTrue(cdist_type.is_singleton)
 | 
			
		||||
 | 
			
		||||
    def test_not_singleton_is_singleton(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__not_singleton')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__not_singleton')
 | 
			
		||||
        self.assertFalse(cdist_type.is_singleton)
 | 
			
		||||
 | 
			
		||||
    def test_install_is_install(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__install')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__install')
 | 
			
		||||
        self.assertTrue(cdist_type.is_install)
 | 
			
		||||
 | 
			
		||||
    def test_not_install_is_install(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__not_install')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__not_install')
 | 
			
		||||
        self.assertFalse(cdist_type.is_install)
 | 
			
		||||
 | 
			
		||||
    def test_with_explorers(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__with_explorers')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__with_explorers')
 | 
			
		||||
        self.assertEqual(cdist_type.explorers, ['whatever'])
 | 
			
		||||
 | 
			
		||||
    def test_without_explorers(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__without_explorers')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__without_explorers')
 | 
			
		||||
        self.assertEqual(cdist_type.explorers, [])
 | 
			
		||||
 | 
			
		||||
    def test_with_required_parameters(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__with_required_parameters')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__with_required_parameters')
 | 
			
		||||
        self.assertEqual(cdist_type.required_parameters, ['required1', 'required2'])
 | 
			
		||||
 | 
			
		||||
    def test_without_required_parameters(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__without_required_parameters')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__without_required_parameters')
 | 
			
		||||
        self.assertEqual(cdist_type.required_parameters, [])
 | 
			
		||||
 | 
			
		||||
    def test_with_optional_parameters(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__with_optional_parameters')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__with_optional_parameters')
 | 
			
		||||
        self.assertEqual(cdist_type.optional_parameters, ['optional1', 'optional2'])
 | 
			
		||||
 | 
			
		||||
    def test_without_optional_parameters(self):
 | 
			
		||||
        base_path = fixtures
 | 
			
		||||
        cdist_type = core.Type(base_path, '__without_optional_parameters')
 | 
			
		||||
        cdist_type = core.CdistType(base_path, '__without_optional_parameters')
 | 
			
		||||
        self.assertEqual(cdist_type.optional_parameters, [])
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue