mark/cdist
1
0
Fork 0
forked from ungleich-public/cdist
Code Issues Pull requests Projects Releases Wiki Activity
6137 commits 112 branches 178 tags 19 MiB
Commit graph

6137 commits

This branch
This branch
All branches
Author SHA1 Message Date
Darko Poljak
0d80b4473b Disable SC2031 for the single incident. 2018-10-05 15:04:22 +02:00
Darko Poljak
9a61aab631 ++ 2018-10-05 14:59:35 +02:00
Darko Poljak
88d4c8a059
Merge pull request #709 from darko-poljak/SC2044 
Fix SC2044.
 2018-10-05 14:58:50 +02:00
Darko Poljak
bf270b6f9c Fix SC2044. 2018-10-05 13:05:01 +02:00
Darko Poljak
a369acea72 Fix SC2021. 2018-10-05 12:52:44 +02:00
Darko Poljak
644ec85d80 Fix SC2162. 2018-10-05 12:50:01 +02:00
Darko Poljak
16159d8fca Fix SC2145. 2018-10-05 12:32:56 +02:00
Darko Poljak
596f3cf227 Disable SC2119,SC2120 where appropriate. 2018-10-05 12:31:05 +02:00
Darko Poljak
9b567ed8f7 Fix SC2230. 2018-10-05 12:27:43 +02:00
Darko Poljak
8cea8e67aa Disable SC2031 where appropriate. 2018-10-05 12:25:40 +02:00
Darko Poljak
b120a813a2 Disable SC2030 where appropriate. 2018-10-05 12:24:03 +02:00
Darko Poljak
7b17ad4733 Fix SC2143. 2018-10-05 12:21:59 +02:00
Darko Poljak
e46420e7f5 Fix SC1090. 2018-10-05 12:19:16 +02:00
Darko Poljak
2f7b8e6db9 Fix SC2153. 2018-10-05 12:16:27 +02:00
Darko Poljak
73d0a5bbbe Fix SC2235. 2018-10-05 12:14:51 +02:00
Darko Poljak
73acb35a8a Fix SC2196. 2018-10-05 12:04:45 +02:00
Darko Poljak
28889ef38a Disable SC2028 where intended. 2018-10-05 12:02:10 +02:00
Darko Poljak
ed542cc7cb Fix SC2046. 2018-10-05 11:57:31 +02:00
Darko Poljak
b25aff17c6 Disable SC2039 where appropriate. 2018-10-05 11:49:28 +02:00
Darko Poljak
a601fa91d9 Fix SC2116. 2018-10-05 11:34:10 +02:00
Darko Poljak
5f8c631e34 ++changelog 2018-10-05 11:26:47 +02:00
Darko Poljak
678ce2bfaa
Merge pull request #707 from darko-poljak/SC2016 
Disable SC2016 check.
 2018-10-05 11:26:01 +02:00
Darko Poljak
3b6d759660 Disable SC2016 check. 2018-10-05 10:32:38 +02:00
Darko Poljak
d2f1d6185d ++changelog 2018-10-05 10:29:47 +02:00
Darko Poljak
0cb127822f
Merge pull request #706 from darko-poljak/SC2164 
Fix SC2164
 2018-10-05 10:28:04 +02:00
Darko Poljak
49bb041330
Merge pull request #696 from thriqon/shellcheck-party-SC2086 
Fix SC2086 on all scripts
 2018-10-05 10:26:53 +02:00
Darko Poljak
c01cf38660 Fix SC2164 2018-10-04 23:10:42 +02:00
Darko Poljak
738f053877 ++changelog 2018-10-04 22:39:06 +02:00
Darko Poljak
68b6477fe3
Merge pull request #705 from thriqon/shellcheck-party-various 
Fix various shellcheck issues (SC2215, SC2059, SC2155, SC2091)
 2018-10-04 22:39:05 +02:00
Darko Poljak
f0fb5215e8
Merge pull request #700 from thriqon/shellcheck-party-SC2034 
Remove unused variables (SC2034)
 2018-10-04 22:35:08 +02:00
Darko Poljak
3ead8b266a
Merge pull request #704 from thriqon/shellcheck-party-SC2069 
Fix SC2069 (wrong stdout/stderr redirect order)
 2018-10-04 22:33:11 +02:00
Jonas Weber
34b571b7d9 Fix SC2091 (execute result of condition) 
For some reason, the echo|grep pattern was enclosed four times in a $()
operation. Nothing happened, since grep is always invoked with -q
(quiet, nothing printed to stdout).
 2018-10-04 22:23:48 +02:00
Jonas Weber
bcd7fbbcc4 Fix SC2155 (directly export computed variables) 2018-10-04 22:23:48 +02:00
Jonas Weber
a0db375f91 Disable SC2059 (printf injection) for staged_file 
We're explicitly allowing for 'printf injection' here, so it's ok to
just disable the corresponding shellcheck check.
 2018-10-04 22:23:38 +02:00
Jonas Weber
a6fdf4255a Fix SC2069 (wrong stdout/stderr redirect order) 
In the original order, stderr was connected to the old stdout
(terminal). This was _probably_ not intended. The new order fixes this
by first connecting stdout to /dev/null and then attaching stderr to
that as well.
 2018-10-04 22:04:24 +02:00
Jonas Weber
e2593c0dcb Fix SC2215 (missing brackets on if) 
This might have never worked as intended, but how would you know?
 2018-10-04 22:03:52 +02:00
Jonas Weber
fff656d1ac Unquote $recursive to support empty-case 
This is safe to do, as the value of $recursive is not dependent on
user-supplied code.
 2018-10-04 19:45:26 +02:00
Jonas Weber
53728a7ff0 Change backslash-dquote to single quote 
Slightly breaking change, but improves security and readability.
 2018-10-04 19:45:26 +02:00
Jonas Weber
ae7ccc5995 Fix SC2086 on all scripts 
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086

relates to: #540

This commit addresses 241 separate cases of missing quotes around
variables.
 2018-10-04 19:45:22 +02:00
Jonas Weber
23debd5b6f Use cur_ip in jail for freebsd 2018-10-04 19:22:28 +02:00
Jonas Weber
352679386d Drop unused options parameter in __install_reboot 2018-10-04 19:22:28 +02:00
Jonas Weber
b3f4d3849a Fix __install_umount target parameter 2018-10-04 19:22:28 +02:00
Jonas Weber
6b0f8fba22 Remove unused variables (almost, found bugs?) 
Solves SC2034

references #540.
 2018-10-04 19:22:28 +02:00
Darko Poljak
ef8ec8641e ++ 2018-10-04 18:47:28 +02:00
Darko Poljak
a2ed14b6d0
Merge pull request #701 from tom-ee/fix-SC2148 
fix SC2148 (missing shebang) and make executable
 2018-10-04 18:46:38 +02:00
Thomas Eckert
085b2a2b10 remove set -e on explorers (they should be able to fail gracefully) 2018-10-04 17:38:39 +02:00
Thomas Eckert
a46da35bbc fix SC2148 (missing shebang) and make executable 2018-10-04 17:38:38 +02:00
Darko Poljak
d49d38481f ++changelog 2018-10-04 17:31:37 +02:00
Darko Poljak
66ca2fcb70
Merge pull request #703 from tom-ee/fix-SC2045 
fix SC2045 (use globs instead of `ls`)
 2018-10-04 17:31:34 +02:00
Thomas Eckert
d950ddada3 fix SC2045 (use globs instead of ls) 2018-10-04 16:01:45 +02:00