Commit graph

6700 commits

Author SHA1 Message Date
Jonas Weber
53728a7ff0 Change backslash-dquote to single quote
Slightly breaking change, but improves security and readability.
2018-10-04 19:45:26 +02:00
Jonas Weber
ae7ccc5995 Fix SC2086 on all scripts
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086

relates to: #540

This commit addresses 241 separate cases of missing quotes around
variables.
2018-10-04 19:45:22 +02:00
Jonas Weber
23debd5b6f Use cur_ip in jail for freebsd 2018-10-04 19:22:28 +02:00
Jonas Weber
352679386d Drop unused options parameter in __install_reboot 2018-10-04 19:22:28 +02:00
Jonas Weber
b3f4d3849a Fix __install_umount target parameter 2018-10-04 19:22:28 +02:00
Jonas Weber
6b0f8fba22 Remove unused variables (almost, found bugs?)
Solves SC2034

references #540.
2018-10-04 19:22:28 +02:00
Darko Poljak
ef8ec8641e ++ 2018-10-04 18:47:28 +02:00
Darko Poljak
a2ed14b6d0
Merge pull request #701 from tom-ee/fix-SC2148
fix SC2148 (missing shebang) and make executable
2018-10-04 18:46:38 +02:00
085b2a2b10 remove set -e on explorers (they should be able to fail gracefully) 2018-10-04 17:38:39 +02:00
a46da35bbc fix SC2148 (missing shebang) and make executable 2018-10-04 17:38:38 +02:00
Darko Poljak
d49d38481f ++changelog 2018-10-04 17:31:37 +02:00
Darko Poljak
66ca2fcb70
Merge pull request #703 from tom-ee/fix-SC2045
fix SC2045 (use globs instead of `ls`)
2018-10-04 17:31:34 +02:00
d950ddada3 fix SC2045 (use globs instead of ls) 2018-10-04 16:01:45 +02:00
Darko Poljak
31bf6ab230 ++changelog 2018-10-04 12:38:40 +02:00
Darko Poljak
b62b41b263
Merge pull request #702 from tom-ee/fix-SC2166-global-explorer
fix another SC2166 (test `[ .. -a.. ]` replaced by `[ .. ] && ]`)
2018-10-04 12:38:09 +02:00
134c84607f fix another SC2166 (test [ .. -a.. ] replaced by [ .. ] && ]) 2018-10-04 12:28:59 +02:00
Darko Poljak
ab9e2264df ++changelog 2018-10-04 09:10:31 +02:00
Darko Poljak
e1b62ec560
Merge pull request #699 from darko-poljak/SC2039
Fix SC2039
2018-10-04 09:08:23 +02:00
Darko Poljak
383af6736f ++changelog 2018-10-03 14:52:17 +02:00
Darko Poljak
4403392869
Merge pull request #698 from darko-poljak/SC2002
Fix SC2002
2018-10-03 14:51:12 +02:00
Darko Poljak
8ef2773c0d Fix SC2039 2018-10-03 14:32:39 +02:00
Darko Poljak
44acfcdd12 Fix SC2002 2018-10-03 14:12:07 +02:00
Darko Poljak
3757e8c2c5 ++changelog 2018-10-02 21:50:17 +02:00
Darko Poljak
e69be05f70
Merge pull request #694 from darko-poljak/SC2005
Fix SC2005
2018-10-02 21:49:45 +02:00
Darko Poljak
d29534861b
Merge pull request #695 from darko-poljak/SC2004
Fix SC2004
2018-10-02 21:49:01 +02:00
Darko Poljak
0928708d19 Fix SC2004 2018-10-02 20:34:54 +02:00
Darko Poljak
5ed95ce93b Fix SC2005 2018-10-02 20:22:44 +02:00
Darko Poljak
aef14ad39e ++changelog 2018-10-02 17:21:24 +02:00
Darko Poljak
f1369820d0
Merge pull request #693 from thriqon/shellcheck-party-SC2166
Fix SC2166 (and/or operators in test) on all manfest/gencode/explorers
2018-10-02 17:19:21 +02:00
Jonas Weber
6326eae1bb Fix SC2166 on all manfest/gencode/explorers 2018-10-01 22:13:24 +02:00
Darko Poljak
e551348cd7 Create man7 directory if needed. 2018-09-29 11:15:48 +02:00
Darko Poljak
9cb9771e33 Exclude man7 empty directory from archive. 2018-09-29 11:15:29 +02:00
Darko Poljak
f705fe8fc6
Merge pull request #692 from darko-poljak/log-timestamping-config
Add timestamping log option to config file.
2018-09-28 14:22:59 +02:00
Darko Poljak
82077aff25 Add timestamping log option to config file. 2018-09-27 18:55:33 +02:00
Darko Poljak
e404ff4836 ++changelog 2018-09-26 20:35:32 +02:00
Darko Poljak
1e34fc20be
Merge pull request #691 from darko-poljak/log-timestamping
Add timestamp to log messages.
2018-09-26 20:35:14 +02:00
Darko Poljak
c04325fdc5 ++changelog 2018-09-23 22:26:16 +02:00
Darko Poljak
4b9994f134
Merge pull request #690 from myeisha/batch-scp
transfer all files of a directory at once
2018-09-23 22:22:57 +02:00
Darko Poljak
0c57b3083e Fix getting loggers. 2018-09-23 21:38:03 +02:00
Darko Poljak
6acf6f64dc Add timestamp to log messages. 2018-09-23 20:36:57 +02:00
Darko Poljak
02982ca8be Release 4.10.3 2018-09-23 12:04:57 +02:00
Darko Poljak
1f703ab42e ++changelog 2018-09-22 20:52:43 +02:00
Darko Poljak
9b6ed0adc7
Merge pull request #689 from myeisha/deduplicate-mkdir
don't duplicate Remote::mkdir in explorer transfer
2018-09-22 20:52:33 +02:00
dhivael
c021cd15cd transfer all files of a directory at once
instead of calling the copy command once per file in a directory (eg a
type explorer dir), call the copy command only once with all files of
the directory.

batch copy saves 20% of dry-run time on my test manifest in sequential
mode, and 15% in parallel mode.
2018-09-22 17:35:32 +02:00
dhivael
f918acd725 don't duplicate Remote::mkdir in explorer transfer
Remote::transfer contains a call to mkdir(destination) if the source is
a directory. since the destination must also be a directory we can omit
extra mkdir calls in Explorer.

this saves about 10% on my manifests in sequential mode, and about 6% in
parallel mode.
2018-09-22 13:16:22 +02:00
Darko Poljak
d6952543a7 Add 'real world example' walkthrough docs chapter. 2018-09-14 10:53:16 +02:00
Darko Poljak
aa80e8f87d ++changelog 2018-09-12 11:53:46 +02:00
Darko Poljak
690b63081f
Merge pull request #688 from thriqon/improve-package-apt
Improve __package_apt
2018-09-12 11:53:37 +02:00
Jonas Weber
b3f3b907a4 Quote aptget command and params, simplify explorer 2018-09-12 11:36:11 +02:00
Jonas Weber
346f1f8af3 Send messages when installing packages via __package_apt 2018-09-12 11:36:06 +02:00