bf270b6f9c
Fix SC2044.
2018-10-05 13:05:01 +02:00
3b6d759660
Disable SC2016 check.
2018-10-05 10:32:38 +02:00
0cb127822f
Merge pull request #706 from darko-poljak/SC2164
...
Fix SC2164
2018-10-05 10:28:04 +02:00
49bb041330
Merge pull request #696 from thriqon/shellcheck-party-SC2086
...
Fix SC2086 on all scripts
2018-10-05 10:26:53 +02:00
c01cf38660
Fix SC2164
2018-10-04 23:10:42 +02:00
68b6477fe3
Merge pull request #705 from thriqon/shellcheck-party-various
...
Fix various shellcheck issues (SC2215, SC2059, SC2155, SC2091)
2018-10-04 22:39:05 +02:00
34b571b7d9
Fix SC2091 (execute result of condition)
...
For some reason, the echo|grep pattern was enclosed four times in a $()
operation. Nothing happened, since grep is always invoked with -q
(quiet, nothing printed to stdout).
2018-10-04 22:23:48 +02:00
bcd7fbbcc4
Fix SC2155 (directly export computed variables)
2018-10-04 22:23:48 +02:00
a0db375f91
Disable SC2059 (printf injection) for staged_file
...
We're explicitly allowing for 'printf injection' here, so it's ok to
just disable the corresponding shellcheck check.
2018-10-04 22:23:38 +02:00
e2593c0dcb
Fix SC2215 (missing brackets on if)
...
This might have never worked as intended, but how would you know?
2018-10-04 22:03:52 +02:00
fff656d1ac
Unquote $recursive to support empty-case
...
This is safe to do, as the value of $recursive is not dependent on
user-supplied code.
2018-10-04 19:45:26 +02:00
53728a7ff0
Change backslash-dquote to single quote
...
Slightly breaking change, but improves security and readability.
2018-10-04 19:45:26 +02:00
ae7ccc5995
Fix SC2086 on all scripts
...
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086
relates to: #540
This commit addresses 241 separate cases of missing quotes around
variables.
2018-10-04 19:45:22 +02:00
23debd5b6f
Use cur_ip in jail for freebsd
2018-10-04 19:22:28 +02:00
352679386d
Drop unused options parameter in __install_reboot
2018-10-04 19:22:28 +02:00
b3f4d3849a
Fix __install_umount target parameter
2018-10-04 19:22:28 +02:00
6b0f8fba22
Remove unused variables (almost, found bugs?)
...
Solves SC2034
references #540 .
2018-10-04 19:22:28 +02:00
tom
085b2a2b10
remove `set -e` on explorers (they should be able to fail gracefully)
2018-10-04 17:38:39 +02:00
tom
a46da35bbc
fix SC2148 (missing shebang) and make executable
2018-10-04 17:38:38 +02:00
tom
d950ddada3
fix SC2045 (use globs instead of `ls`)
2018-10-04 16:01:45 +02:00
e1b62ec560
Merge pull request #699 from darko-poljak/SC2039
...
Fix SC2039
2018-10-04 09:08:23 +02:00
8ef2773c0d
Fix SC2039
2018-10-03 14:32:39 +02:00
44acfcdd12
Fix SC2002
2018-10-03 14:12:07 +02:00
e69be05f70
Merge pull request #694 from darko-poljak/SC2005
...
Fix SC2005
2018-10-02 21:49:45 +02:00
d29534861b
Merge pull request #695 from darko-poljak/SC2004
...
Fix SC2004
2018-10-02 21:49:01 +02:00
0928708d19
Fix SC2004
2018-10-02 20:34:54 +02:00
5ed95ce93b
Fix SC2005
2018-10-02 20:22:44 +02:00
6326eae1bb
Fix SC2166 on all manfest/gencode/explorers
2018-10-01 22:13:24 +02:00
b3f3b907a4
Quote aptget command and params, simplify explorer
2018-09-12 11:36:11 +02:00
346f1f8af3
Send messages when installing packages via __package_apt
2018-09-12 11:36:06 +02:00
2e653409c1
Update __docker type
...
- Update installation method, following official installation
instructions.
- docker-engine was renamed to Docker CE around March 2017. Update
manpage to reflect that change.
- Remove flag `--experimental` since it is no longer necessary to install a
different binary to get experimental features. Experimental features are
included in the stable binary and can be enabled by a flag or in a
config file.
2018-09-07 11:38:49 +02:00
a627247908
Check if certbot exists before using it. Fixes #685 .
2018-09-01 23:27:58 +02:00
ad46c39c86
Merge branch 'master' into master
2018-08-30 15:56:19 -07:00
93d877f5bf
Add nonparallel marker for __apt_source type.
2018-08-30 20:22:51 +02:00
f143a70463
Support pacman with --maxage parameter
2018-08-29 11:31:31 -07:00
b12c02138d
Refactor __package_update_index explorers
...
* add an type explorer to unify detecting of package type.
* update currage use the type explorer, so if os and passed in type
does not match, it behaves correctly.
2018-08-29 00:22:28 -07:00
2f89d8a514
Fix __package_update_index processing error
...
exit 1 in explorer will abort cdist.
2018-08-29 00:22:28 -07:00
f04f76524c
Bugfix:
...
- __grafana_dashboard had the wrong release name for devuan ascii
2018-07-22 18:35:30 +02:00
43982f821f
__systemd_unit: add support for masking units
2018-07-11 16:22:36 +02:00
37b37f6e66
__systemd_unit: fix crash when transitioning to state=absent
...
This type tried to disable an unit after it has removed it, which
failed. Now the removal happens in gencode-remote, after the unit has
been stopped and disabled.
2018-07-11 16:22:36 +02:00
8d84834db6
__systemd_unit: manpage clarifications
...
Clarify that this type only operates on units in /etc/systemd/system.
Also, when state=present, it is not always true that the type is
"installed, enabled and started"
2018-07-11 16:16:08 +02:00
6c8014b407
__letsencrypt_cert: add support for devuan ascii
2018-06-22 14:09:31 +02:00
4eaace7dd5
Handle missing file in __line explorer gracefully
...
closes #675
2018-06-20 11:14:25 +02:00
ec8f2f9488
Fix temp file location and removal
2018-06-20 08:29:41 +02:00
f75af95bda
Merge pull request #663 from asteven/type/__line
...
RFC: rewrite __line type for --before and --after support
2018-06-16 10:51:33 +02:00
9d4c0331a9
__sysctl: support sysctl.d
2018-06-16 07:42:43 +02:00
ander
d7a1645e4e
__acl: fix os explorer
2018-06-11 11:21:07 +03:00
ander
90adefe2e4
add __acl: Basic wrapper around setfacl
2018-06-08 15:06:35 +03:00
4516ee0baa
position can not be empty
...
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2018-06-01 15:27:40 +02:00
efebe15386
Fix __letsencrypt_cert type: use object id as domain if domain param is not specified
2018-05-30 19:38:56 +02:00
Darko Poljak
Jonas Weber
tom
Jonas Weber
Adam Dej
Stu Zhao
Darko Poljak
Dominique Roux
Jonas Weber
ander
Steven Armstrong