Refactor getting primary ip of a vm

2018-06-27 01:06:10 +02:00 · 2018-06-27 01:06:10 +02:00 · 4a5c5f7942
parent 1ec7cb8761
commit 4a5c5f7942
1 changed files with 2 additions and 8 deletions
--- a/opennebula_api/models.py
+++ b/opennebula_api/models.py
@ -629,14 +629,8 @@ class OpenNebulaManager():
                         "the ssh keys.".format(self.email))
            for order in all_orders:
                try:
-                    vm = self.get_vm(order.vm_id)
-                    for nic in vm.template.nics:
-                        if hasattr(nic, 'ip'):
-                            if str(nic.ip).startswith("10."):
-                                if hasattr(nic, 'ip6_global'):
-                                    hosts.append(nic.ip6_global)
-                            else:
-                                hosts.append(nic.ip)
+                    ip = self.get_primary_ip(order.vm_id)
+                    hosts.append(ip)
                except WrongIdError:
                    logger.debug(
                        "VM with ID {} does not exist".format(order.vm_id))