romain-dartigues/cdist-contrib
1
0
Fork 0
forked from ungleich-public/cdist-contrib
Code Pull requests Activity

__netbox: fix shellcheck by changing parameter checks

Browse source 
The working `ls | grep .` like solution was dropped based on the
shellcheck warning. Rather a solution with `find(1)` is used.

As alternative, it could be simply checked if the glob succeeds or not
by test all given arguments if there are existing files. It was dropped
in question if it's really better than the `find(1)` solution.
This commit is contained in:
matze 2020-08-20 19:37:09 +02:00
parent 0281b2c804
commit a05cb214e1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
type/__netbox/files/ldap_config.py.sh
View file

@ -1,7 +1,7 @@
#!/bin/sh #!/bin/sh
# no configuration if there are no ldap parameters # no configuration if there are no ldap parameters
if ls -1qA "$__object/parameter"/ldap-* | grep -q .; then if [ "$(find "$__object/parameter/" -type f -name 'ldap-*' -print)" ]; then
# skip # skip
cat << EOF cat << EOF
############################## ##############################