Commit Graph

18 Commits

Author SHA1 Message Date
tom c5098dfcc5 fix [SC1117] (explicitly excaping `\n`) 2018-10-12 14:05:38 +02:00
tom c950dd1e90 quote "remote user", ensuring `user` is handled as one parameter 2018-10-12 14:05:38 +02:00
tom c995d08ce2 redirect stdout+stderr of `userdel`
If no mail-spoolfile exists for the user the error reporting was
visible in the cdist-run.
2018-10-12 14:05:38 +02:00
tom a1bf381370 add messaging 2018-10-12 14:05:38 +02:00
tom 409d736339 explicitly check for `absent` to handle state-typos gracefully 2018-10-12 14:05:38 +02:00
Darko Poljak 49bb041330
Merge pull request #696 from thriqon/shellcheck-party-SC2086
Fix SC2086 on all scripts
2018-10-05 10:26:53 +02:00
Jonas Weber 34b571b7d9 Fix SC2091 (execute result of condition)
For some reason, the echo|grep pattern was enclosed four times in a $()
operation. Nothing happened, since grep is always invoked with -q
(quiet, nothing printed to stdout).
2018-10-04 22:23:48 +02:00
Jonas Weber ae7ccc5995 Fix SC2086 on all scripts
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086

relates to: #540

This commit addresses 241 separate cases of missing quotes around
variables.
2018-10-04 19:45:22 +02:00
tom d950ddada3 fix SC2045 (use globs instead of `ls`) 2018-10-04 16:01:45 +02:00
Darko Poljak 62378dc8b9 Change shebang to #!/bin/sh -e 2017-06-28 13:19:32 +02:00
kamila c4996396c6 __user type: fix for FreeBSD 2016-11-22 18:21:03 +01:00
Nico Schottelius d288acbe30 Merge remote-tracking branch 'steven/issue/236'
Signed-off-by: Nico Schottelius <nico@bento.schottelius.org>

Conflicts:
	cdist/conf/type/__user/gencode-remote
2013-12-20 08:53:01 +01:00
Steven Armstrong 80fffbad11 implement messaging for __user type
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2013-12-19 11:21:44 +01:00
Daniel Heule 7d4c11a186 reset false mode changes 2013-12-17 14:15:41 +01:00
Daniel Heule 138d26e398 extended type __user: parameter state, system, remove-home new 2013-12-17 14:13:20 +01:00
Nico Schottelius 352c7da46c quote the new value check - may contains spaces
Signed-off-by: Nico Schottelius <nico@brief.schottelius.org>
2013-04-02 09:21:01 +02:00
Arkaitz Jimenez 60f85c5b85 __user support for --create-home 2013-04-01 00:02:22 +02:00
Nico Schottelius 63573a9797 make package_data work
Signed-off-by: Nico Schottelius <nico@brief.schottelius.org>
2012-10-29 22:50:27 +01:00