Merge pull request #288 from Modulos/fix/vm_name

Remove public- from vm name
This commit is contained in:
Levi Velázquez 2017-05-30 09:25:52 -05:00 committed by GitHub
commit 3c29e68b96
2 changed files with 12 additions and 1 deletions

View file

@ -79,7 +79,7 @@ class VirtualMachineTemplateSerializer(serializers.Serializer):
class VirtualMachineSerializer(serializers.Serializer): class VirtualMachineSerializer(serializers.Serializer):
"""Serializer to map the virtual machine instance into JSON format.""" """Serializer to map the virtual machine instance into JSON format."""
name = serializers.CharField(read_only=True) name = serializers.SerializerMethodField()
cores = serializers.IntegerField(source='template.vcpu') cores = serializers.IntegerField(source='template.vcpu')
disk = serializers.IntegerField(write_only=True) disk = serializers.IntegerField(write_only=True)
set_memory = serializers.IntegerField(write_only=True, label='Memory') set_memory = serializers.IntegerField(write_only=True, label='Memory')
@ -164,6 +164,8 @@ class VirtualMachineSerializer(serializers.Serializer):
nic = obj.template.nics[0] nic = obj.template.nics[0]
return nic.ip6_global return nic.ip6_global
def get_name(self, obj):
return obj.name.strip('public-')
def hexstr2int(string): def hexstr2int(string):
return int(string.replace(':', ''), 16) return int(string.replace(':', ''), 16)

View file

@ -114,6 +114,15 @@ class VirtualMachineTestCase(TestCase):
self.virtualmachine = VirtualMachine(opennebula_id=self.opennebula_id, self.virtualmachine = VirtualMachine(opennebula_id=self.opennebula_id,
template=self.template) template=self.template)
def test_serializer_strips_of_public(self):
""" Test the serialized object contains no 'public-'."""
template = self.manager.get_templates().first()
serialized = VirtualMachineTemplateSerializer(template)
self.assertEqual(serialized.data.name, template.name.strip('public-'))
def test_model_can_create_a_virtualmachine(self): def test_model_can_create_a_virtualmachine(self):
"""Test the virtualmachine model can create a virtualmachine.""" """Test the virtualmachine model can create a virtualmachine."""
old_count = VirtualMachine.objects.count() old_count = VirtualMachine.objects.count()