mentioned in merge request !885
closed via merge request !885
mentioned in commit fc9ce280f786cd40bd8c17622a9856697a735c1a
@ander Should I do something @ github? Merge those PRs? Or just merge them into gitlab master with merge commit?
@ander Hah, it works: https://github.com/ungleich/cdist/pull/779 is marked as merged.
I manually merged gitlab master with original branch from PR, using git merge --no-ff as suggested at github…
This issue could easily be fixed (cf. also PEP 380):
for plugin in preos_plugin(module):
yield plugin
I know, but I am not sure if it's worth it to keep supporting old Python versions.
If it can be fixed with a one line change, why not? If more changes are required, this can be discussed, IMO.
Hm... yield from is actually used in more places :)
$ find . -type f -name "*py" -exec grep 'yield from' {} +
./cdist/config.py: yield from…
We are also using subprocess.DEVNULL which is introduced in 3.3.
I wonder what else.
Is it worth to go deeper and deeper?
Nobody is complaining since 2017. when DEVNULL is introduced :)
It seems it was a woman :) Grace Hopper.
https://en.wikiquote.org/wiki/Grace_Hopper
@steven So if I get you right, we should just do it. :)
@poljakowski OK, I see. So it seems that Python 3.2 is not used anymore.
Could we bump the minimum requirement to 3.4 instead of 3.5?
I still have Debian jessie systems around (one of them being…
I can push these upstream if someone is interested:
[21:54:25] eos:.cdist-hpc% la type/
@ssrq For now, we will not bump min required version. At least not until both cdist BDFLs give a green light :)