[__opendkim_key] Overall improvements in key management #22

Open
evilham wants to merge 4 commits from opendkim-improvements into master
evilham commented 3 months ago
Collaborator

While developing this, I noticed that the type was handling inconsistently the
expectation that a cdist object with the same __object_id gets modified.
Instead more and more lines were added to, e.g. SigningTable and KeyTable.

In order to solve this, some backwards compatibility breaking is necessary.

This is probably not too terrible since:

  • the --selector parameter was mandatory, therefore the fallback for the key
    location is triggered.
  • OpenDKIM uses the first match in SigningTable and KeyTable
  • __line and __block respectively append if they do not match

Closes #19 and #20

While developing this, I noticed that the type was handling inconsistently the expectation that a cdist object with the same __object_id gets *modified*. Instead more and more lines were added to, e.g. SigningTable and KeyTable. In order to solve this, some backwards compatibility breaking is necessary. This is probably not too terrible since: - the `--selector` parameter was mandatory, therefore the fallback for the key location is triggered. - OpenDKIM uses the first match in `SigningTable` and `KeyTable` - __line and __block respectively append if they do not match Closes #19 and #20
evilham added 3 commits 3 months ago
9473f34910 [__opendkim] FreeBSD: Fix service name inconsistency
91e8020837 [__opendkim] Deprecate --userid
60c6ee54a1
[__opendkim_key] Overall improvements in key management
evilham added 1 commit 3 months ago
c47d4dbaf2
[__opendkim_genkey] Improve error text for unsupported OS
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.