opendkim: fix freebsd startonboot #31

evilham · 2024-05-16T10:39:38Z

evilham commented

2024-05-16 10:39:38 +00:00

Ehem, forgot to split on a different branch from !30 '-.-... Oh well, commit is actually just: ungleich-public/cdist-contrib@bebd83cfa6

If accepted in the right order it ought to work :-D else, happy to do the rebasing dance.

Ehem, forgot to split on a different branch from !30 '-.-... Oh well, commit is actually just: https://code.ungleich.ch/ungleich-public/cdist-contrib/commit/bebd83cfa622c0df4298d3681864bf7b3bec34fe If accepted in the right order it ought to work :-D else, happy to do the rebasing dance.

evilham added 3 commits

2024-05-16 10:39:38 +00:00

[__jitsi_meet*] Update to 2.0.9457 2705f268bb

Changelog:	https://github.com/jitsi/jitsi-meet-release-notes/blob/master/CHANGELOG-WEB.md#209457-2024-04-23

Sponsored by:	camilion.eu, eXO.cat

__jitsi_meet: improve screensharing in certain situations 3f34a674b0

We had been noticing issues when sharing screen that required
refreshing (sometimes from presentors, sometimes from receivers), or
else people would get a shared black screen or hanging screen after
some time.

This somewhat undocumented jitsi-videobridge setting appears to have
fixed the issue on all instances tested:

    videobridge.cc.trust-bwe = false

Announcement: https://agora.exo.cat/t/exofasia-3/276#meetexocatguifinet-4

Relevant links:
- https://community.jitsi.org/t/jitsi-users-video-turned-off-to-save-bandwidth-on-meet-jit-si/12735/2
- https://github.com/jitsi/jitsi-videobridge/blob/master/CONFIG.md#migrating-from-old-config

Sponsored by:	camilion.eu, eXO.cat

__opendkim: fix start_on_boot on FreeBSD bebd83cfa6

There was a bit of an oddity with this, it is implemented in a way
that should not be an issue for other systems.

evilham changed title from ~~opendkim-freebsd-startonboot~~ to opendkim: fix freebsd startonboot

2024-05-16 10:39:48 +00:00

fnux reviewed

2024-05-24 07:34:52 +00:00

type/__opendkim/manifest

					
				@ -29,6 +29,7 @@ case "$os" in

				'freebsd')

					CFG_DIR="/usr/local/etc/mail"

					service="milter-opendkim"

					start_service="milteropendkim"

Why is the service name used to restart the service different as the one used to start it...?

require="__package/opendkim" __start_on_boot "${start_service:-${service}}"
[...]
__check_messages opendkim \
		--pattern "^__file${target_file}" \
		--execute "service ${service} restart"

Why is the service name used to restart the service different as the one used to start it...? ```sh require="__package/opendkim" __start_on_boot "${start_service:-${service}}" [...] __check_messages opendkim \ --pattern "^__file${target_file}" \ --execute "service ${service} restart" ```

Closing this MR as gitea borked it when updating it.

Anyway, adding this comment to the manifest:

# Due to the way rc.conf works on *BSD, we find ourselves in the awkward
# situation, where a service's name can contain a '-' symbol, but the
# rc.conf setting to enable a service at boot cannot.
# Unless start_service has been defined before, these two match.
require="__package/opendkim" __start_on_boot "${start_service:-${service}}

Closing this MR as gitea borked it when updating it. Anyway, adding this comment to the manifest: ``` # Due to the way rc.conf works on *BSD, we find ourselves in the awkward # situation, where a service's name can contain a '-' symbol, but the # rc.conf setting to enable a service at boot cannot. # Unless start_service has been defined before, these two match. require="__package/opendkim" __start_on_boot "${start_service:-${service}} ```

evilham marked this conversation as resolved

evilham closed this pull request

2024-05-24 11:35:28 +00:00

evilham commented

2024-05-24 22:05:58 +00:00

Replaced with !33