Commit Graph

14 Commits

Author SHA1 Message Date
Mark Verboom 08ff41efde Added rm of tmpfile. 2022-03-08 12:04:58 +01:00
Dennis Camera fb19f34266 [type/__ssh_authorized_key] Only grep if file exists 2021-03-09 21:15:26 +01:00
Darko Poljak a9f27beb98 Fix SC1117. 2018-10-07 10:22:11 +02:00
Darko Poljak 644ec85d80 Fix SC2162. 2018-10-05 12:50:01 +02:00
Jonas Weber ae7ccc5995 Fix SC2086 on all scripts
Relevant documentation: https://github.com/koalaman/shellcheck/wiki/SC2086

relates to: #540

This commit addresses 241 separate cases of missing quotes around
variables.
2018-10-04 19:45:22 +02:00
Darko Poljak 44acfcdd12 Fix SC2002 2018-10-03 14:12:07 +02:00
tom 5eb478da95 Add messaging to __ssh_authorized_key. (#590) 2017-10-31 07:56:25 +01:00
Darko Poljak 8883196efb Bugfix for: __ssh_authorized_keys overwrites existing keys #577 (#579)
* Fix a bug where invalid key removes all file entries.

* __ssh_authorized_key: add key validation.
2017-09-17 08:13:05 +02:00
Darko Poljak 62378dc8b9 Change shebang to #!/bin/sh -e 2017-06-28 13:19:32 +02:00
Steven Armstrong 28027f4261 dont fail just because grep in subshell exited non-zero
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2014-10-22 14:32:32 +02:00
Steven Armstrong 41782cb107 workaround special case where the desired key was already present more then once in target file
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2014-09-29 14:47:25 +02:00
Steven Armstrong 4c52b10f93 maybe better define variable _before_ using it
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2014-09-29 10:57:27 +02:00
Steven Armstrong 4125dfaab0 them files should end in newline stupid
Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2014-09-29 10:46:00 +02:00
Steven Armstrong b17a1f0edb removing and adding keys must be atomic
If we delegate this to multiple seprarate objects (e.g. using __line) and the
config run is interrupted after applying only some of them we may leave the
target in some random state.
We may have even locked ourself out of the target.

So remove and add keys ourself so either none are all changes are
applied.

Signed-off-by: Steven Armstrong <steven@icarus.ethz.ch>
2014-09-27 11:40:06 +02:00