unexpected result using __line type #24
Labels
No Label
bugfix
cleanup
discussion
documentation
doing
done
feature
improvement
packaging
Stale
testing
TODO
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: ungleich-public/cdist#24
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
execute test
result:
@pedro The
__hosts
type has many issues of its own (cf. #826). Don't use it as an example.@pedro If you're interested in modifying network interfaces you might be interested in !838.
The MR is actually working, but still marked WIP because I can't make up my mind how and if dual stack configurations should be handled.
@ander that's nice, object-ids are unique, so if we are always appending automatically the object ID as a comment on each line introduced, then it would work. I saw something in __hosts type, which, oh wow, it uses __line type too in a very similar use case, and they solved it implementing what you said:
https://code.ungleich.ch/ungleich-public/cdist/-/blob/master/cdist/conf/type/__hosts/manifest#L26
so what about moving that marker in __line type so more types and custom manifests can benefit of using __line multiple times
can confirm.
reason is that
__line
will allow only one occurence of--line X
.usecase is totally valid, but
__line
is not designed this usecase in mind. not a bug, but rather shortcoming.one possible workaround is to make lines somewhat unique, for example:
but this doesn't fly with every file format.
my awk-fu isn't that good, so I can't help with a "fix" here 😿
I have the same output, I hope is easy enough to test
race condition, because no dependency defined and parallel execution?
add
require='__line/test_eno1' \
before__line test_eno2 \
changed the description